Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[content-visibility] Make content-visibility animatable #22116

Merged
merged 1 commit into from
Dec 20, 2023
Merged

[content-visibility] Make content-visibility animatable #22116

merged 1 commit into from
Dec 20, 2023

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Dec 20, 2023 •
edited by webkit-early-warning-system
Loading

6fb4594

[content-visibility] Make content-visibility animatable
https://bugs.webkit.org/show_bug.cgi?id=266712
rdar://119940258

Reviewed by Simon Fraser.

Make content-visibility animatable as specified by https://drafts.csswg.org/css-contain-3/#content-visibility-animation

* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-077-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-interpolation-expected.txt:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const):
* Source/WebCore/rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
* Source/WebCore/rendering/style/RenderStyleConstants.h:

Canonical link: https://commits.webkit.org/272364@main

1889aba

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@nt1m nt1m requested a review from graouts as a code owner December 20, 2023 17:44
@nt1m nt1m self-assigned this Dec 20, 2023
@nt1m nt1m added the Animations Bugs related to CSS + SVG animations and transitions label Dec 20, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 20, 2023 •
edited
Loading

EWS run on current version of this PR (hash 1889aba)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@nt1m nt1m requested review from smfr and anttijk December 20, 2023 17:48
@nt1m nt1m added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Dec 20, 2023
@nt1m
[content-visibility] Make content-visibility animatable
6fb4594 
https://bugs.webkit.org/show_bug.cgi?id=266712
rdar://119940258

Reviewed by Simon Fraser.

Make content-visibility animatable as specified by https://drafts.csswg.org/css-contain-3/#content-visibility-animation

* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-077-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-interpolation-expected.txt:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const):
* Source/WebCore/rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
* Source/WebCore/rendering/style/RenderStyleConstants.h:

Canonical link: https://commits.webkit.org/272364@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/content-visibility-Make-content-visibility-animatable branch from 1889aba to 6fb4594 Compare December 20, 2023 19:58
@webkit-commit-queue
Copy link
Collaborator

Committed 272364@main (6fb4594): https://commits.webkit.org/272364@main

Reviewed commits have been landed. Closing PR #22116 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6fb4594 into WebKit:main Dec 20, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 20, 2023
@nt1m nt1m mentioned this pull request Jan 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smfr smfr smfr approved these changes

@graouts graouts Awaiting requested review from graouts graouts is a code owner

@anttijk anttijk Awaiting requested review from anttijk

Assignees

@nt1m nt1m

Labels
Animations Bugs related to CSS + SVG animations and transitions
Projects
None yet
Milestone
No milestone
4 participants
@nt1m @webkit-early-warning-system @webkit-commit-queue @smfr