Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebGPU] CTS validation/render_pipeline/fragment_state.html is failing #22135

Merged
merged 1 commit into from
Jan 2, 2024
Merged

[WebGPU] CTS validation/render_pipeline/fragment_state.html is failing #22135

merged 1 commit into from
Jan 2, 2024

Conversation

mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented Dec 20, 2023 •
edited by webkit-early-warning-system
Loading

b5b8ddd

[WebGPU] CTS validation/render_pipeline/fragment_state.html is failing
https://bugs.webkit.org/show_bug.cgi?id=266670
<radar://119899867>

Reviewed by Tadeu Zagallo.

Add validation such that all subcases under the CTS render_pipeline/fragment_state.html now pass.

* LayoutTests/http/tests/webgpu/webgpu/api/validation/render_pipeline/fragment_state-expected.txt:
Add passing expectations.

* LayoutTests/http/tests/webgpu/webgpu/api/validation/render_pipeline/fragment_state.spec.js:
Update to latest version of the test.

* Source/WebCore/Modules/WebGPU/GPUColorWrite.h:
(WebCore::compare):
(WebCore::convertColorWriteFlagsToBacking):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUConvertToBackingContext.cpp:
(WebCore::WebGPU::compare):
(WebCore::WebGPU::ConvertToBackingContext::convertColorWriteFlagsToBacking):
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.serialization.in:
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUColorTargetState.h:
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUColorWrite.h:
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser<Lexer>::parseAttribute):
* Source/WebGPU/WGSL/WGSLShaderModule.h:
(WGSL::ShaderModule::usesSampleMask const):
(WGSL::ShaderModule::setUsesSampleMask):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::hasAlphaChannel):
(WebGPU::textureFormatAllowedForRetunType):
(WebGPU::Device::createRenderPipeline):
* Source/WebGPU/WebGPU/ShaderModule.h:
* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::metalDataTypeForStructMember):
(WebGPU::parseReturnType):
(WebGPU::ShaderModule::ShaderModule):
(WebGPU::ShaderModule::returnTypeForEntryPoint const):
* Source/WebGPU/WebGPU/Texture.h:
* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::renderTargetPixelByteCost):
(WebGPU::Texture::renderTargetPixelByteAlignment):
* Source/WebKit/Shared/WebGPU/WebGPUColorTargetState.h:
Add validation.

Canonical link: https://commits.webkit.org/272576@main

b9929b6

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski self-assigned this Dec 20, 2023
@mwyrzykowski mwyrzykowski added the WebGPU For bugs in WebGPU label Dec 20, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 20, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 2147b5f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski changed the title [WebGPU] [WebGPU] CTS validation/render_pipeline/fragment_state.html is failing Dec 20, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 21, 2023
@mwyrzykowski mwyrzykowski removed the merging-blocked Applied to prevent a change from being merged label Dec 21, 2023
@mwyrzykowski mwyrzykowski changed the title [WebGPU] CTS validation/render_pipeline/fragment_state.html is failing [WebGPU] Dec 21, 2023
@mwyrzykowski mwyrzykowski force-pushed the eng/WebGPU-validationrender_pipeline_fragment_state-is-failing branch from 2147b5f to c144a50 Compare December 21, 2023 17:30
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 21, 2023 •
edited
Loading

EWS run on current version of this PR (hash c144a50)

Misc iOS, tvOS & watchOS macOS Linux Windows
⏳ 🧪 style ⏳ 🛠 ios loading 🛠 mac loading 🛠 wpe ⏳ 🛠 wincairo
loading 🧪 bindings ⏳ 🛠 ios-sim ⏳ 🛠 mac-AS-debug loading 🧪 wpe-wk2
loading 🧪 webkitperl ⏳ 🧪 ios-wk2 loading 🧪 api-mac loading 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt loading 🧪 mac-wk1 loading 🛠 gtk
⏳ 🧪 api-ios loading 🧪 mac-wk2 loading 🧪 gtk-wk2
loading 🛠 🧪 jsc-arm64 ⏳ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2 loading 🧪 api-gtk
loading 🧪 services ⏳ 🛠 tv-sim loading 🧪 mac-wk2-stress ⏳ 🛠 jsc-armv7
⏳ 🛠 watch ⏳ 🧪 jsc-armv7-tests
⏳ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 21, 2023 •
edited
Loading

EWS run on previous version of this PR (hash c144a50)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 gtk
  🧪 api-ios   🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 tv   🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski force-pushed the eng/WebGPU-validationrender_pipeline_fragment_state-is-failing branch from c144a50 to d2991b9 Compare December 21, 2023 17:48
@webkit-early-warning-system
Copy link
Collaborator

Starting EWS tests for d2991b9. Live statuses available at the PR page, #22135

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 21, 2023 •
edited
Loading

EWS run on previous version of this PR (hash d2991b9)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 21, 2023
@mwyrzykowski mwyrzykowski removed the merging-blocked Applied to prevent a change from being merged label Dec 21, 2023
@mwyrzykowski mwyrzykowski force-pushed the eng/WebGPU-validationrender_pipeline_fragment_state-is-failing branch from d2991b9 to e7b2326 Compare December 21, 2023 20:12
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 21, 2023 •
edited
Loading

EWS run on previous version of this PR (hash e7b2326)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski changed the title [WebGPU] [WebGPU] CTS validation/render_pipeline/fragment_state.html is failing Dec 21, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 21, 2023
@mwyrzykowski mwyrzykowski removed the merging-blocked Applied to prevent a change from being merged label Dec 22, 2023
@mwyrzykowski mwyrzykowski force-pushed the eng/WebGPU-validationrender_pipeline_fragment_state-is-failing branch from e7b2326 to a0d38d2 Compare January 2, 2024 14:39
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 2, 2024 •
edited
Loading

EWS run on previous version of this PR (hash a0d38d2)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings   🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ⏳ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Jan 2, 2024
@mwyrzykowski mwyrzykowski force-pushed the eng/WebGPU-validationrender_pipeline_fragment_state-is-failing branch from a0d38d2 to b9929b6 Compare January 2, 2024 16:44
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 2, 2024 •
edited
Loading

EWS run on current version of this PR (hash b9929b6)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jan 2, 2024
@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Jan 2, 2024
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #8048.

@mwyrzykowski
[WebGPU] CTS validation/render_pipeline/fragment_state.html is failing
b5b8ddd 
https://bugs.webkit.org/show_bug.cgi?id=266670
<radar://119899867>

Reviewed by Tadeu Zagallo.

Add validation such that all subcases under the CTS render_pipeline/fragment_state.html now pass.

* LayoutTests/http/tests/webgpu/webgpu/api/validation/render_pipeline/fragment_state-expected.txt:
Add passing expectations.

* LayoutTests/http/tests/webgpu/webgpu/api/validation/render_pipeline/fragment_state.spec.js:
Update to latest version of the test.

* Source/WebCore/Modules/WebGPU/GPUColorWrite.h:
(WebCore::compare):
(WebCore::convertColorWriteFlagsToBacking):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUConvertToBackingContext.cpp:
(WebCore::WebGPU::compare):
(WebCore::WebGPU::ConvertToBackingContext::convertColorWriteFlagsToBacking):
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.serialization.in:
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUColorTargetState.h:
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUColorWrite.h:
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser<Lexer>::parseAttribute):
* Source/WebGPU/WGSL/WGSLShaderModule.h:
(WGSL::ShaderModule::usesSampleMask const):
(WGSL::ShaderModule::setUsesSampleMask):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::hasAlphaChannel):
(WebGPU::textureFormatAllowedForRetunType):
(WebGPU::Device::createRenderPipeline):
* Source/WebGPU/WebGPU/ShaderModule.h:
* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::metalDataTypeForStructMember):
(WebGPU::parseReturnType):
(WebGPU::ShaderModule::ShaderModule):
(WebGPU::ShaderModule::returnTypeForEntryPoint const):
* Source/WebGPU/WebGPU/Texture.h:
* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::renderTargetPixelByteCost):
(WebGPU::Texture::renderTargetPixelByteAlignment):
* Source/WebKit/Shared/WebGPU/WebGPUColorTargetState.h:
Add validation.

Canonical link: https://commits.webkit.org/272576@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-validationrender_pipeline_fragment_state-is-failing branch from b9929b6 to b5b8ddd Compare January 2, 2024 20:23
@webkit-commit-queue webkit-commit-queue merged commit b5b8ddd into WebKit:main Jan 2, 2024
@webkit-commit-queue
Copy link
Collaborator

Committed 272576@main (b5b8ddd): https://commits.webkit.org/272576@main

Reviewed commits have been landed. Closing PR #22135 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeuzagallo tadeuzagallo tadeuzagallo approved these changes

@djg djg Awaiting requested review from djg djg is a code owner

Assignees

@mwyrzykowski mwyrzykowski

Labels
WebGPU For bugs in WebGPU
Projects
None yet
Milestone
No milestone
5 participants
@mwyrzykowski @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @tadeuzagallo