-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce use of downcast<>() in rendering/svg code #22178
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
cdumez:rendering_fewer_downcast2
Dec 22, 2023
Merged
Reduce use of downcast<>() in rendering/svg code #22178
webkit-commit-queue
merged 1 commit into
WebKit:main
from
cdumez:rendering_fewer_downcast2
Dec 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on current version of this PR (hash 706b5a6) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Dec 22, 2023
smfr
approved these changes
Dec 22, 2023
cdumez
added
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Dec 22, 2023
https://bugs.webkit.org/show_bug.cgi?id=266792 Reviewed by Simon Fraser. * Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp: (WebCore::RenderSVGGradientStop::gradientElement): * Source/WebCore/rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paintIntoRect): * Source/WebCore/rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::checkIntersection): (WebCore::RenderSVGModelObject::checkEnclosure): * Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyPathClipping): * Source/WebCore/rendering/svg/RenderSVGText.cpp: (WebCore::collectLayoutAttributes): (WebCore::findPreviousAndNextAttributes): (WebCore::updateFontInAllDescendants): * Source/WebCore/rendering/svg/RenderSVGTransformableContainer.cpp: (WebCore::associatedUseElement): * Source/WebCore/rendering/svg/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::computeViewportSize const): * Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp: (WebCore::SVGBoundingBoxComputation::handleShapeOrTextOrInline const): (WebCore::SVGBoundingBoxComputation::handleRootOrContainer const): * Source/WebCore/rendering/svg/SVGContainerLayout.cpp: (WebCore::SVGContainerLayout::layoutChildren): (WebCore::SVGContainerLayout::positionChildrenRelativeToContainer): (WebCore::SVGContainerLayout::transformToRootChanged): * Source/WebCore/rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paintSelectionBackground): (WebCore::SVGInlineFlowBox::calculateBoundaries const): * Source/WebCore/rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paint): * Source/WebCore/rendering/svg/SVGPathData.cpp: (WebCore::pathFromCircleElement): (WebCore::pathFromEllipseElement): (WebCore::pathFromLineElement): (WebCore::pathFromPathElement): (WebCore::pathFromPolygonElement): (WebCore::pathFromPolylineElement): (WebCore::pathFromRectElement): (WebCore::pathFromUseElement): (WebCore::pathFromGraphicsElement): * Source/WebCore/rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::localToParentTransform): (WebCore::SVGRenderSupport::checkForSVGRepaintDuringLayout): (WebCore::updateObjectBoundingBox): (WebCore::SVGRenderSupport::computeContainerBoundingBoxes): (WebCore::SVGRenderSupport::computeContainerStrokeBoundingBox): (WebCore::layoutSizeOfNearestViewportChanged): (WebCore::SVGRenderSupport::transformToRootChanged): (WebCore::SVGRenderSupport::layoutChildren): (WebCore::isPointInCSSClippingArea): (WebCore::SVGRenderSupport::clipContextToCSSClippingArea): (WebCore::SVGRenderSupport::applyStrokeStyleToContext): (WebCore::SVGRenderSupport::calculateApproximateStrokeBoundingBox): * Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeSVGPaintingResource): (WebCore::writeSVGStrokePaintingResource): (WebCore::writeSVGPaintingFeatures): (WebCore::writeSVGGraphicsElement): (WebCore::writeSVGInlineTextBoxes): (WebCore::writeResources): * Source/WebCore/rendering/svg/SVGRenderingContext.cpp: (WebCore::SVGRenderingContext::prepareToRenderSVGContent): * Source/WebCore/rendering/svg/SVGResources.cpp: (WebCore::targetReferenceFromResource): (WebCore::SVGResources::buildCachedResources): * Source/WebCore/rendering/svg/SVGResourcesCache.cpp: (WebCore::SVGResourcesCache::resourceDestroyed): * Source/WebCore/rendering/svg/SVGResourcesCycleSolver.cpp: (WebCore::SVGResourcesCycleSolver::resourceContainsCycles): (WebCore::SVGResourcesCycleSolver::resolveCycles): Canonical link: https://commits.webkit.org/272445@main
webkit-commit-queue
force-pushed
the
rendering_fewer_downcast2
branch
from
December 22, 2023 03:48
706b5a6
to
55b0823
Compare
Committed 272445@main (55b0823): https://commits.webkit.org/272445@main Reviewed commits have been landed. Closing PR #22178 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
55b0823
706b5a6