Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebGPU] WGSL compilation failure opening https://threejs.org/examples/?q=webgpu#webgpu_backdrop_water #22252

Conversation

tadeuzagallo
Copy link
Member

@tadeuzagallo tadeuzagallo commented Dec 27, 2023

b1e573c

[WebGPU] WGSL compilation failure opening https://threejs.org/examples/?q=webgpu#webgpu_backdrop_water
https://bugs.webkit.org/show_bug.cgi?id=266823
rdar://120054632

Reviewed by Mike Wyrzykowski.

The spec was updated to add an overload to u32 that accepts abstract_int as an
argument, and this patch updates our implementation to match the updated spec.
This required specializing the constant u32 constructor to handle the abstract_int
special case, since it differs from the other types in that it needs to check
for that can't fit in a u32. It also required fixing a bug in the overload resolution
where a type variable can be resolved to a type that doesn't satisfy its constraints.

* Source/WebGPU/WGSL/ConstantFunctions.h:
(WGSL::CONSTANT_FUNCTION):
* Source/WebGPU/WGSL/Overload.cpp:
(WGSL::OverloadResolver::calculateRank):
* Source/WebGPU/WGSL/TypeDeclarations.rb:
* Source/WebGPU/WGSL/tests/invalid/constants.wgsl:
* Source/WebGPU/WGSL/tests/valid/constants.wgsl:

Canonical link: https://commits.webkit.org/272520@main

a1ad2f4

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ›  gtk
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@tadeuzagallo tadeuzagallo self-assigned this Dec 27, 2023
@tadeuzagallo tadeuzagallo added the WebGPU For bugs in WebGPU label Dec 27, 2023
@tadeuzagallo tadeuzagallo added the merge-queue Applied to send a pull request to merge-queue label Dec 28, 2023
…s/?q=webgpu#webgpu_backdrop_water

https://bugs.webkit.org/show_bug.cgi?id=266823
rdar://120054632

Reviewed by Mike Wyrzykowski.

The spec was updated to add an overload to u32 that accepts abstract_int as an
argument, and this patch updates our implementation to match the updated spec.
This required specializing the constant u32 constructor to handle the abstract_int
special case, since it differs from the other types in that it needs to check
for that can't fit in a u32. It also required fixing a bug in the overload resolution
where a type variable can be resolved to a type that doesn't satisfy its constraints.

* Source/WebGPU/WGSL/ConstantFunctions.h:
(WGSL::CONSTANT_FUNCTION):
* Source/WebGPU/WGSL/Overload.cpp:
(WGSL::OverloadResolver::calculateRank):
* Source/WebGPU/WGSL/TypeDeclarations.rb:
* Source/WebGPU/WGSL/tests/invalid/constants.wgsl:
* Source/WebGPU/WGSL/tests/valid/constants.wgsl:

Canonical link: https://commits.webkit.org/272520@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-WGSL-compilation-failure-opening-httpsthreejs-orgexamplesqwebgpuwebgpu_backdrop_water branch from a1ad2f4 to b1e573c Compare December 28, 2023 13:07
@webkit-commit-queue
Copy link
Collaborator

Committed 272520@main (b1e573c): https://commits.webkit.org/272520@main

Reviewed commits have been landed. Closing PR #22252 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b1e573c into WebKit:main Dec 28, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebGPU For bugs in WebGPU
Projects
None yet
4 participants