Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebGPU] CTS validation/render_pipeline/vertex_state.html is failing #22304

Conversation

mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented Jan 2, 2024

ffbb520

[WebGPU] CTS validation/render_pipeline/vertex_state.html is failing
https://bugs.webkit.org/show_bug.cgi?id=266740
<radar://119958371>

Reviewed by Tadeu Zagallo.

Get render_pipeline/vertex_state passing and update the expectations.

* LayoutTests/http/tests/webgpu/webgpu/api/validation/render_pipeline/vertex_state-expected.txt:
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::vertexFormatSize):
(WebGPU::name):
(WebGPU::formatType):
(WebGPU::matchesFormat):
(WebGPU::createVertexDescriptor):
(WebGPU::Device::createRenderPipeline):
* Source/WebGPU/WebGPU/ShaderModule.h:
* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::vertexFormatTypeFromPrimitive):
(WebGPU::vertexFormatTypeForStructMember):
(WebGPU::populateStageInMap):
(WebGPU::parseStageIn):
(WebGPU::ShaderModule::ShaderModule):
(WebGPU::ShaderModule::stageInTypesForEntryPoint const):

Canonical link: https://commits.webkit.org/272662@main

dbc1324

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  gtk
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@mwyrzykowski mwyrzykowski self-assigned this Jan 2, 2024
@mwyrzykowski mwyrzykowski added the WebGPU For bugs in WebGPU label Jan 2, 2024
@mwyrzykowski mwyrzykowski changed the title [WebGPU] [WebGPU] CTS validation/render_pipeline/vertex_state.html is failing Jan 2, 2024
@mwyrzykowski mwyrzykowski changed the title [WebGPU] CTS validation/render_pipeline/vertex_state.html is failing [WebGPU] CTS validation/render_pipeline/ Jan 2, 2024
@mwyrzykowski mwyrzykowski force-pushed the eng/WebGPU_CTS_validation_render_pipeline_vertex_state_html_is_failing branch from 1e294fb to 8f6f336 Compare January 2, 2024 16:45
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 2, 2024
@mwyrzykowski mwyrzykowski removed the merging-blocked Applied to prevent a change from being merged label Jan 2, 2024
@mwyrzykowski mwyrzykowski force-pushed the eng/WebGPU_CTS_validation_render_pipeline_vertex_state_html_is_failing branch from 8f6f336 to 753a960 Compare January 2, 2024 17:38
@mwyrzykowski mwyrzykowski changed the title [WebGPU] CTS validation/render_pipeline/ [WebGPU] CTS validation/render_pipeline/vertex_state.html is failing Jan 3, 2024
@mwyrzykowski mwyrzykowski changed the title [WebGPU] CTS validation/render_pipeline/vertex_state.html is failing [WebGPU] CTS validation/render_pipeline/vertex_state.html is failing Jan 4, 2024
@mwyrzykowski mwyrzykowski force-pushed the eng/WebGPU_CTS_validation_render_pipeline_vertex_state_html_is_failing branch from 753a960 to dbc1324 Compare January 4, 2024 17:13
@mwyrzykowski mwyrzykowski added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jan 4, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 4, 2024
@mwyrzykowski mwyrzykowski added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Jan 4, 2024
https://bugs.webkit.org/show_bug.cgi?id=266740
<radar://119958371>

Reviewed by Tadeu Zagallo.

Get render_pipeline/vertex_state passing and update the expectations.

* LayoutTests/http/tests/webgpu/webgpu/api/validation/render_pipeline/vertex_state-expected.txt:
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::vertexFormatSize):
(WebGPU::name):
(WebGPU::formatType):
(WebGPU::matchesFormat):
(WebGPU::createVertexDescriptor):
(WebGPU::Device::createRenderPipeline):
* Source/WebGPU/WebGPU/ShaderModule.h:
* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::vertexFormatTypeFromPrimitive):
(WebGPU::vertexFormatTypeForStructMember):
(WebGPU::populateStageInMap):
(WebGPU::parseStageIn):
(WebGPU::ShaderModule::ShaderModule):
(WebGPU::ShaderModule::stageInTypesForEntryPoint const):

Canonical link: https://commits.webkit.org/272662@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU_CTS_validation_render_pipeline_vertex_state_html_is_failing branch from dbc1324 to ffbb520 Compare January 5, 2024 00:52
@webkit-commit-queue webkit-commit-queue merged commit ffbb520 into WebKit:main Jan 5, 2024
@webkit-commit-queue
Copy link
Collaborator

Committed 272662@main (ffbb520): https://commits.webkit.org/272662@main

Reviewed commits have been landed. Closing PR #22304 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebGPU For bugs in WebGPU
Projects
None yet
5 participants