Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dynamicDowncast<T> in AccessibilityARIAGridRow.cpp #22443

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Use dynamicDowncast<T> in AccessibilityARIAGridRow.cpp #22443

merged 1 commit into from
Jan 9, 2024

Conversation

joone
Copy link

@joone joone commented Jan 5, 2024 •
edited by webkit-early-warning-system
Loading

@joone joone self-assigned this Jan 5, 2024
@joone joone added the Accessibility For bugs related to accessibility. label Jan 5, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 5, 2024 •
edited
Loading

EWS run on previous version of this PR (hash a7abbd5)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@joone joone added WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). and removed Accessibility For bugs related to accessibility. labels Jan 8, 2024
@joone joone requested a review from cdumez January 8, 2024 08:48
cdumez
cdumez approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 2 changes.

Source/WebCore/accessibility/AccessibilityARIAGridRow.cpp Outdated Show resolved Hide resolved
Source/WebCore/accessibility/AccessibilityARIAGridRow.cpp Outdated Show resolved Hide resolved
@joone joone force-pushed the eng/Use-dynamicDowncastT-in-AccessibilityARIAGridRow-cpp branch from a7abbd5 to 4f46840 Compare January 9, 2024 02:53
@joone joone added Accessibility For bugs related to accessibility. and removed WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). labels Jan 9, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 9, 2024 •
edited
Loading

EWS run on current version of this PR (hash 4f46840)

Misc iOS, tvOS & watchOS macOS Linux Windows
⏳ 🧪 style loading 🛠 ios loading 🛠 mac loading 🛠 wpe ⏳ 🛠 wincairo
loading 🧪 bindings loading 🛠 ios-sim loading 🛠 mac-AS-debug loading 🧪 wpe-wk2
loading 🧪 webkitperl loading 🧪 ios-wk2 loading 🧪 api-mac loading 🧪 api-wpe
loading 🧪 ios-wk2-wpt loading 🧪 mac-wk1 loading 🛠 gtk
⏳ 🛠 🧪 jsc loading 🧪 api-ios loading 🧪 mac-wk2 loading 🧪 gtk-wk2
⏳ 🛠 tv loading 🧪 mac-AS-debug-wk2 loading 🧪 api-gtk
loading 🧪 services ⏳ 🛠 tv-sim loading 🧪 mac-wk2-stress loading 🛠 jsc-armv7
⏳ 🛠 watch loading 🧪 jsc-armv7-tests
⏳ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 9, 2024 •
edited
Loading

EWS run on current version of this PR (hash 4f46840)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@joone joone added the merge-queue Applied to send a pull request to merge-queue label Jan 9, 2024
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Use-dynamicDowncastT-in-AccessibilityARIAGridRow-cpp branch from 4f46840 to 208e146 Compare January 9, 2024 19:17
@webkit-commit-queue
Copy link
Collaborator

Committed 272824@main (208e146): https://commits.webkit.org/272824@main

Reviewed commits have been landed. Closing PR #22443 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 208e146 into WebKit:main Jan 9, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

Assignees

@joone joone

Labels
Accessibility For bugs related to accessibility.
Projects
None yet
Milestone
No milestone
4 participants
@joone @webkit-early-warning-system @webkit-commit-queue @cdumez