Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WGSL] shader,execution,expression,call,builtin,length:* is failing #22589

Merged
merged 1 commit into from
Jan 11, 2024
Merged

[WGSL] shader,execution,expression,call,builtin,length:* is failing #22589

merged 1 commit into from
Jan 11, 2024

Conversation

tadeuzagallo
Copy link
Member

@tadeuzagallo tadeuzagallo commented Jan 10, 2024 •
edited by webkit-early-warning-system
Loading

3c7ac2a

[WGSL] shader,execution,expression,call,builtin,length:* is failing
https://bugs.webkit.org/show_bug.cgi?id=267338
rdar://120784047

Reviewed by Mike Wyrzykowski.

We were missing a call to sqrt on the result of the constant function.

* Source/WebGPU/WGSL/ConstantFunctions.h:
(WGSL::CONSTANT_FUNCTION):

Canonical link: https://commits.webkit.org/272900@main

3062561

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@tadeuzagallo tadeuzagallo self-assigned this Jan 10, 2024
@tadeuzagallo tadeuzagallo added the WebGPU For bugs in WebGPU label Jan 10, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 10, 2024 •
edited
Loading

EWS run on current version of this PR (hash 3062561)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@tadeuzagallo tadeuzagallo added the merge-queue Applied to send a pull request to merge-queue label Jan 11, 2024
@tadeuzagallo
[WGSL] shader,execution,expression,call,builtin,length:* is failing
3c7ac2a 
https://bugs.webkit.org/show_bug.cgi?id=267338
rdar://120784047

Reviewed by Mike Wyrzykowski.

We were missing a call to sqrt on the result of the constant function.

* Source/WebGPU/WGSL/ConstantFunctions.h:
(WGSL::CONSTANT_FUNCTION):

Canonical link: https://commits.webkit.org/272900@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WGSL-shaderexecutionexpressioncallbuiltinlength-is-failing branch from 3062561 to 3c7ac2a Compare January 11, 2024 08:44
@webkit-commit-queue
Copy link
Collaborator

Committed 272900@main (3c7ac2a): https://commits.webkit.org/272900@main

Reviewed commits have been landed. Closing PR #22589 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 3c7ac2a into WebKit:main Jan 11, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwyrzykowski mwyrzykowski mwyrzykowski approved these changes

@djg djg Awaiting requested review from djg djg is a code owner

Assignees

@tadeuzagallo tadeuzagallo

Labels
WebGPU For bugs in WebGPU
Projects
None yet
Milestone
No milestone
4 participants
@tadeuzagallo @webkit-early-warning-system @webkit-commit-queue @mwyrzykowski