Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip installing XPC services on iOS #22729

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Skip installing XPC services on iOS #22729

merged 1 commit into from
Jan 12, 2024

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented Jan 12, 2024 •
edited by webkit-early-warning-system
Loading

@pvollan pvollan self-assigned this Jan 12, 2024
@pvollan pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Jan 12, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 12, 2024 •
edited
Loading

EWS run on current version of this PR (hash 5fd2460)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🛠 gtk
  🧪 api-ios   🧪 mac-wk2   🧪 gtk-wk2
  🛠 tv   🧪 mac-AS-debug-wk2   🧪 api-gtk
  🛠 tv-sim
  🛠 watch
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

brentfulgham
brentfulgham approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. r=me

@pvollan pvollan added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 12, 2024
@pvollan
Skip installing XPC services on iOS
0d72eb4 
https://bugs.webkit.org/show_bug.cgi?id=267470
rdar://120920137

Reviewed by Brent Fulgham.

Skip installing XPC services on iOS, since we are launching as extensions there.

* Source/WebKit/Configurations/BaseXPCService.xcconfig:

Canonical link: https://commits.webkit.org/272991@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Skip-installing-XPC-services-on-iOS branch from 5fd2460 to 0d72eb4 Compare January 12, 2024 21:57
@webkit-commit-queue
Copy link
Collaborator

Committed 272991@main (0d72eb4): https://commits.webkit.org/272991@main

Reviewed commits have been landed. Closing PR #22729 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0d72eb4 into WebKit:main Jan 12, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentfulgham brentfulgham brentfulgham approved these changes

@emw-apple emw-apple Awaiting requested review from emw-apple emw-apple is a code owner

@aestes aestes Awaiting requested review from aestes

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@pvollan @webkit-early-warning-system @webkit-commit-queue @brentfulgham