Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timeout in fast/images/decode-animated-image.html #22809

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fix timeout in fast/images/decode-animated-image.html #22809

merged 1 commit into from
Jan 29, 2024

Conversation

shallawa
Copy link
Contributor

@shallawa shallawa commented Jan 16, 2024 •
edited by webkit-early-warning-system

cc161d1

Fix timeout in fast/images/decode-animated-image.html
https://bugs.webkit.org/show_bug.cgi?id=267570
rdar://121034124

Reviewed by Cameron McCormack.

Call "internals.clearMemoryCache()" when initializing the test to reset the
animation state of the image.

* LayoutTests/fast/images/decode-animated-image.html:

Canonical link: https://commits.webkit.org/273668@main

c69fcdf

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@shallawa shallawa self-assigned this Jan 16, 2024
@shallawa shallawa added the Images For bugs in image handling. label Jan 16, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash c69fcdf)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@shallawa shallawa requested review from smfr and heycam January 17, 2024 16:23
@shallawa shallawa added the merge-queue Applied to send a pull request to merge-queue label Jan 29, 2024
@shallawa
Fix timeout in fast/images/decode-animated-image.html
cc161d1 
https://bugs.webkit.org/show_bug.cgi?id=267570
rdar://121034124

Reviewed by Cameron McCormack.

Call "internals.clearMemoryCache()" when initializing the test to reset the
animation state of the image.

* LayoutTests/fast/images/decode-animated-image.html:

Canonical link: https://commits.webkit.org/273668@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Fix-timeout-in-fastimagesdecode-animated-image-html branch from c69fcdf to cc161d1 Compare January 29, 2024 18:40
@webkit-commit-queue
Copy link
Collaborator

Committed 273668@main (cc161d1): https://commits.webkit.org/273668@main

Reviewed commits have been landed. Closing PR #22809 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit cc161d1 into WebKit:main Jan 29, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 29, 2024
@shallawa shallawa deleted the eng/Fix-timeout-in-fastimagesdecode-animated-image-html branch February 1, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heycam heycam heycam approved these changes

@smfr smfr Awaiting requested review from smfr

Assignees

@shallawa shallawa

Labels
Images For bugs in image handling.
Projects
None yet
Milestone
No milestone
4 participants
@shallawa @webkit-early-warning-system @webkit-commit-queue @heycam