Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt dynamicDowncast<> in WebPageIOS #22811

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Adopt dynamicDowncast<> in WebPageIOS #22811

merged 1 commit into from
Jan 16, 2024

Conversation

annevk
Copy link
Contributor

@annevk annevk commented Jan 16, 2024 •
edited by webkit-early-warning-system
Loading

26046f7

Adopt dynamicDowncast<> in WebPageIOS
https://bugs.webkit.org/show_bug.cgi?id=267573

Reviewed by Chris Dumez.

There's a couple remaining downcast<>s without obvious alternatives.

* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::handleSyntheticClick):
(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):
(WebKit::WebPage::commitPotentialTap):
(WebKit::WebPage::setFocusedElementValue):
(WebKit::WebPage::setFocusedElementSelectedIndex):
(WebKit::WebPage::absoluteInteractionBounds):
(WebKit::isAssistableElement):
(WebKit::imageRendererAndImage):
(WebKit::hostVideoElementIgnoringImageOverlay):
(WebKit::imagePositionInformation):
(WebKit::boundsPositionInformation):
(WebKit::selectionPositionInformation):
(WebKit::WebPage::positionInformation):
(WebKit::WebPage::performActionOnElement):
(WebKit::nextAssistableElement):
(WebKit::WebPage::focusedElementInformation):
(WebKit::WebPage::autofillLoginCredentials):
(WebKit::WebPage::removeTextPlaceholder):
(WebKit::WebPage::requestDocumentEditingContext):

Canonical link: https://commits.webkit.org/273088@main

70988e2

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk self-assigned this Jan 16, 2024
@annevk annevk added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Jan 16, 2024
@webkit-early-warning-system

This comment was marked as outdated.

Sign in to view
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 16, 2024
@annevk annevk added skip-ews Applied to prevent a change from being run on EWS and removed merging-blocked Applied to prevent a change from being merged skip-ews Applied to prevent a change from being run on EWS labels Jan 16, 2024
@annevk annevk force-pushed the eng/Adopt-dynamicDowncast-in-WebPageIOS branch from b69560e to 70988e2 Compare January 16, 2024 12:39
@webkit-early-warning-system

This comment was marked as duplicate.

Sign in to view
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 16, 2024 •
edited
Loading

EWS run on current version of this PR (hash 70988e2)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk marked this pull request as ready for review January 16, 2024 14:25
@annevk annevk requested a review from cdumez as a code owner January 16, 2024 14:25
@annevk annevk added the merge-queue Applied to send a pull request to merge-queue label Jan 16, 2024
@annevk
Adopt dynamicDowncast<> in WebPageIOS
26046f7 
https://bugs.webkit.org/show_bug.cgi?id=267573

Reviewed by Chris Dumez.

There's a couple remaining downcast<>s without obvious alternatives.

* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::handleSyntheticClick):
(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):
(WebKit::WebPage::commitPotentialTap):
(WebKit::WebPage::setFocusedElementValue):
(WebKit::WebPage::setFocusedElementSelectedIndex):
(WebKit::WebPage::absoluteInteractionBounds):
(WebKit::isAssistableElement):
(WebKit::imageRendererAndImage):
(WebKit::hostVideoElementIgnoringImageOverlay):
(WebKit::imagePositionInformation):
(WebKit::boundsPositionInformation):
(WebKit::selectionPositionInformation):
(WebKit::WebPage::positionInformation):
(WebKit::WebPage::performActionOnElement):
(WebKit::nextAssistableElement):
(WebKit::WebPage::focusedElementInformation):
(WebKit::WebPage::autofillLoginCredentials):
(WebKit::WebPage::removeTextPlaceholder):
(WebKit::WebPage::requestDocumentEditingContext):

Canonical link: https://commits.webkit.org/273088@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Adopt-dynamicDowncast-in-WebPageIOS branch from 70988e2 to 26046f7 Compare January 16, 2024 20:19
@webkit-commit-queue
Copy link
Collaborator

Committed 273088@main (26046f7): https://commits.webkit.org/273088@main

Reviewed commits have been landed. Closing PR #22811 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 26046f7 into WebKit:main Jan 16, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 16, 2024
@annevk annevk deleted the eng/Adopt-dynamicDowncast-in-WebPageIOS branch January 16, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

Assignees

@annevk annevk

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
5 participants
@annevk @webkit-early-warning-system @webkit-commit-queue @cdumez @webkit-ews-buildbot