Generate serialization for WCLayerUpdateInfo. #22830

nishajain61 · 2024-01-16T20:26:54Z

`107335f`

Generate serialization for WCLayerUpdateInfo.
https://bugs.webkit.org/show_bug.cgi?id=267600
rdar://121069952

Reviewed by Chris Dumez.

Generate serialization for WCLayerUpdateInfo.

* Source/WebKit/WebProcess/WebPage/wc/WCUpdateInfo.h:
(WebKit::WCLayerUpdateInfo::encode const): Deleted.
(WebKit::WCLayerUpdateInfo::decode): Deleted.
* Source/WebKit/WebProcess/WebPage/wc/WCUpdateInfo.serialization.in:

Canonical link: https://commits.webkit.org/273862@main

8484ae5

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 wincairo~~
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~		✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	~~🛠 tv-sim~~
	~~🛠 watch~~
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-01-16T20:27:04Z

EWS run on previous version of this PR (hash ec4b7ce)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	⏳ 🧪 ios-wk2-wpt		✅ 🛠 gtk
⏳ 🛠 🧪 jsc	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 gtk-wk2~~
	⏳ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	~~🧪 api-gtk~~
	✅ 🛠 tv-sim
	⏳ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-01-16T20:33:20Z

EWS run on current version of this PR (hash 81a374e)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
⏳ 🧪 style	⏳ 🛠 ios	🛠 mac	🛠 wpe	⏳ 🛠 wincairo
	⏳ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	🧪 wpe-wk2
🧪 webkitperl	⏳ 🧪 ios-wk2	🧪 api-mac	🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	🧪 mac-wk1	🛠 gtk
⏳ 🛠 🧪 jsc	⏳ 🧪 api-ios	🧪 mac-wk2	🧪 gtk-wk2
	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	🧪 api-gtk
🧪 services	⏳ 🛠 tv-sim	🧪 mac-wk2-stress	⏳ 🛠 jsc-armv7
	⏳ 🛠 watch		⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2024-01-16T20:33:21Z

EWS run on previous version of this PR (hash 81a374e)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt		✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

donny-dont

Looks correct assuming Windows build works. Thanks for doing this!

donny-dont · 2024-01-16T20:48:24Z

Source/WebKit/DerivedSources.make

@@ -761,6 +761,7 @@ SERIALIZATION_DESCRIPTION_FILES = \
 	WebProcess/UserContent/InjectUserScriptImmediately.serialization.in \
 	WebProcess/WebCoreSupport/WebSpeechSynthesisVoice.serialization.in \
 	WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemoteProperties.serialization.in \
+	WebProcess/WebPage/wc/WCUpdateInfo.serialization.in \


I don't think you need to add this here since Apple code is not using this.

sheeparegreat

I believe you also need to update Source/WebKit/DerivedSources-input.xcfilelist too?

donny-dont · 2024-01-16T21:49:44Z

Source/WebKit/CMakeLists.txt

@@ -588,6 +588,8 @@ set(WebKit_SERIALIZATION_IN_FILES
    WebProcess/UserContent/InjectUserScriptImmediately.serialization.in

    WebProcess/WebCoreSupport/WebSpeechSynthesisVoice.serialization.in
+
+    WebProcess/WebPage/wc/WCUpdateInfo.serialization.in


Whoops caught this. It should just be in PlatformWin.cmake. It is not used by other ports

Actually just delete this since you're appending to the serialization.in file and its already present in the PlatformWin.cmake file.

donny-dont · 2024-01-16T21:50:27Z

I believe you also need to update Source/WebKit/DerivedSources-input.xcfilelist too?

The WC stuff is only used by Windows at this time so I don't think you need to do this. In fact the CMake changes should be specific to Windows.

Source/WebKit/WebProcess/WebPage/wc/WCUpdateInfo.serialization.in

webkit-early-warning-system · 2024-01-17T21:46:43Z

EWS run on previous version of this PR (hash 9094a4b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~		✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

nishajain61 · 2024-01-17T21:48:24Z

I believe you also need to update Source/WebKit/DerivedSources-input.xcfilelist too?

Fixed

Source/WebKit/WebProcess/WebPage/wc/WCUpdateInfo.serialization.in

nishajain61 · 2024-01-17T23:40:31Z

I believe you also need to update Source/WebKit/DerivedSources-input.xcfilelist too?

Not needed as only for Windows

nishajain61 · 2024-01-17T23:41:52Z

I believe you also need to update Source/WebKit/DerivedSources-input.xcfilelist too?

The WC stuff is only used by Windows at this time so I don't think you need to do this. In fact the CMake changes should be specific to Windows.

Fixed

webkit-early-warning-system · 2024-01-17T23:52:46Z

EWS run on previous version of this PR (hash 4b44863)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt		✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

donny-dont · 2024-01-18T04:24:37Z

Source/WebKit/WebProcess/WebPage/wc/WCUpdateInfo.h

@@ -45,7 +45,7 @@ struct WCTileUpdate {
    WebCore::IntRect dirtyRect;
 };

-enum class WCLayerChange : uint32_t {
+enum class WCLayerChange : uint8_t {
    Children                = 1 <<  0,


Revert this change and mark the serialization files definition as uint32_t

This is why compilation is failing

webkit-early-warning-system · 2024-01-18T17:28:50Z

EWS run on previous version of this PR (hash 8091a28)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt		✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-01-22T18:08:25Z

EWS run on previous version of this PR (hash 2e021af)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	~~🧪 api-wpe~~
	✅ 🧪 ios-wk2-wpt		✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-01-22T22:18:27Z

EWS run on previous version of this PR (hash 0a7ec7d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt		✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

donny-dont · 2024-01-24T17:17:06Z

The definition of WCLayerUpdateInfo needs to be adjusted to make it work with the expectations of the serialization generator so this should be put on pause until that's resolved. Will notify here when that is resolved as @fujii wanted to make an attempt at refactoring.

Thanks for starting this work @nishajain61 !

nishajain61 · 2024-01-30T17:58:31Z

The definition of WCLayerUpdateInfo needs to be adjusted to make it work with the expectations of the serialization generator so this should be put on pause until that's resolved. Will notify here when that is resolved as @fujii wanted to make an attempt at refactoring.

Thanks for starting this work @nishajain61 !

Please let me know what are the next steps needed for this PR to land. Thanks

fujii · 2024-01-30T21:33:34Z

Please let me know what are the next steps needed for this PR to land. Thanks

I'm going to do more refactoring in https://bugs.webkit.org/show_bug.cgi?id=267968 before adopting a serializer generator.
Give me more time. BTW, does it block anything?

cdumez · 2024-01-30T21:36:11Z

Please let me know what are the next steps needed for this PR to land. Thanks

I'm going to do more refactoring in https://bugs.webkit.org/show_bug.cgi?id=267968 before adopting a serializer generator. Give me more time. BTW, does it block anything?

We're on a deadline to get rid of all legacy IPC coders, so yes, it is fairly urgent.

fujii · 2024-01-30T23:46:38Z

We're on a deadline to get rid of all legacy IPC coders, so yes, it is fairly urgent.

I misunderstood your intension. I didn't know why you want to switch WCLayerUpdateInfo to the serializer generator. WCBackingStore is also using the lagacy decoder. I'm going to rewrite them to the modern decoder.

cdumez · 2024-01-30T23:50:44Z

We're on a deadline to get rid of all legacy IPC coders, so yes, it is fairly urgent.

I misunderstood your intension. I didn't know why you want to switch WCLayerUpdateInfo to the serializer generator. WCBackingStore is also using the lagacy decoder. I'm going to rewrite them to the modern decoder.

Yes, WCBackingStore is also on our list of things to be fixed. Thanks for helping.

cdumez

LGTM if the bots are happy.

webkit-early-warning-system · 2024-01-31T19:45:17Z

EWS run on previous version of this PR (hash faf5b01)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt		✅ 🛠 gtk
⏳ 🛠 🧪 jsc	✅ 🧪 api-ios	~~🧪 mac-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	~~🧪 api-gtk~~
	⏳ 🛠 tv-sim
	⏳ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-01-31T21:01:07Z

EWS run on current version of this PR (hash 8484ae5)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
⏳ 🧪 style	⏳ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 wincairo
🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
⏳ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	⏳ 🧪 api-wpe
🧪 webkitpy	⏳ 🧪 ios-wk2-wpt	⏳ 🧪 mac-wk1	⏳ 🛠 gtk
⏳ 🛠 🧪 jsc	⏳ 🧪 api-ios	⏳ 🧪 mac-wk2	⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 api-gtk
🧪 services	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2-stress	⏳ 🛠 jsc-armv7
	⏳ 🛠 watch		⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2024-01-31T21:01:08Z

EWS run on current version of this PR (hash 8484ae5)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 wincairo~~
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~		✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	~~🛠 tv-sim~~
	~~🛠 watch~~
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=267600 rdar://121069952 Reviewed by Chris Dumez. Generate serialization for WCLayerUpdateInfo. * Source/WebKit/WebProcess/WebPage/wc/WCUpdateInfo.h: (WebKit::WCLayerUpdateInfo::encode const): Deleted. (WebKit::WCLayerUpdateInfo::decode): Deleted. * Source/WebKit/WebProcess/WebPage/wc/WCUpdateInfo.serialization.in: Canonical link: https://commits.webkit.org/273862@main

webkit-commit-queue · 2024-01-31T22:44:58Z

Committed 273862@main (107335f): https://commits.webkit.org/273862@main

Reviewed commits have been landed. Closing PR #22830 and removing active labels.

nishajain61 requested a review from cdumez as a code owner January 16, 2024 20:26

nishajain61 self-assigned this Jan 16, 2024

nishajain61 added the WebKit API For issues and bugs in the Web Kit public embedding APIs label Jan 16, 2024

nishajain61 force-pushed the eng/Generate-serialization-for-WCLayerUpdateInfo- branch from ec4b7ce to 81a374e Compare January 16, 2024 20:33

donny-dont approved these changes Jan 16, 2024

View reviewed changes

sheeparegreat requested changes Jan 16, 2024

View reviewed changes

donny-dont requested changes Jan 16, 2024

View reviewed changes

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 16, 2024

sheeparegreat reviewed Jan 16, 2024

View reviewed changes

Source/WebKit/WebProcess/WebPage/wc/WCUpdateInfo.serialization.in Outdated Show resolved Hide resolved

nishajain61 removed the merging-blocked Applied to prevent a change from being merged label Jan 17, 2024

nishajain61 force-pushed the eng/Generate-serialization-for-WCLayerUpdateInfo- branch from 81a374e to 9094a4b Compare January 17, 2024 21:46

sheeparegreat requested changes Jan 17, 2024

View reviewed changes

Source/WebKit/WebProcess/WebPage/wc/WCUpdateInfo.serialization.in Show resolved Hide resolved

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 17, 2024

nishajain61 removed the merging-blocked Applied to prevent a change from being merged label Jan 17, 2024

nishajain61 force-pushed the eng/Generate-serialization-for-WCLayerUpdateInfo- branch from 9094a4b to 4b44863 Compare January 17, 2024 23:40

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 18, 2024

donny-dont reviewed Jan 18, 2024

View reviewed changes

nishajain61 removed the merging-blocked Applied to prevent a change from being merged label Jan 18, 2024

nishajain61 force-pushed the eng/Generate-serialization-for-WCLayerUpdateInfo- branch from 4b44863 to 8091a28 Compare January 18, 2024 17:28

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 18, 2024

nishajain61 removed the merging-blocked Applied to prevent a change from being merged label Jan 22, 2024

nishajain61 force-pushed the eng/Generate-serialization-for-WCLayerUpdateInfo- branch from 8091a28 to 2e021af Compare January 22, 2024 18:07

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 22, 2024

nishajain61 removed the merging-blocked Applied to prevent a change from being merged label Jan 22, 2024

nishajain61 force-pushed the eng/Generate-serialization-for-WCLayerUpdateInfo- branch from 2e021af to 0a7ec7d Compare January 22, 2024 22:15

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 23, 2024

donny-dont mentioned this pull request Jan 24, 2024

Refactor WCLayerUpdateInfo for serialization #23136

Merged

donny-dont mentioned this pull request Jan 31, 2024

Rewrite legacy IPC decoders of WCBackingStore and WCLayerUpdateInfo to modern #23561

Closed

donny-dont removed the merging-blocked Applied to prevent a change from being merged label Jan 31, 2024

donny-dont force-pushed the eng/Generate-serialization-for-WCLayerUpdateInfo- branch from 0a7ec7d to faf5b01 Compare January 31, 2024 18:47

donny-dont self-assigned this Jan 31, 2024

cdumez approved these changes Jan 31, 2024

View reviewed changes

donny-dont force-pushed the eng/Generate-serialization-for-WCLayerUpdateInfo- branch from faf5b01 to 8484ae5 Compare January 31, 2024 21:00

donny-dont added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 31, 2024

webkit-commit-queue force-pushed the eng/Generate-serialization-for-WCLayerUpdateInfo- branch from 8484ae5 to 107335f Compare January 31, 2024 22:44

webkit-commit-queue merged commit 107335f into WebKit:main Jan 31, 2024

webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate serialization for WCLayerUpdateInfo. #22830

Generate serialization for WCLayerUpdateInfo. #22830

nishajain61 commented Jan 16, 2024 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Jan 16, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 16, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 16, 2024 •

edited

Loading

donny-dont left a comment

donny-dont Jan 16, 2024

sheeparegreat left a comment

donny-dont Jan 16, 2024

donny-dont Jan 16, 2024 •

edited

Loading

donny-dont commented Jan 16, 2024

webkit-early-warning-system commented Jan 17, 2024 •

edited

Loading

nishajain61 commented Jan 17, 2024

nishajain61 commented Jan 17, 2024

nishajain61 commented Jan 17, 2024

webkit-early-warning-system commented Jan 17, 2024 •

edited

Loading

donny-dont Jan 18, 2024

webkit-early-warning-system commented Jan 18, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 22, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 22, 2024 •

edited

Loading

donny-dont commented Jan 24, 2024

nishajain61 commented Jan 30, 2024

fujii commented Jan 30, 2024

cdumez commented Jan 30, 2024

fujii commented Jan 30, 2024

cdumez commented Jan 30, 2024

cdumez left a comment

webkit-early-warning-system commented Jan 31, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 31, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 31, 2024 •

edited

Loading

webkit-commit-queue commented Jan 31, 2024

Generate serialization for WCLayerUpdateInfo. #22830

Generate serialization for WCLayerUpdateInfo. #22830

Conversation

nishajain61 commented Jan 16, 2024 • edited by webkit-early-warning-system Loading

107335f

webkit-early-warning-system commented Jan 16, 2024 • edited Loading

webkit-early-warning-system commented Jan 16, 2024 • edited Loading

webkit-early-warning-system commented Jan 16, 2024 • edited Loading

donny-dont left a comment

Choose a reason for hiding this comment

donny-dont Jan 16, 2024

Choose a reason for hiding this comment

sheeparegreat left a comment

Choose a reason for hiding this comment

donny-dont Jan 16, 2024

Choose a reason for hiding this comment

donny-dont Jan 16, 2024 • edited Loading

Choose a reason for hiding this comment

donny-dont commented Jan 16, 2024

webkit-early-warning-system commented Jan 17, 2024 • edited Loading

nishajain61 commented Jan 17, 2024

nishajain61 commented Jan 17, 2024

nishajain61 commented Jan 17, 2024

webkit-early-warning-system commented Jan 17, 2024 • edited Loading

donny-dont Jan 18, 2024

Choose a reason for hiding this comment

webkit-early-warning-system commented Jan 18, 2024 • edited Loading

webkit-early-warning-system commented Jan 22, 2024 • edited Loading

webkit-early-warning-system commented Jan 22, 2024 • edited Loading

donny-dont commented Jan 24, 2024

nishajain61 commented Jan 30, 2024

fujii commented Jan 30, 2024

cdumez commented Jan 30, 2024

fujii commented Jan 30, 2024

cdumez commented Jan 30, 2024

cdumez left a comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Jan 31, 2024 • edited Loading

webkit-early-warning-system commented Jan 31, 2024 • edited Loading

webkit-early-warning-system commented Jan 31, 2024 • edited Loading

webkit-commit-queue commented Jan 31, 2024

nishajain61 commented Jan 16, 2024 •

edited by webkit-early-warning-system

Loading

`107335f`

webkit-early-warning-system commented Jan 16, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 16, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 16, 2024 •

edited

Loading

donny-dont Jan 16, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 17, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 17, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 18, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 22, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 22, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 31, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 31, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 31, 2024 •

edited

Loading