Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebGPU] Crash in Device::createShaderModule running shader,validation,* tests #22898

Merged
merged 1 commit into from
Jan 19, 2024
Merged

[WebGPU] Crash in Device::createShaderModule running shader,validation,* tests #22898

merged 1 commit into from
Jan 19, 2024

Conversation

mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented Jan 18, 2024 •
edited by webkit-early-warning-system
Loading

10afd1e

[WebGPU] Crash in Device::createShaderModule running shader,validation,* tests
https://bugs.webkit.org/show_bug.cgi?id=267677
<radar://121171008>

Reviewed by Tadeu Zagallo.

Until https://bugs.webkit.org/show_bug.cgi?id=266774 is completed,
we have a range check that may return NSNotFound and not checking that
led to a crash in -[NSString substringWithRange:]

* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::Device::createShaderModule):

Canonical link: https://commits.webkit.org/273229@main

f6b4379

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski self-assigned this Jan 18, 2024
@mwyrzykowski mwyrzykowski added the WebGPU For bugs in WebGPU label Jan 18, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 18, 2024 •
edited
Loading

EWS run on current version of this PR (hash f6b4379)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 18, 2024
@mwyrzykowski mwyrzykowski removed the merging-blocked Applied to prevent a change from being merged label Jan 18, 2024
@mwyrzykowski mwyrzykowski requested a review from djg January 18, 2024 18:02
@mwyrzykowski mwyrzykowski added the merge-queue Applied to send a pull request to merge-queue label Jan 19, 2024
@webkit-commit-queue
Copy link
Collaborator

This change contains multiple commits which are not squashed together, blocking PR #22898. Please squash the commits to land.

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Jan 19, 2024
@mwyrzykowski mwyrzykowski added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jan 19, 2024
@webkit-commit-queue
Copy link
Collaborator

This change contains multiple commits which are not squashed together, blocking PR #22898. Please squash the commits to land.

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Jan 19, 2024
@mwyrzykowski mwyrzykowski added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jan 19, 2024
@mwyrzykowski
[WebGPU] Crash in Device::createShaderModule running shader,validatio…
10afd1e 
…n,* tests

https://bugs.webkit.org/show_bug.cgi?id=267677
<radar://121171008>

Reviewed by Tadeu Zagallo.

Until https://bugs.webkit.org/show_bug.cgi?id=266774 is completed,
we have a range check that may return NSNotFound and not checking that
led to a crash in -[NSString substringWithRange:]

* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::Device::createShaderModule):

Canonical link: https://commits.webkit.org/273229@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-Crash-in-DevicecreateShaderModule-running-shadervalidation-tests branch from f6b4379 to 10afd1e Compare January 19, 2024 19:07
@webkit-commit-queue
Copy link
Collaborator

Committed 273229@main (10afd1e): https://commits.webkit.org/273229@main

Reviewed commits have been landed. Closing PR #22898 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 10afd1e into WebKit:main Jan 19, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeuzagallo tadeuzagallo tadeuzagallo approved these changes

@djg djg Awaiting requested review from djg

Assignees

@mwyrzykowski mwyrzykowski

Labels
WebGPU For bugs in WebGPU
Projects
None yet
Milestone
No milestone
5 participants
@mwyrzykowski @webkit-early-warning-system @webkit-commit-queue @tadeuzagallo @webkit-ews-buildbot