Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer::stop can short-circuit in most cases #22955

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented Jan 19, 2024

@rniwa rniwa self-assigned this Jan 19, 2024
@rniwa rniwa added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Jan 19, 2024
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 19, 2024
@rniwa rniwa removed the merging-blocked Applied to prevent a change from being merged label Jan 19, 2024
@rniwa
Copy link
Member Author

rniwa commented Jan 19, 2024

fast/events/ios/select-all-with-existing-selection.html seems to be a flaky test.

@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 19, 2024
https://bugs.webkit.org/show_bug.cgi?id=267746

Reviewed by Yusuke Suzuki and Darin Adler.

Add a fast path for when the timer isn't scheduled.

* Source/WebCore/platform/Timer.cpp:
(WebCore::TimerBase::stopSlowCase):
(WebCore::TimerBase::stop): Deleted.
* Source/WebCore/platform/Timer.h:
(WebCore::TimerBase::stop):

Canonical link: https://commits.webkit.org/273212@main
@webkit-commit-queue
Copy link
Collaborator

Committed 273212@main (741a55f): https://commits.webkit.org/273212@main

Reviewed commits have been landed. Closing PR #22955 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 741a55f into WebKit:main Jan 19, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 19, 2024
@rniwa rniwa deleted the fix267746 branch May 21, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
6 participants