-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timer::stop can short-circuit in most cases #22955
Conversation
EWS run on current version of this PR (hash ac82580) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me
fast/events/ios/select-all-with-existing-selection.html seems to be a flaky test. |
https://bugs.webkit.org/show_bug.cgi?id=267746 Reviewed by Yusuke Suzuki and Darin Adler. Add a fast path for when the timer isn't scheduled. * Source/WebCore/platform/Timer.cpp: (WebCore::TimerBase::stopSlowCase): (WebCore::TimerBase::stop): Deleted. * Source/WebCore/platform/Timer.h: (WebCore::TimerBase::stop): Canonical link: https://commits.webkit.org/273212@main
ac82580
to
741a55f
Compare
Committed 273212@main (741a55f): https://commits.webkit.org/273212@main Reviewed commits have been landed. Closing PR #22955 and removing active labels. |
741a55f
ac82580
π§ͺ wpe-wk2π§ͺ ios-wk2-wpt