Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLib] Write bwrapinfo.json to disk for xdg-desktop-portal #23052

Merged
merged 1 commit into from Jan 23, 2024
Merged

[GLib] Write bwrapinfo.json to disk for xdg-desktop-portal #23052

merged 1 commit into from Jan 23, 2024

Conversation

TingPing
Copy link
Contributor

@TingPing TingPing commented Jan 22, 2024 •
edited by webkit-early-warning-system

b9361c7

[GLib] Write bwrapinfo.json to disk for xdg-desktop-portal
https://bugs.webkit.org/show_bug.cgi?id=238403

Reviewed by Michael Catanzaro.

The Realtime portal in xdg-desktop-portal reads bwrapinfo.json
to get the child pid.

* Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::createBwrapInfo):
(WebKit::createFlatpakInfo):
(WebKit::bubblewrapSpawn):

Canonical link: https://commits.webkit.org/273334@main

e8ea6c2

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@TingPing TingPing requested a review from a team as a code owner January 22, 2024 18:23
@TingPing TingPing self-assigned this Jan 22, 2024
@TingPing TingPing added the WebKitGTK Bugs related to the Gtk API layer. label Jan 22, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash e8ea6c2)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mcatanzaro mcatanzaro mentioned this pull request Jan 22, 2024
Closed
@TingPing TingPing added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jan 22, 2024
@TingPing TingPing mentioned this pull request Jan 22, 2024
Closed
@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Jan 23, 2024
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #9987.

@TingPing
[GLib] Write bwrapinfo.json to disk for xdg-desktop-portal
b9361c7 
https://bugs.webkit.org/show_bug.cgi?id=238403

Reviewed by Michael Catanzaro.

The Realtime portal in xdg-desktop-portal reads bwrapinfo.json
to get the child pid.

* Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::createBwrapInfo):
(WebKit::createFlatpakInfo):
(WebKit::bubblewrapSpawn):

Canonical link: https://commits.webkit.org/273334@main
@webkit-commit-queue
Copy link
Collaborator

Committed 273334@main (b9361c7): https://commits.webkit.org/273334@main

Reviewed commits have been landed. Closing PR #23052 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b9361c7 into WebKit:main Jan 23, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcatanzaro mcatanzaro mcatanzaro approved these changes

Assignees

@TingPing TingPing

Labels
WebKitGTK Bugs related to the Gtk API layer.
Projects
None yet
Milestone
No milestone
5 participants
@TingPing @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @mcatanzaro