New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync bidirectional text
UA Stylesheet rules from HTML Web Specification
#23084
Draft
Ahmad-S792
wants to merge
1
commit into
WebKit:main
Choose a base branch
from
Ahmad-S792:fix65617-unicode-isolate-ua-stylesheet-rule
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Sync bidirectional text
UA Stylesheet rules from HTML Web Specification
#23084
Ahmad-S792
wants to merge
1
commit into
WebKit:main
from
Ahmad-S792:fix65617-unicode-isolate-ua-stylesheet-rule
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Jan 23, 2024
Ahmad-S792
force-pushed
the
fix65617-unicode-isolate-ua-stylesheet-rule
branch
from
January 23, 2024 11:49
fe2bb9e
to
fd4db4d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Ahmad-S792
force-pushed
the
fix65617-unicode-isolate-ua-stylesheet-rule
branch
from
January 25, 2024 12:29
fd4db4d
to
9f37553
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Ahmad-S792
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Jan 25, 2024
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Jan 25, 2024
Ahmad-S792
force-pushed
the
fix65617-unicode-isolate-ua-stylesheet-rule
branch
from
February 5, 2024 01:33
9f37553
to
3e294e3
Compare
EWS run on previous version of this PR (hash 3e294e3) |
Ahmad-S792
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Feb 5, 2024
Ahmad-S792
force-pushed
the
fix65617-unicode-isolate-ua-stylesheet-rule
branch
from
February 25, 2024 03:42
3e294e3
to
ee122d6
Compare
EWS run on previous version of this PR (hash ee122d6) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Feb 25, 2024
Ahmad-S792
force-pushed
the
fix65617-unicode-isolate-ua-stylesheet-rule
branch
from
February 25, 2024 10:50
ee122d6
to
efe188c
Compare
EWS run on previous version of this PR (hash efe188c) |
Ahmad-S792
force-pushed
the
fix65617-unicode-isolate-ua-stylesheet-rule
branch
from
February 25, 2024 12:22
efe188c
to
5aa1acb
Compare
EWS run on previous version of this PR (hash 5aa1acb) |
Ahmad-S792
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Feb 25, 2024
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Feb 25, 2024
Ahmad-S792
force-pushed
the
fix65617-unicode-isolate-ua-stylesheet-rule
branch
from
March 1, 2024 19:20
5aa1acb
to
04e6246
Compare
EWS run on previous version of this PR (hash 04e6246) |
Ahmad-S792
force-pushed
the
fix65617-unicode-isolate-ua-stylesheet-rule
branch
from
March 2, 2024 17:44
45a2156
to
ec03929
Compare
β¦tion https://bugs.webkit.org/show_bug.cgi?id=65617 rdar://problem/96912726 Reviewed by NOBODY (OOPS!). This patch is to align WebKit with Web-Specification [1]: [1] https://html.spec.whatwg.org/multipage/rendering.html#bidi-rendering It syncs all bidirectional text user agent stylesheet rules to ensure that all HTML elements have respect direction based as per standard. Currently, we cannot add all UA rules, so add appropriate FIXME with bug references or function names. Credits to Noam Rosenthal for reference initial test changes. * Source/WebCore/css/html.css: From Web-Spec except few targeted changes (summary): Add FIXME (hr): Remove 'unicode-bidi' to add in single place (bdo): Update to have `isolate-override` (ruby): Add as per 'ruby' spec * Source/WebCore/html/HTMLElement.cpp: (unicodeBidiAttributeForDirAuto): Deleted (HTMLElement::collectPresentationalHintsForAttribute): Deleted reference and use 'html.css' as single source of truth * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm: (ModifyTextWritingDirection): Update Test > Test & Test Expectations Update: * LayoutTests/platform/wpe/fast/text/word-break-expected.txt: * LayoutTests/platform/mac/fast/text/word-break-expected.txt:
Ahmad-S792
force-pushed
the
fix65617-unicode-isolate-ua-stylesheet-rule
branch
from
March 3, 2024 00:15
ec03929
to
78ad3f9
Compare
EWS run on current version of this PR (hash 78ad3f9) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CSS
Cascading Style Sheets implementation
merging-blocked
Applied to prevent a change from being merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
78ad3f9