[CSS] Unprefix text-decoration shorthand #23121

mdubet · 2024-01-23T21:31:03Z

`2cd03bd`

[CSS] Unprefix text-decoration shorthand
https://bugs.webkit.org/show_bug.cgi?id=230083
rdar://83182835

 Reviewed by NOBODY (OOPS!).

 Explanation of why this fixes the bug (OOPS!).

* LayoutTests/TestExpectations:
* LayoutTests/fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt:
* LayoutTests/fast/css/getComputedStyle/getComputedStyle-text-decoration.html:
* LayoutTests/fast/css/style-enumerate-properties-expected.txt:
* LayoutTests/fast/css/style-enumerate-properties.html:
* LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-shorthand-expected.txt:
* LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-shorthand.html:
* LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-dashed.html:
* LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-dotted-dashed.html:
* LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-dotted.html:
* LayoutTests/fast/events/input-events-paste-rich-datatransfer-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-letter-allowed-properties-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-allowed-properties-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/parsing/text-decoration-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/parsing/text-decoration-shorthand-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/parsing/text-decoration-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-serialization.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/editing/run/inserttext_2001-last-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/editing/run/multitest_4001-5000-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/editing/run/multitest_8001-9000-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/editing/run/multitest_9001-last-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/editing/run/strikethrough_2001-last-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/editing/run/underline_2001-last-expected.txt:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle const):
(WebCore::ComputedStyleExtractor::textDecorationShorthandValue const):
* Source/WebCore/css/ComputedStyleExtractor.h:
* Source/WebCore/css/MutableStyleProperties.cpp:
(WebCore::MutableStyleProperties::setProperty):
* Source/WebCore/css/MutableStyleProperties.h:
* Source/WebCore/css/ShorthandSerializer.cpp:
(WebCore::ShorthandSerializer::serialize):
* Source/WebCore/css/StyleProperties.cpp:
(WebCore::canUseShorthandForLonghand):
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseShorthand):
* Source/WebCore/editing/EditingStyle.cpp:
(WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent):
(WebCore::EditingStyle::init):
(WebCore::EditingStyle::styleWithResolvedTextDecorations const):
(WebCore::EditingStyle::collapseTextDecorationProperties):
(WebCore::EditingStyle::conflictsWithInlineStyleOfElement const):
(WebCore::EditingStyle::mergeStyle):
(WebCore::EditingStyle::removeEquivalentProperties):
(WebCore::reconcileTextDecorationProperties):
(WebCore::StyleChange::StyleChange):
(WebCore::setTextDecorationProperty):
(WebCore::StyleChange::extractTextStyles):
(WebCore::diffTextDecorations):
* Source/WebCore/editing/markup.cpp:
(WebCore::serializePreservingVisualAppearanceInternal):

2cd03bd

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-01-23T21:31:12Z

EWS run on previous version of this PR (hash 040ff91)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 wincairo
❌ 🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
❌ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	⏳ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	⏳ 🧪 mac-wk1	⏳ 🛠 gtk
⏳ 🛠 🧪 jsc	⏳ 🧪 api-ios	⏳ 🧪 mac-wk2	⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 api-gtk
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2-stress
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2024-01-23T22:02:07Z

EWS run on previous version of this PR (hash 016917f)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

Loirooriol

I haven't looked in detail, but this seems similar to 5425a41, which was reverted in https://bugs.webkit.org/show_bug.cgi?id=237412 for perf reasons.

Are you addressing that in a particular way, or just hoping that it will work this time?

Source/WebCore/editing/markup.cpp

Source/WebCore/editing/EditingStyle.cpp

mdubet · 2024-01-23T22:44:29Z

It's a draft, it's not ready for review yet.

For the perf issue, hopefully the early return should mitigate this (here https://github.com/WebKit/WebKit/pull/23121/files#diff-95930edb6b781ea4a9c186c448fbcf9a40b69ff535c822c96c284a67fb81a89aR1524 )

webkit-early-warning-system · 2024-01-24T22:44:02Z

EWS run on previous version of this PR (hash c3033e9)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-01-24T22:44:03Z

EWS run on previous version of this PR (hash 5c32c1b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
⏳ 🧪 style	~~🛠 ios~~	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 wincairo
⏳ 🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
⏳ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	⏳ 🧪 api-wpe
⏳ 🧪 webkitpy	⏳ 🧪 ios-wk2-wpt	⏳ 🧪 mac-wk1	⏳ 🛠 gtk
⏳ 🛠 🧪 jsc	⏳ 🧪 api-ios	⏳ 🧪 mac-wk2	⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 api-gtk
⏳ 🧪 services	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2-stress
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

Source/WebCore/editing/EditingStyle.cpp

webkit-early-warning-system · 2024-01-26T01:03:44Z

Starting EWS tests for 3b84c58. Live statuses available at the PR page, #23121

webkit-early-warning-system · 2024-01-26T01:03:44Z

EWS run on previous version of this PR (hash 3b84c58)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-01-26T21:40:40Z

EWS run on previous version of this PR (hash 024cfc1)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	💥 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	~~🧪 mac-wk2~~	❌ 🧪 gtk-wk2
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-01-30T00:36:28Z

EWS run on previous version of this PR (hash 8d36b35)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	⏳ 🛠 wpe-skia
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-03-13T16:51:59Z

EWS run on previous version of this PR (hash 7bb6f2e)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	~~🛠 wincairo~~
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🛠 wpe-skia
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🛠 gtk
	~~🛠 tv~~	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	~~🛠 tv-sim~~	❌ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-03-13T18:40:36Z

EWS run on previous version of this PR (hash 697eacd)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-03-14T01:48:19Z

EWS run on previous version of this PR (hash 3093d70)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-03-14T22:43:13Z

EWS run on previous version of this PR (hash 687d9a2)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	~~🛠 ios-sim~~	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-skia
	❌ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-03-15T18:33:58Z

EWS run on previous version of this PR (hash f2d3912)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-03-25T18:32:19Z

EWS run on previous version of this PR (hash edf61d5)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=230083 rdar://83182835 Reviewed by NOBODY (OOPS!). Explanation of why this fixes the bug (OOPS!). * LayoutTests/TestExpectations: * LayoutTests/fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt: * LayoutTests/fast/css/getComputedStyle/getComputedStyle-text-decoration.html: * LayoutTests/fast/css/style-enumerate-properties-expected.txt: * LayoutTests/fast/css/style-enumerate-properties.html: * LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-shorthand-expected.txt: * LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-shorthand.html: * LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-dashed.html: * LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-dotted-dashed.html: * LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-dotted.html: * LayoutTests/fast/events/input-events-paste-rich-datatransfer-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-letter-allowed-properties-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-allowed-properties-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/parsing/text-decoration-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/parsing/text-decoration-shorthand-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/parsing/text-decoration-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-serialization.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/run/inserttext_2001-last-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/run/multitest_4001-5000-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/run/multitest_8001-9000-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/run/multitest_9001-last-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/run/strikethrough_2001-last-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/run/underline_2001-last-expected.txt: * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle const): (WebCore::ComputedStyleExtractor::textDecorationShorthandValue const): * Source/WebCore/css/ComputedStyleExtractor.h: * Source/WebCore/css/MutableStyleProperties.cpp: (WebCore::MutableStyleProperties::setProperty): * Source/WebCore/css/MutableStyleProperties.h: * Source/WebCore/css/ShorthandSerializer.cpp: (WebCore::ShorthandSerializer::serialize): * Source/WebCore/css/StyleProperties.cpp: (WebCore::canUseShorthandForLonghand): * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::parseShorthand): * Source/WebCore/editing/EditingStyle.cpp: (WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent): (WebCore::EditingStyle::init): (WebCore::EditingStyle::styleWithResolvedTextDecorations const): (WebCore::EditingStyle::collapseTextDecorationProperties): (WebCore::EditingStyle::conflictsWithInlineStyleOfElement const): (WebCore::EditingStyle::mergeStyle): (WebCore::EditingStyle::removeEquivalentProperties): (WebCore::reconcileTextDecorationProperties): (WebCore::StyleChange::StyleChange): (WebCore::setTextDecorationProperty): (WebCore::StyleChange::extractTextStyles): (WebCore::diffTextDecorations): * Source/WebCore/editing/markup.cpp: (WebCore::serializePreservingVisualAppearanceInternal):

webkit-early-warning-system · 2024-03-26T17:33:26Z

EWS run on current version of this PR (hash 2cd03bd)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

mdubet self-assigned this Jan 23, 2024

mdubet added the CSS Cascading Style Sheets implementation label Jan 23, 2024

mdubet force-pushed the unprefix-text-decoration-single-commit branch from 040ff91 to 016917f Compare January 23, 2024 21:57

Loirooriol reviewed Jan 23, 2024

View reviewed changes

Source/WebCore/editing/markup.cpp Outdated Show resolved Hide resolved

Source/WebCore/editing/EditingStyle.cpp Outdated Show resolved Hide resolved

Source/WebCore/editing/EditingStyle.cpp Outdated Show resolved Hide resolved

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 24, 2024

mdubet removed the merging-blocked Applied to prevent a change from being merged label Jan 24, 2024

mdubet force-pushed the unprefix-text-decoration-single-commit branch 2 times, most recently from 5c32c1b to c3033e9 Compare January 24, 2024 22:39

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 25, 2024

rniwa reviewed Jan 26, 2024

View reviewed changes

Source/WebCore/editing/EditingStyle.cpp Outdated Show resolved Hide resolved

rniwa reviewed Jan 26, 2024

View reviewed changes

Source/WebCore/editing/EditingStyle.cpp Outdated Show resolved Hide resolved

rniwa reviewed Jan 26, 2024

View reviewed changes

Source/WebCore/editing/EditingStyle.cpp Outdated Show resolved Hide resolved

mdubet removed the merging-blocked Applied to prevent a change from being merged label Jan 26, 2024

mdubet force-pushed the unprefix-text-decoration-single-commit branch from c3033e9 to 3b84c58 Compare January 26, 2024 01:03

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 26, 2024

mdubet removed the merging-blocked Applied to prevent a change from being merged label Jan 26, 2024

mdubet force-pushed the unprefix-text-decoration-single-commit branch from 3b84c58 to 024cfc1 Compare January 26, 2024 20:14

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 26, 2024

mdubet removed the merging-blocked Applied to prevent a change from being merged label Jan 30, 2024

mdubet force-pushed the unprefix-text-decoration-single-commit branch from 024cfc1 to 8d36b35 Compare January 30, 2024 00:22

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 30, 2024

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 13, 2024

mdubet force-pushed the unprefix-text-decoration-single-commit branch from 6fbd584 to 06afee1 Compare March 13, 2024 01:49

mdubet removed the merging-blocked Applied to prevent a change from being merged label Mar 13, 2024

mdubet force-pushed the unprefix-text-decoration-single-commit branch from 06afee1 to 7bb6f2e Compare March 13, 2024 16:51

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 13, 2024

mdubet removed the merging-blocked Applied to prevent a change from being merged label Mar 13, 2024

mdubet force-pushed the unprefix-text-decoration-single-commit branch from 7bb6f2e to 697eacd Compare March 13, 2024 18:38

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 13, 2024

mdubet removed the merging-blocked Applied to prevent a change from being merged label Mar 14, 2024

mdubet force-pushed the unprefix-text-decoration-single-commit branch from 697eacd to 3093d70 Compare March 14, 2024 01:48

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 14, 2024

mdubet removed the merging-blocked Applied to prevent a change from being merged label Mar 14, 2024

mdubet force-pushed the unprefix-text-decoration-single-commit branch from 3093d70 to 687d9a2 Compare March 14, 2024 22:41

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 15, 2024

mdubet removed the merging-blocked Applied to prevent a change from being merged label Mar 15, 2024

mdubet force-pushed the unprefix-text-decoration-single-commit branch from 687d9a2 to f2d3912 Compare March 15, 2024 18:33

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 15, 2024

mdubet removed the merging-blocked Applied to prevent a change from being merged label Mar 25, 2024

mdubet force-pushed the unprefix-text-decoration-single-commit branch from f2d3912 to edf61d5 Compare March 25, 2024 18:32

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 25, 2024

mdubet removed the merging-blocked Applied to prevent a change from being merged label Mar 26, 2024

mdubet force-pushed the unprefix-text-decoration-single-commit branch from edf61d5 to 2cd03bd Compare March 26, 2024 17:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CSS] Unprefix text-decoration shorthand #23121

[CSS] Unprefix text-decoration shorthand #23121

mdubet commented Jan 23, 2024 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Jan 23, 2024 •

edited

webkit-early-warning-system commented Jan 23, 2024 •

edited

Loirooriol left a comment

mdubet commented Jan 23, 2024

webkit-early-warning-system commented Jan 24, 2024 •

edited

webkit-early-warning-system commented Jan 24, 2024

webkit-early-warning-system commented Jan 26, 2024

webkit-early-warning-system commented Jan 26, 2024 •

edited

webkit-early-warning-system commented Jan 26, 2024 •

edited

webkit-early-warning-system commented Jan 30, 2024 •

edited

webkit-early-warning-system commented Mar 13, 2024 •

edited

webkit-early-warning-system commented Mar 13, 2024 •

edited

webkit-early-warning-system commented Mar 14, 2024 •

edited

webkit-early-warning-system commented Mar 14, 2024 •

edited

webkit-early-warning-system commented Mar 15, 2024 •

edited

webkit-early-warning-system commented Mar 25, 2024 •

edited

webkit-early-warning-system commented Mar 26, 2024 •

edited

[CSS] Unprefix text-decoration shorthand #23121

Are you sure you want to change the base?

[CSS] Unprefix text-decoration shorthand #23121

Conversation

mdubet commented Jan 23, 2024 • edited by webkit-early-warning-system

2cd03bd

webkit-early-warning-system commented Jan 23, 2024 • edited

webkit-early-warning-system commented Jan 23, 2024 • edited

Loirooriol left a comment

Choose a reason for hiding this comment

mdubet commented Jan 23, 2024

webkit-early-warning-system commented Jan 24, 2024 • edited

webkit-early-warning-system commented Jan 24, 2024

webkit-early-warning-system commented Jan 26, 2024

webkit-early-warning-system commented Jan 26, 2024 • edited

webkit-early-warning-system commented Jan 26, 2024 • edited

webkit-early-warning-system commented Jan 30, 2024 • edited

webkit-early-warning-system commented Mar 13, 2024 • edited

webkit-early-warning-system commented Mar 13, 2024 • edited

webkit-early-warning-system commented Mar 14, 2024 • edited

webkit-early-warning-system commented Mar 14, 2024 • edited

webkit-early-warning-system commented Mar 15, 2024 • edited

webkit-early-warning-system commented Mar 25, 2024 • edited

webkit-early-warning-system commented Mar 26, 2024 • edited

mdubet commented Jan 23, 2024 •

edited by webkit-early-warning-system

`2cd03bd`

webkit-early-warning-system commented Jan 23, 2024 •

edited

webkit-early-warning-system commented Jan 23, 2024 •

edited

webkit-early-warning-system commented Jan 24, 2024 •

edited

webkit-early-warning-system commented Jan 26, 2024 •

edited

webkit-early-warning-system commented Jan 26, 2024 •

edited

webkit-early-warning-system commented Jan 30, 2024 •

edited

webkit-early-warning-system commented Mar 13, 2024 •

edited

webkit-early-warning-system commented Mar 13, 2024 •

edited

webkit-early-warning-system commented Mar 14, 2024 •

edited

webkit-early-warning-system commented Mar 14, 2024 •

edited

webkit-early-warning-system commented Mar 15, 2024 •

edited

webkit-early-warning-system commented Mar 25, 2024 •

edited

webkit-early-warning-system commented Mar 26, 2024 •

edited