Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGRESSION (272891@main): [ Sonoma wk1 ] css3/filters/effect-grayscale.html is a consistent image failure #23179

Merged
merged 1 commit into from
Jan 25, 2024
Merged

REGRESSION (272891@main): [ Sonoma wk1 ] css3/filters/effect-grayscale.html is a consistent image failure #23179

merged 1 commit into from
Jan 25, 2024

Conversation

karlrackler
Copy link
Contributor

@karlrackler karlrackler commented Jan 24, 2024 •
edited by webkit-early-warning-system
Loading

eb9ae09

REGRESSION (272891@main): [ Sonoma wk1 ] css3/filters/effect-grayscale.html is a consistent image failure
https://bugs.webkit.org/show_bug.cgi?id=267888
rdar://121399721

Reviewed by Said Abou-Hallawa.

Adjust pixel tolerance.
Remove test expectation.

* LayoutTests/css3/filters/effect-grayscale.html:
* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/273454@main

09cdfbe

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@karlrackler karlrackler self-assigned this Jan 24, 2024
@karlrackler karlrackler added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jan 24, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 24, 2024 •
edited
Loading

EWS run on current version of this PR (hash 09cdfbe)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@karlrackler karlrackler added the merge-queue Applied to send a pull request to merge-queue label Jan 24, 2024
@webkit-commit-queue webkit-commit-queue force-pushed the eng/REGRESSION-272891main--Sonoma-wk1--css3filterseffect-grayscale-html-is-a-consistent-image-failure branch from 09cdfbe to a1b2b97 Compare January 25, 2024 00:07
@karlrackler
REGRESSION (272891@main): [ Sonoma wk1 ] css3/filters/effect-grayscal…
eb9ae09 
…e.html is a consistent image failure

https://bugs.webkit.org/show_bug.cgi?id=267888
rdar://121399721

Reviewed by Said Abou-Hallawa.

Adjust pixel tolerance.
Remove test expectation.

* LayoutTests/css3/filters/effect-grayscale.html:
* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/273454@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/REGRESSION-272891main--Sonoma-wk1--css3filterseffect-grayscale-html-is-a-consistent-image-failure branch from a1b2b97 to eb9ae09 Compare January 25, 2024 00:10
@webkit-commit-queue
Copy link
Collaborator

Committed 273454@main (eb9ae09): https://commits.webkit.org/273454@main

Reviewed commits have been landed. Closing PR #23179 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit eb9ae09 into WebKit:main Jan 25, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shallawa shallawa shallawa approved these changes

Assignees

@karlrackler karlrackler

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
4 participants
@karlrackler @webkit-early-warning-system @webkit-commit-queue @shallawa