[WebXR] Enable implicit clear for WebXROpaqueFramebuffer #23209
Conversation
|
EWS run on previous version of this PR (hash 6e0f313)
|
There was a problem hiding this comment.
I don't think it's correct.
WebXR framebuffer must be cleared before session rAF, regardless of whether the client draws anything or not.
I think your initial problem to solve is "WebXR does not clear the session framebuffer before rAF".
The solution should be "clear the session framebuffer before rAF".
I think we could focus on optimizing clears if they are problems.
The WebGL clear optimizaiton was a more pressing matter when the preserveDrawingBuffer was default and/or supported. WebXR doesn't have these issues.
| class WebGLRenderingContextBase; | ||
|
|
||
| // Interface to state related to a set of framebuffer attachments. | ||
| class WebGLFramebufferBase { |
There was a problem hiding this comment.
These are only correctly maintained for WebGLDefaultFramebuffer, WebXROpaqueFramebuffer.
These are not correctly maintained for WebGLFramebuffer.
The correct, minimal interface would be:
class WebGLFramebufferBase {
public:
void clearIfNeeded(...) { }
};
However, I don't think this is needed for WebXR.
djg
force-pushed
the
eng/webxr/implicit-clear
branch
from
6e0f313
to
c7cdf38
Compare
|
EWS run on previous version of this PR (hash c7cdf38)
|
| } | ||
|
|
||
| private: | ||
| WebGLRenderingContextBase& m_context; |
There was a problem hiding this comment.
could store the m_context as ptr instead of having m_enabled
| } | ||
|
|
||
| private: | ||
| WebGLRenderingContextBase& m_context; |
There was a problem hiding this comment.
could store the context as ptr instead of having m_enabled
djg
force-pushed
the
eng/webxr/implicit-clear
branch
from
c7cdf38
to
e8de6d2
Compare
|
EWS run on current version of this PR (hash e8de6d2)
|
djg
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=268042 rdar://117090654 Reviewed by Kimmo Kinnunen. WebGL's default framebuffer has an implicit clear behavior. The WebXR specification requires the same behavior for its WebXROpaqueFramebuffer, therefore WebXR must ensure that it's buffers are always cleared for each rAF of the session. Currently we assume content does not do redundant initial clear, as the spec says the buffer always starts cleared. * Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp: (WebCore::WebXROpaqueFramebuffer::startFrame): (WebCore::WebXROpaqueFramebuffer::setupFramebuffer): * Source/WebCore/html/canvas/WebGLRenderingContextBase.h: * Source/WebCore/html/canvas/WebGLUtilities.h: (WebCore::ScopedClearColorAndMask::ScopedClearColorAndMask): (WebCore::ScopedClearColorAndMask::~ScopedClearColorAndMask): (WebCore::ScopedClearDepthAndMask::ScopedClearDepthAndMask): (WebCore::ScopedClearDepthAndMask::~ScopedClearDepthAndMask): (WebCore::ScopedClearStencilAndMask::ScopedClearStencilAndMask): (WebCore::ScopedClearStencilAndMask::~ScopedClearStencilAndMask): Canonical link: https://commits.webkit.org/274121@main
webkit-commit-queue
force-pushed
the
eng/webxr/implicit-clear
branch
from
e8de6d2
to
153d8bb
Compare
|
Committed 274121@main (153d8bb): https://commits.webkit.org/274121@main Reviewed commits have been landed. Closing PR #23209 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
153d8bb
e8de6d2
🛠 mac🛠 wincairo🧪 bindings🛠 mac-AS-debug🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🧪 api-ios🧪 mac-wk2🧪 gtk-wk2🛠 tv🧪 mac-AS-debug-wk2🧪 api-gtk🛠 tv-sim🧪 mac-wk2-stress🛠 watch🛠 watch-sim