[ANGLE] Add target for metal_translator_fuzzer #23337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 43ecf67)
|
kkinnunen-apple
approved these changes
Jan 29, 2024
| @@ -186,6 +191,7 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) | |||
|
|
|||
| if (translator == nullptr) | |||
| { | |||
| sh::Finalize(); // WebKit change. | |||
There was a problem hiding this comment.
Maybe just remove the comments..
We manage the changes other way, so maybe just add the code as you would in a normal and I can upstream them.
There was a problem hiding this comment.
Will do. Thanks! (I was trying to follow the libwebrtc rules here.)
There was a problem hiding this comment.
Probably don't need to upstream the ANGLE_TRANSLATOR_FUZZER_METAL_ONLY change, but wouldn't hurt.
ddkilzer
force-pushed
the
eng/ANGLE-Add-target-for-metal_translator_fuzzer
branch
from
43ecf67
to
b975b63
Compare
|
EWS run on current version of this PR (hash b975b63)
|
ddkilzer
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=268201 <rdar://98947215> Reviewed by Kimmo Kinnunen. * Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj: - Add BaseTarget.xcconfig and metal_translator_fuzzer.xcconfig. (metal_translator_fuzzer): Add target. - Add translator_fuzzer.cpp to the project. * Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig: - Add copyright header. (ANGLE_ALLOWABLE_CLIENTS): Add. - Disable -allowable_client switches when libFuzzer is enabled. (GCC_SYMBOLS_PRIVATE_EXTERN): Add. - Disable private extern symbols when libFuzzer is enabled. * Source/ThirdParty/ANGLE/Configurations/BaseTarget.xcconfig: Add. - Extract common settings from ANGLE-dynamic.xcconfig. (ANGLE_HEADER_PATH_PREFIX): Add. - Add variable for header include path prefix so it may be overridden. * Source/ThirdParty/ANGLE/Configurations/metal_translator_fuzzer.xcconfig: Add. * Source/ThirdParty/ANGLE/src/compiler/fuzz/translator_fuzzer.cpp: (LLVMFuzzerTestOneInput): - Add a way to disable non-Metal outputs at build time. - Add SH_MSL_METAL_OUTPUT as a valid output. - Call sh::Finalize() after each test case since sh::Initialize is called at the start of every test case. Canonical link: https://commits.webkit.org/273682@main
webkit-commit-queue
force-pushed
the
eng/ANGLE-Add-target-for-metal_translator_fuzzer
branch
from
b975b63
to
704290f
Compare
|
Committed 273682@main (704290f): https://commits.webkit.org/273682@main Reviewed commits have been landed. Closing PR #23337 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
704290f
b975b63
🛠 wpe🛠 wincairo🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🛠 gtk🧪 api-ios🧪 mac-wk2🧪 gtk-wk2🛠 tv🧪 mac-AS-debug-wk2🧪 api-gtk🛠 tv-sim🛠 watch🛠 watch-sim