Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GStreamer][WebRTC] Use audiornnoise for voice activity detection #23379

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

philn
Copy link
Member

@philn philn commented Jan 28, 2024

@philn philn self-assigned this Jan 28, 2024
@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Jan 28, 2024
@philn philn requested a review from calvaris January 28, 2024 09:51
@philn philn added the merge-queue Applied to send a pull request to merge-queue label Jan 30, 2024
https://bugs.webkit.org/show_bug.cgi?id=268246

Reviewed by Xabier Rodriguez-Calvar.

Future versions of the webrtcdsp element will not support VAD anymore, so we now do this with the
audiornnoise element.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCapturer.cpp:
(WebCore::GStreamerAudioCapturer::createConverter):

Canonical link: https://commits.webkit.org/273745@main
@webkit-commit-queue
Copy link
Collaborator

Committed 273745@main (beac343): https://commits.webkit.org/273745@main

Reviewed commits have been landed. Closing PR #23379 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit beac343 into WebKit:main Jan 30, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 30, 2024
@philn philn deleted the eng/268246 branch January 30, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
4 participants