Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send events async in textfield-outline. #2339

Conversation

rreno
Copy link
Member

@rreno rreno commented Jul 12, 2022

2e8bcf9

Send events async in textfield-outline.
https://bugs.webkit.org/show_bug.cgi?id=241205

Reviewed by Simon Fraser.

fast/forms/textfield-outline should send keyDown events asynchronously
due to the recent change to make style updates to non user-initiated focus in a form
asynchronous. The UIHelper helpfully preserves behavior of the old test
for macOS and other non-ios platforms.

* LayoutTests/fast/forms/textfield-outline.html:
* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/252417@main

@rreno rreno self-assigned this Jul 12, 2022
@stwrt
Copy link
Member

stwrt commented Jul 12, 2022

51b5676

Send events async in textfield-outline.
Need the bug URL (OOPS!).

Reviewed by NOBODY (OOPS!).

fast/forms/textfield-outline should send keyDown events asynchronously
due to the recent change to make style updates to non user-initiated focus in a form
asynchronous. The UIHelper helpfully preserves behavior of the old test
for macOS and other non-ios platforms.

  • LayoutTests/fast/forms/textfield-outline.html:
  • LayoutTests/platform/ios/TestExpectations:

Need the bugzilla URL 😀

@rreno rreno force-pushed the eng/textfield-outline-iossim-flake branch from 51b5676 to 575b55b Compare July 12, 2022 21:36
@rreno rreno added New Bugs Unclassified bugs are placed in this component until the correct component can be determined. WebKit Nightly Build labels Jul 12, 2022
@rreno
Copy link
Member Author

rreno commented Jul 12, 2022

Need the bugzilla URL 😀

Done!

@rreno rreno requested review from smfr and whsieh July 12, 2022 21:37
@stwrt
Copy link
Member

stwrt commented Jul 12, 2022

Overall it LGTM, but I am not a reviewer.

@stwrt stwrt added the merge-queue Applied to send a pull request to merge-queue label Jul 13, 2022
https://bugs.webkit.org/show_bug.cgi?id=241205

Reviewed by Simon Fraser.

fast/forms/textfield-outline should send keyDown events asynchronously
due to the recent change to make style updates to non user-initiated focus in a form
asynchronous. The UIHelper helpfully preserves behavior of the old test
for macOS and other non-ios platforms.

* LayoutTests/fast/forms/textfield-outline.html:
* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/252417@main
@webkit-commit-queue
Copy link
Collaborator

Committed 252417@main (2e8bcf9): https://commits.webkit.org/252417@main

Reviewed commits have been landed. Closing PR #2339 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 2e8bcf9 into WebKit:main Jul 13, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 13, 2022
@smfr
Copy link
Contributor

smfr commented Jul 13, 2022

"Send events async in textfield-outline" was an odd title for this. A reader would have to figure out that this refers to a test. A better title would have listed the entire test path: fast/forms/textfield-outline.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
5 participants