Generate Serialization for ObjectIdentifierReference and ObjectIdentifierWriteReference #23452

NKRosario · 2024-01-29T21:08:53Z

`641bc81`

Generate Serialization for ObjectIdentifierReference and ObjectIdentifierWriteReference
https://bugs.webkit.org/show_bug.cgi?id=268322
rdar://121877374

Reviewed by Alex Christensen.

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Platform/IPC/ObjectIdentifierReference.serialization.in: Added.
* Source/WebKit/Platform/IPC/ObjectIdentifierReferenceTracker.h:
(IPC::ObjectIdentifierReference::isHashTableDeletedValue const):
(IPC::ObjectIdentifierReference::encode const): Deleted.
(IPC::ObjectIdentifierReference::decode): Deleted.
(IPC::ObjectIdentifierWriteReference::encode const): Deleted.
(IPC::ObjectIdentifierWriteReference::decode): Deleted.
* Source/WebKit/Scripts/generate-serializers.py:
(get_alias_namespace):
(generate_forward_declarations):
(parse_serialized_types):
(main):
* Source/WebKit/Shared/WTFArgumentCoders.serialization.in:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/IPC/ThreadSafeObjectHeapTests.cpp:

Canonical link: https://commits.webkit.org/273849@main

50bf113

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
✅ 🧪 webkitpy	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-01-29T21:11:22Z

EWS run on previous version of this PR (hash 7890222)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	⏳ 🧪 api-wpe
~~🧪 webkitpy~~	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	⏳ 🛠 gtk
⏳ 🛠 🧪 jsc	⏳ 🧪 api-ios	⏳ 🧪 mac-wk2	⏳ 🧪 gtk-wk2
	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 api-gtk
	⏳ 🛠 tv-sim
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2024-01-29T21:16:16Z

EWS run on previous version of this PR (hash 0b65cce)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	~~🛠 ios~~	✅ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 wincairo
~~🧪 bindings~~	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	⏳ 🧪 api-wpe
⏳ 🧪 webkitpy	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	⏳ 🛠 gtk
⏳ 🛠 🧪 jsc	⏳ 🧪 api-ios	⏳ 🧪 mac-wk2	⏳ 🧪 gtk-wk2
	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 api-gtk
	⏳ 🛠 tv-sim
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2024-01-29T21:23:20Z

EWS run on previous version of this PR (hash 4ca02db)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	⏳ 🧪 api-wpe
✅ 🧪 webkitpy	⏳ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
⏳ 🛠 🧪 jsc	⏳ 🧪 api-ios	⏳ 🧪 mac-wk2	~~🧪 gtk-wk2~~
	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	~~🧪 api-gtk~~
	⏳ 🛠 tv-sim
	⏳ 🛠 watch
	✅ 🛠 watch-sim

achristensen07

Could you add to Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in then run "make -C Source/WebKit/Scripts/webkit/tests" to show what the changes to the python do to the generated C++?

achristensen07 · 2024-01-29T21:37:49Z

Source/WebKit/WebKit.xcodeproj/project.pbxproj

@@ -3,7 +3,7 @@
 	archiveVersion = 1;
 	classes = {
 	};
-	objectVersion = 54;
+	objectVersion = 55;


This change should probably be reverted.

achristensen07 · 2024-01-29T21:39:12Z

Source/WebKit/Platform/IPC/ObjectIdentifierReferenceTracker.h

 private:
+    friend struct IPC::ArgumentCoder<ObjectIdentifierReference, void>;


This is probably not necessary because there are accessors for the identifier and version.

achristensen07 · 2024-01-29T21:39:28Z

Source/WebKit/Platform/IPC/ObjectIdentifierReferenceTracker.h

 private:
+    friend struct IPC::ArgumentCoder<ObjectIdentifierWriteReference, void>;


Ditto. Use public accessors.

webkit-early-warning-system · 2024-01-29T22:23:05Z

EWS run on previous version of this PR (hash 9f0870e)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	⏳ 🧪 api-wpe
✅ 🧪 webkitpy	⏳ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	⏳ 🛠 gtk
⏳ 🛠 🧪 jsc	⏳ 🧪 api-ios	⏳ 🧪 mac-wk2	⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 api-gtk
	⏳ 🛠 tv-sim
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2024-01-29T22:54:35Z

EWS run on previous version of this PR (hash e6ab7ba)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
~~🧪 style~~	✅ 🛠 ios	✅ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🧪 api-mac	⏳ 🧪 api-wpe
✅ 🧪 webkitpy	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	⏳ 🛠 gtk
⏳ 🛠 🧪 jsc	~~🧪 api-ios~~	⏳ 🧪 mac-wk2	⏳ 🧪 gtk-wk2
	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 api-gtk
	⏳ 🛠 tv-sim
	⏳ 🛠 watch
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-01-29T23:53:46Z

EWS run on current version of this PR (hash 50bf113)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
✅ 🧪 webkitpy	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-ews-buildbot · 2024-01-30T09:11:16Z

Failed ios-wk2-wpt, mac-AS-debug-wk2 checks. Please resolve failures and re-apply safe-merge-queue label.

Rejecting #23452 from merge queue.

webkit-ews-buildbot · 2024-01-30T09:11:25Z

Safe-Merge-Queue: Build #10688.

…fierWriteReference https://bugs.webkit.org/show_bug.cgi?id=268322 rdar://121877374 Reviewed by Alex Christensen. * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Platform/IPC/ObjectIdentifierReference.serialization.in: Added. * Source/WebKit/Platform/IPC/ObjectIdentifierReferenceTracker.h: (IPC::ObjectIdentifierReference::isHashTableDeletedValue const): (IPC::ObjectIdentifierReference::encode const): Deleted. (IPC::ObjectIdentifierReference::decode): Deleted. (IPC::ObjectIdentifierWriteReference::encode const): Deleted. (IPC::ObjectIdentifierWriteReference::decode): Deleted. * Source/WebKit/Scripts/generate-serializers.py: (get_alias_namespace): (generate_forward_declarations): (parse_serialized_types): (main): * Source/WebKit/Shared/WTFArgumentCoders.serialization.in: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/IPC/ThreadSafeObjectHeapTests.cpp: Canonical link: https://commits.webkit.org/273849@main

webkit-commit-queue · 2024-01-31T20:23:38Z

Committed 273849@main (641bc81): https://commits.webkit.org/273849@main

Reviewed commits have been landed. Closing PR #23452 and removing active labels.

NKRosario requested a review from cdumez as a code owner January 29, 2024 21:08

NKRosario self-assigned this Jan 29, 2024

NKRosario added the WebKit Process Model Bugs related to WebKit's multi-process architecture label Jan 29, 2024

NKRosario force-pushed the Generate-serialization-for-ObjectIdentifierWriteReference branch from 7890222 to 0b65cce Compare January 29, 2024 21:15

NKRosario requested review from sheeparegreat and achristensen07 January 29, 2024 21:17

NKRosario force-pushed the Generate-serialization-for-ObjectIdentifierWriteReference branch from 0b65cce to 4ca02db Compare January 29, 2024 21:23

achristensen07 reviewed Jan 29, 2024

View reviewed changes

NKRosario force-pushed the Generate-serialization-for-ObjectIdentifierWriteReference branch from 4ca02db to 9f0870e Compare January 29, 2024 22:22

NKRosario force-pushed the Generate-serialization-for-ObjectIdentifierWriteReference branch from 9f0870e to e6ab7ba Compare January 29, 2024 22:53

NKRosario force-pushed the Generate-serialization-for-ObjectIdentifierWriteReference branch from e6ab7ba to 50bf113 Compare January 29, 2024 23:27

NKRosario requested a review from achristensen07 January 29, 2024 23:43

achristensen07 approved these changes Jan 30, 2024

View reviewed changes

achristensen07 added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jan 30, 2024

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 30, 2024

webkit-ews-buildbot removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jan 30, 2024

beidson added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jan 31, 2024

webkit-commit-queue force-pushed the Generate-serialization-for-ObjectIdentifierWriteReference branch from 50bf113 to 641bc81 Compare January 31, 2024 20:23

webkit-commit-queue merged commit 641bc81 into WebKit:main Jan 31, 2024

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate Serialization for ObjectIdentifierReference and ObjectIdentifierWriteReference #23452

Generate Serialization for ObjectIdentifierReference and ObjectIdentifierWriteReference #23452

NKRosario commented Jan 29, 2024 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Jan 29, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 29, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 29, 2024 •

edited

Loading

achristensen07 left a comment

achristensen07 Jan 29, 2024

achristensen07 Jan 29, 2024

achristensen07 Jan 29, 2024

webkit-early-warning-system commented Jan 29, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 29, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 29, 2024 •

edited

Loading

webkit-ews-buildbot commented Jan 30, 2024

webkit-ews-buildbot commented Jan 30, 2024

webkit-commit-queue commented Jan 31, 2024

		private:
		friend struct IPC::ArgumentCoder<ObjectIdentifierReference, void>;

Generate Serialization for ObjectIdentifierReference and ObjectIdentifierWriteReference #23452

Generate Serialization for ObjectIdentifierReference and ObjectIdentifierWriteReference #23452

Conversation

NKRosario commented Jan 29, 2024 • edited by webkit-early-warning-system Loading

641bc81

webkit-early-warning-system commented Jan 29, 2024 • edited Loading

webkit-early-warning-system commented Jan 29, 2024 • edited Loading

webkit-early-warning-system commented Jan 29, 2024 • edited Loading

achristensen07 left a comment

Choose a reason for hiding this comment

achristensen07 Jan 29, 2024

Choose a reason for hiding this comment

achristensen07 Jan 29, 2024

Choose a reason for hiding this comment

achristensen07 Jan 29, 2024

Choose a reason for hiding this comment

webkit-early-warning-system commented Jan 29, 2024 • edited Loading

webkit-early-warning-system commented Jan 29, 2024 • edited Loading

webkit-early-warning-system commented Jan 29, 2024 • edited Loading

webkit-ews-buildbot commented Jan 30, 2024

webkit-ews-buildbot commented Jan 30, 2024

webkit-commit-queue commented Jan 31, 2024

NKRosario commented Jan 29, 2024 •

edited by webkit-early-warning-system

Loading

`641bc81`

webkit-early-warning-system commented Jan 29, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 29, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 29, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 29, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 29, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 29, 2024 •

edited

Loading