Migrate iOS 16 expectations to OpenSource #2352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-jenner
added
Tools / Tests
webkit-early-warning-system
added
the
merging-blocked
|
Code looks good, @ryanhaddad, are we ready to land this now? |
JonWBedard
approved these changes
Jul 13, 2022
JonWBedard
removed
the
merging-blocked
Comment on lines
3680
to
3681
| # rdar://93063355 ([ iOS16 ] 8x imported/w3c/web-platform-tests/mathml/relations/* layout tests are a constant text failure) | ||
| imported/w3c/web-platform-tests/mathml/relations/css-styling/display-2.html [ Pass Failure ] |
There was a problem hiding this comment.
As these are a constant failure, why is this expectation flaky? Is your goal to avoid adding an ios-15 expectations directory?
There was a problem hiding this comment.
I have fixed this in my latest edits to this PR. I'm having it go through EWS again just to verify my changes worked.
Not yet, we need an ios-15 folder to house baselines to keep existing bots happy. |
robert-jenner
force-pushed
the
eng/Migrate-iOS-16-expectations-to-OpenSource
branch
2 times, most recently
from
77b57d8
to
5aa249a
Compare
webkit-early-warning-system
added
the
merging-blocked
robert-jenner
removed
the
merging-blocked
robert-jenner
changed the title
robert-jenner
force-pushed
the
eng/Migrate-iOS-16-expectations-to-OpenSource
branch
from
3aa3f63
to
54f7d65
Compare
robert-jenner
added
Compositing
https://bugs.webkit.org/show_bug.cgi?id=242650 Reviewed by NOBODY (OOPS!). * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/ios/imported/w3c/web-platform-tests/cookies/value/value-ctl-expected.txt: Added. * LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/dom/documents/resource-metadata-management/document-cookie-expected.txt: Added. * LayoutTests/platform/ios/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: * LayoutTests/platform/ios/svg/batik/text/textStyles-expected.txt: * LayoutTests/platform/ios/svg/custom/use-invalid-pattern-expected.txt: Added. * LayoutTests/platform/ios/svg/custom/use-invalid-style-expected.txt: Added. * LayoutTests/platform/ios/svg/hixie/error/012-expected.txt: * Tools/Scripts/webkitpy/port/ios.py: (IOSPort): * Tools/Scripts/webkitpy/port/ios_device_unittest.py: * Tools/Scripts/webkitpy/port/ios_simulator_unittest.py: (IOSSimulatorTest.make_port): (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions): (IOSSimulatorTest.test_layout_test_searchpath_without_apple_additions): (IOSSimulatorTest.test_layout_searchpath_wih_device_type): * Tools/Scripts/webkitpy/port/ios_testcase.py: (IOSTest.make_port):
robert-jenner
removed
Compositing
robert-jenner
changed the title
robert-jenner
force-pushed
the
eng/Migrate-iOS-16-expectations-to-OpenSource
branch
from
54f7d65
to
4a63e72
Compare
robert-jenner
added
Tools / Tests
webkit-early-warning-system
added
the
merging-blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4a63e72