New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GTK] Check window focus with gtk_window_is_active() #23598
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
GeorgesStavracas:eng/GTK-gamepad-API-does-not-work
Feb 1, 2024
Merged
[GTK] Check window focus with gtk_window_is_active() #23598
webkit-commit-queue
merged 1 commit into
WebKit:main
from
GeorgesStavracas:eng/GTK-gamepad-API-does-not-work
Feb 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GeorgesStavracas
force-pushed
the
eng/GTK-gamepad-API-does-not-work
branch
from
January 31, 2024 18:23
a9630d7
to
3180c76
Compare
EWS run on previous version of this PR (hash a9630d7) |
EWS run on current version of this PR (hash 3180c76) |
mcatanzaro
approved these changes
Jan 31, 2024
mcatanzaro
added
the
safe-merge-queue
Applied to automatically send a pull-request to merge-queue after passing EWS checks
label
Jan 31, 2024
Welcome ;) |
webkit-ews-buildbot
added
merge-queue
Applied to send a pull request to merge-queue
and removed
safe-merge-queue
Applied to automatically send a pull-request to merge-queue after passing EWS checks
labels
Feb 1, 2024
Safe-Merge-Queue: Build #10856. |
https://bugs.webkit.org/show_bug.cgi?id=258264 Reviewed by Michael Catanzaro. In GTK3, gtk_widget_has_focus() called on a GtkWindow has the semantics of "does this window receive input". This semantic is not preserved in GTK4; instead, gtk_window_is_active() is what yields the same results. By using gtk_widget_has_focus() in UIGamepadProviderGtk, it always returned false, and prevented gamepad detection from properly working. Switch that to gtk_window_is_active(). * Source/WebKit/UIProcess/Gamepad/gtk/UIGamepadProviderGtk.cpp: (WebKit::UIGamepadProvider::platformWebPageProxyForGamepadInput): Canonical link: https://commits.webkit.org/273882@main
webkit-commit-queue
force-pushed
the
eng/GTK-gamepad-API-does-not-work
branch
from
February 1, 2024 03:44
3180c76
to
7ca356b
Compare
Committed 273882@main (7ca356b): https://commits.webkit.org/273882@main Reviewed commits have been landed. Closing PR #23598 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7ca356b
3180c76