[WPE] WPE Platform: make sure the DRM device selected is capable of modesetting #23657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 4f35f9d)
|
psaavedra
force-pushed
the
eng/WPE-WPE-Platform-make-sure-the-DRM-device-selected-is-capable-of-modesetting
branch
from
4f35f9d
to
587588f
Compare
|
EWS run on current version of this PR (hash 587588f)
|
🧪 style
|
EWS run on previous version of this PR (hash 587588f)
|
carlosgcampos
approved these changes
Feb 1, 2024
aperezdc
approved these changes
Feb 1, 2024
psaavedra
added
safe-merge-queue
psaavedra
force-pushed
the
eng/WPE-WPE-Platform-make-sure-the-DRM-device-selected-is-capable-of-modesetting
branch
from
587588f
to
b5e8fec
Compare
|
EWS run on current version of this PR (hash b5e8fec)
|
psaavedra
added
safe-merge-queue
webkit-commit-queue
force-pushed
the
eng/WPE-WPE-Platform-make-sure-the-DRM-device-selected-is-capable-of-modesetting
branch
from
b5e8fec
to
e2b5ade
Compare
…odesetting https://bugs.webkit.org/show_bug.cgi?id=268535 Reviewed by Carlos Garcia Campos and Adrian Perez de Castro. Fixes the findDevice() by ensuring the returning device has DRM resources. Related-To: WebKit#23608 * Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.cpp: (findDevice): Canonical link: https://commits.webkit.org/273896@main
webkit-commit-queue
force-pushed
the
eng/WPE-WPE-Platform-make-sure-the-DRM-device-selected-is-capable-of-modesetting
branch
from
e2b5ade
to
3b6c9da
Compare
|
Committed 273896@main (3b6c9da): https://commits.webkit.org/273896@main Reviewed commits have been landed. Closing PR #23657 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
webkit-commit-queue
pushed a commit
to psaavedra/WebKit
that referenced
this pull request
Feb 1, 2024
https://bugs.webkit.org/show_bug.cgi?id=268487 Reviewed by Carlos Garcia Campos. This patch is generic but fixes the DRM initialization for NXP imx6qp Sabre Development boards: * Removes the check for the valid connector in the chooseConnector(). The encoder Id can be zero if the connector is not currently bound to an encoder or if the encoder+crtc is already used by another connector. * Modifies the chooseCrtcForConnector() logic. We implement a more robust mechanism by checking the encoder->possible_crtcs in case of no active crtc was found. Credits to Jani Hautakangas <jani@igalia.com>. Related-To: Igalia/cog#590 Related-To: WebKit#23654 Related-To: WebKit#23657 * Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.cpp: (chooseConnector): (chooseCrtcForConnector): Canonical link: https://commits.webkit.org/273898@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3b6c9da
b5e8fec
🛠 wincairo🧪 wpe-wk2🧪 ios-wk2🧪 ios-wk2-wpt🧪 api-ios🧪 gtk-wk2🛠 tv🧪 mac-AS-debug-wk2🧪 api-gtk🛠 tv-sim🛠 watch🛠 watch-sim