Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] YouTube does not provide an AirPlay button in fullscreen mode #23753

Merged
merged 1 commit into from
Feb 5, 2024
Merged

[iOS] YouTube does not provide an AirPlay button in fullscreen mode #23753

merged 1 commit into from
Feb 5, 2024

Conversation

jernoble
Copy link
Contributor

@jernoble jernoble commented Feb 2, 2024 •
edited by webkit-early-warning-system
Loading

f2404c1

[iOS] YouTube does not provide an AirPlay button in fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=268634
rdar://121471373

Reviewed by Brent Fulgham and Aditya Keerthi.

Add a quirk to disable the Fullscreen API on YouTube.com (and youtube.com embeds).

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldDisableElementFullscreenQuirk const):

Canonical link: https://commits.webkit.org/274117@main

889c537

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@jernoble jernoble requested a review from cdumez as a code owner February 2, 2024 17:48
@jernoble jernoble self-assigned this Feb 2, 2024
@jernoble jernoble added the Media Bugs related to the HTML 5 Media elements. label Feb 2, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 2, 2024 •
edited
Loading

EWS run on previous version of this PR (hash fc46aa7)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ⏳ 🧪 api-mac   🧪 api-wpe
⏳ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 gtk
⏳ 🛠 🧪 jsc ⏳ 🧪 api-ios ⏳ 🧪 mac-wk2 ⏳ 🧪 gtk-wk2
⏳ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 api-gtk
⏳ 🛠 tv-sim
⏳ 🛠 watch
⏳ 🛠 watch-sim

@jernoble jernoble force-pushed the eng/iOS-YouTube-does-not-provide-an-AirPlay-button-in-fullscreen-mode branch from fc46aa7 to 70efd92 Compare February 2, 2024 18:04
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 2, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 70efd92)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ⏳ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ⏳ 🧪 mac-wk1 ✅ 🛠 gtk
⏳ 🛠 🧪 jsc ✅ 🧪 api-ios ⏳ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
❌ 🛠 tv   🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
⏳ 🛠 tv-sim
❌ 🛠 watch
⏳ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 2, 2024
brentfulgham
brentfulgham approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. r=me

Source/WebCore/page/Quirks.cpp
if (!m_shouldDisableElementFullscreen) {
m_shouldDisableElementFullscreen = isDomain("vimeo.com"_s)
|| isDomain("instagram.com"_s)
|| isEmbedDomain("twitter.com"_s);
|| isEmbedDomain("twitter.com"_s)
|| (PAL::currentUserInterfaceIdiomIsSmallScreen() && (isDomain("youtube.com"_s) || isEmbedDomain("youtube.com"_s)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so sad. :-(

@jernoble jernoble removed the merging-blocked Applied to prevent a change from being merged label Feb 2, 2024
@jernoble jernoble force-pushed the eng/iOS-YouTube-does-not-provide-an-AirPlay-button-in-fullscreen-mode branch from 70efd92 to f3ebfd4 Compare February 2, 2024 20:18
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 2, 2024 •
edited
Loading

EWS run on previous version of this PR (hash f3ebfd4)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ⏳ 🧪 api-mac ✅ 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt ⏳ 🧪 mac-wk1 ✅ 🛠 gtk
⏳ 🛠 🧪 jsc   🧪 api-ios ⏳ 🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2   🧪 api-gtk
⏳ 🛠 tv-sim
⏳ 🛠 watch
⏳ 🛠 watch-sim

@jernoble jernoble force-pushed the eng/iOS-YouTube-does-not-provide-an-AirPlay-button-in-fullscreen-mode branch from f3ebfd4 to 889c537 Compare February 2, 2024 21:52
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 2, 2024 •
edited
Loading

EWS run on current version of this PR (hash 889c537)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 3, 2024
@jernoble jernoble added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Feb 5, 2024
@jernoble
[iOS] YouTube does not provide an AirPlay button in fullscreen mode
f2404c1 
https://bugs.webkit.org/show_bug.cgi?id=268634
rdar://121471373

Reviewed by Brent Fulgham and Aditya Keerthi.

Add a quirk to disable the Fullscreen API on YouTube.com (and youtube.com embeds).

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldDisableElementFullscreenQuirk const):

Canonical link: https://commits.webkit.org/274117@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/iOS-YouTube-does-not-provide-an-AirPlay-button-in-fullscreen-mode branch from 889c537 to f2404c1 Compare February 5, 2024 23:16
@webkit-commit-queue
Copy link
Collaborator

Committed 274117@main (f2404c1): https://commits.webkit.org/274117@main

Reviewed commits have been landed. Closing PR #23753 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f2404c1 into WebKit:main Feb 5, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxlcoder pxlcoder pxlcoder approved these changes

@brentfulgham brentfulgham brentfulgham approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@jyavenard jyavenard Awaiting requested review from jyavenard

@aestes aestes Awaiting requested review from aestes

@eric-carlson eric-carlson Awaiting requested review from eric-carlson

@danae404 danae404 Awaiting requested review from danae404

Assignees

@jernoble jernoble

Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
Milestone
No milestone
6 participants
@jernoble @webkit-early-warning-system @webkit-commit-queue @pxlcoder @brentfulgham @webkit-ews-buildbot