[JSC] Micro-optimize String equal operation with UChar / LChar #23804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 388bff0) |
rniwa
approved these changes
Feb 3, 2024
| @@ -344,13 +344,36 @@ ALWAYS_INLINE bool equal(const LChar* a, const UChar* b, unsigned length) | |||
| } | |||
| return true; | |||
| } | |||
| // Otherwise, we just do a naive loop. | |||
| #endif | |||
| if (length >= 4) { | |||
There was a problem hiding this comment.
Since the cases < 8 don't use SIMD intrinsics, couldn't these also be enabled for x64 without further changes?
There was a problem hiding this comment.
The code is relying on that we have length >= 8 loop, which x64 does not have.
webkit-ews-buildbot
added
the
merging-blocked
Constellation
removed
the
merging-blocked
Constellation
force-pushed
the
eng/JSC-Micro-optimize-String-equal-operation-with-UChar--LChar
branch
from
388bff0
to
1a508d6
Compare
|
EWS run on current version of this PR (hash 1a508d6) |
webkit-ews-buildbot
added
the
merging-blocked
Constellation
added
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=268684 rdar://122224476 Reviewed by Ryosuke Niwa. This patch micro-optimizes String equal operation with different characters (UChar* and LChar*). ToT Patched todomvc-javascript-es5-json-parse 37.6466+-0.1862 ^ 37.1991+-0.1560 ^ definitely 1.0120x faster todomvc-javascript-es6-webpack-json-parse 58.9239+-0.3310 ^ 58.2251+-0.1931 ^ definitely 1.0120x faster * Source/WTF/wtf/text/StringCommon.h: Canonical link: https://commits.webkit.org/274064@main
webkit-commit-queue
force-pushed
the
eng/JSC-Micro-optimize-String-equal-operation-with-UChar--LChar
branch
from
1a508d6
to
bacdbda
Compare
|
Committed 274064@main (bacdbda): https://commits.webkit.org/274064@main Reviewed commits have been landed. Closing PR #23804 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bacdbda
1a508d6