-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[threaded-animation-resolution] add support for blending opacity
values
#23854
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
graouts:threaded-animation-resolution-initial-blending-support-with-only-opacity
Feb 5, 2024
Merged
[threaded-animation-resolution] add support for blending opacity
values
#23854
webkit-commit-queue
merged 1 commit into
WebKit:main
from
graouts:threaded-animation-resolution-initial-blending-support-with-only-opacity
Feb 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash 1f79be0) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Feb 5, 2024
graouts
force-pushed
the
threaded-animation-resolution-initial-blending-support-with-only-opacity
branch
from
February 5, 2024 14:14
1f79be0
to
c01c3b4
Compare
EWS run on current version of this PR (hash c01c3b4) |
smfr
approved these changes
Feb 5, 2024
graouts
added
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Feb 5, 2024
β¦lues https://bugs.webkit.org/show_bug.cgi?id=268738 rdar://122304627 Reviewed by Simon Fraser. In order to add support for blending `opacity` values we make `AcceleratedEffect` adopt the `KeyframeInterpolation::interpolateKeyframes()` method and its various callbacks to deal with `AcceleratedEffect::Keyframe` values. We wrap this into the new `AcceleratedEffect::apply()` method which is called from `RemoteAcceleratedEffectStack` in the `computeValues()` method. We compute the blended values in three different places in `RemoteAcceleratedEffectStack`. When we resolve effects on the main thread (macOS) we have an `initEffectsFromScrollingThread()` method to initialize the `CAPresentationModifier` objects which will apply the blended values, and then on subsequent display updates we call `applyEffectsFromScrollingThread()`. When we resolve effects on the scrolling thread (iOS) there is no initialization step required and the single `applyEffectsFromScrollingThread()` method suffices. Future patches will add support for the other transform-related and filter-related accelerated properties. * Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h: * Source/WebCore/platform/animation/AcceleratedEffect.cpp: (WebCore::blend): (WebCore::AcceleratedEffect::apply): * Source/WebCore/platform/animation/AcceleratedEffect.h: * Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.h: * Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.mm: (WebKit::RemoteAcceleratedEffectStack::initEffectsFromScrollingThread): (WebKit::RemoteAcceleratedEffectStack::applyEffectsFromScrollingThread const): (WebKit::RemoteAcceleratedEffectStack::applyEffectsFromMainThread const): (WebKit::RemoteAcceleratedEffectStack::computeValues const): (WebKit::RemoteAcceleratedEffectStack::clear): Canonical link: https://commits.webkit.org/274102@main
webkit-commit-queue
force-pushed
the
threaded-animation-resolution-initial-blending-support-with-only-opacity
branch
from
February 5, 2024 18:01
c01c3b4
to
c31a035
Compare
Committed 274102@main (c31a035): https://commits.webkit.org/274102@main Reviewed commits have been landed. Closing PR #23854 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Feb 5, 2024
graouts
deleted the
threaded-animation-resolution-initial-blending-support-with-only-opacity
branch
February 5, 2024 18:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c31a035
c01c3b4
π§ͺ mac-wk2