Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ews-build.webkit.org] Filter out DVTAssertions messages #23966

Merged
merged 1 commit into from
Feb 7, 2024
Merged

[ews-build.webkit.org] Filter out DVTAssertions messages #23966

merged 1 commit into from
Feb 7, 2024

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Feb 7, 2024 •
edited by webkit-early-warning-system
Loading

22a7246

[ews-build.webkit.org] Filter out DVTAssertions messages
https://bugs.webkit.org/show_bug.cgi?id=268872
rdar://122433123

Reviewed by Dewei Zhu.

* Tools/CISupport/ews-build/steps.py:
(CompileWebKit.start): Send stderr to stdout to be filtered by filter-build-webkit.
* Tools/CISupport/ews-build/steps_unittest.py:
* Tools/Scripts/filter-build-webkit:
(shouldIgnoreLine): Ignore lines including 'DVTAssertions'.

Canonical link: https://commits.webkit.org/274182@main

1ff3621

Misc iOS, tvOS & watchOS macOS Linux Windows
⏳ 🧪 style ⏳ 🛠 ios ⏳ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 wincairo
⏳ 🧪 bindings ⏳ 🛠 ios-sim ⏳ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
⏳ 🧪 webkitperl ⏳ 🧪 ios-wk2 ⏳ 🧪 api-mac ⏳ 🧪 api-wpe
⏳ 🧪 webkitpy ⏳ 🧪 ios-wk2-wpt ⏳ 🧪 mac-wk1 ⏳ 🛠 gtk
⏳ 🛠 🧪 jsc ⏳ 🧪 api-ios ⏳ 🧪 mac-wk2 ⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 api-gtk
⏳ 🧪 services ⏳ 🛠 tv-sim ⏳ 🧪 mac-wk2-stress ⏳ 🛠 jsc-armv7
⏳ 🛠 watch ⏳ 🧪 jsc-armv7-tests
✅ 🛠 🧪 unsafe-merge ⏳ 🛠 watch-sim

@JonWBedard JonWBedard self-assigned this Feb 7, 2024
@JonWBedard JonWBedard added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Feb 7, 2024
dewei-zhu
dewei-zhu approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@dewei-zhu dewei-zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@JonWBedard JonWBedard added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 7, 2024
@JonWBedard
[ews-build.webkit.org] Filter out DVTAssertions messages
22a7246 
https://bugs.webkit.org/show_bug.cgi?id=268872
rdar://122433123

Reviewed by Dewei Zhu.

* Tools/CISupport/ews-build/steps.py:
(CompileWebKit.start): Send stderr to stdout to be filtered by filter-build-webkit.
* Tools/CISupport/ews-build/steps_unittest.py:
* Tools/Scripts/filter-build-webkit:
(shouldIgnoreLine): Ignore lines including 'DVTAssertions'.

Canonical link: https://commits.webkit.org/274182@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/ews-build-webkit-org-Filter-out-DVTAssertions-messages branch from 1ff3621 to 22a7246 Compare February 7, 2024 00:42
@webkit-commit-queue webkit-commit-queue merged commit 22a7246 into WebKit:main Feb 7, 2024
@webkit-commit-queue
Copy link
Collaborator

Committed 274182@main (22a7246): https://commits.webkit.org/274182@main

Reviewed commits have been landed. Closing PR #23966 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 7, 2024
@JonWBedard JonWBedard deleted the eng/ews-build-webkit-org-Filter-out-DVTAssertions-messages branch February 8, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dewei-zhu dewei-zhu dewei-zhu approved these changes

@aj062 aj062 Awaiting requested review from aj062 aj062 is a code owner

@ryanhaddad ryanhaddad Awaiting requested review from ryanhaddad ryanhaddad is a code owner

Assignees

@JonWBedard JonWBedard

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
3 participants
@JonWBedard @webkit-commit-queue @dewei-zhu