Generate serialization for NSPresentationIntent #24035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscottapple
added
the
WebKit Process Model
achristensen07
requested changes
Feb 7, 2024
| result = [NSPresentationIntent thematicBreakIntentWithIdentity:m_identity nestedInsideIntent:parent]; | ||
| break; | ||
| case NSPresentationIntentKindTable: | ||
| columnAlignments = [[NSMutableArray alloc] initWithCapacity:m_columnAlignments.size()]; |
There was a problem hiding this comment.
This is a memory leak.
There was a problem hiding this comment.
It's not, because of the [columnAlignments release] that was further down, but I've changed to use smart pointers to be consistent with The WK Way™.
mscottapple
force-pushed
the
eng/Generate-serialization-for-NSPresentationIntent
branch
from
c74037b
to
7abaabc
Compare
mscottapple
force-pushed
the
eng/Generate-serialization-for-NSPresentationIntent
branch
from
7abaabc
to
4cba283
Compare
achristensen07
approved these changes
Feb 8, 2024
|
|
||
| int64_t m_intentKind { 0 }; | ||
| int64_t m_identity { 0 }; | ||
| std::unique_ptr<CoreIPCPresentationIntent> m_parentIntent { nullptr }; |
There was a problem hiding this comment.
std::unique_ptr has a default constructor that initializes the pointer, so { nullptr } is unnecessary.
|
|
||
| #if PLATFORM(COCOA) | ||
|
|
||
| #include "ArgumentCodersCocoa.h" |
There was a problem hiding this comment.
This also seems unnecessary. <wtf/ArgumentCoder.h> should be sufficient.
|
EWS run on previous version of this PR (hash c74037b)
|
|
EWS run on previous version of this PR (hash 7abaabc)
|
mscottapple
force-pushed
the
eng/Generate-serialization-for-NSPresentationIntent
branch
from
4cba283
to
1dd1fd2
Compare
|
EWS run on previous version of this PR (hash 4cba283)
|
|
EWS run on current version of this PR (hash 1dd1fd2)
|
achristensen07
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=268779 rdar://109121874 Reviewed by achristensen07 (Alex Christensen). * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h: * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm: (IPC::typeFromObject): (IPC::shouldEnableStrictMode): * Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.h: * Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.mm: (WebKit::valueFromID): * Source/WebKit/Shared/Cocoa/CoreIPCPresentationIntent.h: Added. (WebKit::CoreIPCPresentationIntent::CoreIPCPresentationIntent): * Source/WebKit/Shared/Cocoa/CoreIPCPresentationIntent.mm: Added. (WebKit::CoreIPCPresentationIntent::CoreIPCPresentationIntent): (WebKit::CoreIPCPresentationIntent::toID const): * Source/WebKit/Shared/Cocoa/CoreIPCPresentationIntent.serialization.in: Added. * Source/WebKit/Shared/Cocoa/CoreIPCTypes.h: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm: (TEST): Canonical link: https://commits.webkit.org/274269@main
webkit-commit-queue
force-pushed
the
eng/Generate-serialization-for-NSPresentationIntent
branch
from
1dd1fd2
to
089245f
Compare
|
Committed 274269@main (089245f): https://commits.webkit.org/274269@main Reviewed commits have been landed. Closing PR #24035 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
089245f
1dd1fd2
🛠 wincairo🧪 wpe-wk2🧪 api-mac🧪 ios-wk2-wpt🧪 mac-wk2🛠 tv🛠 watch