Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt more smart pointers in Page.cpp #24036

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Feb 7, 2024

dd3340d

Adopt more smart pointers in Page.cpp
https://bugs.webkit.org/show_bug.cgi?id=268938

Reviewed by Brent Fulgham.

* Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.h:
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/DocumentInlines.h:
(WebCore::Document::checkedExtensionStyleSheets):
* Source/WebCore/dom/VisitedLinkState.h:
* Source/WebCore/history/BackForwardController.h:
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::checkedRenderView const):
* Source/WebCore/page/LocalFrameView.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::forEachPage):
(WebCore::networkStateChanged):
(WebCore::m_historyItemClient):
(WebCore::Page::~Page):
(WebCore::Page::checkedBackForward):
(WebCore::Page::clearPreviousItemFromAllPages):
(WebCore::Page::renderTreeSize const):
(WebCore::Page::disabledAdaptations const):
(WebCore::viewportDocumentForFrame):
(WebCore::Page::viewportArguments const):
(WebCore::Page::setOverrideViewportArguments):
(WebCore::Page::scrollingCoordinator):
(WebCore::Page::scrollingStateTreeAsText):
(WebCore::Page::synchronousScrollingReasonsAsText):
(WebCore::Page::nonFastScrollableRectsForTesting):
(WebCore::Page::touchEventRectsForEventForTesting):
(WebCore::Page::passiveTouchEventListenerRectsForTesting):
(WebCore::Page::accessibilityTreeData const):
(WebCore::Page::progressEstimateChanged const):
(WebCore::Page::progressFinished const):
(WebCore::Page::goToItem):
(WebCore::Page::updateStyleAfterChangeInEnvironment):
(WebCore::Page::updateStyleForAllPagesAfterGlobalChangeInEnvironment):
(WebCore::Page::setNeedsRecalcStyleInAllFrames):
(WebCore::Page::refreshPlugins):
(WebCore::Page::findString):
(WebCore::Page::findTextMatches):
(WebCore::Page::rangeOfString):
(WebCore::Page::findMatchesForText):
(WebCore::replaceRanges):
(WebCore::Page::replaceSelectionWithText):
(WebCore::Page::setEditableRegionEnabled):
(WebCore::Page::editableElementsInRect const):
(WebCore::Page::checkedFocusController const):
(WebCore::Page::setInteractionRegionsEnabled):
(WebCore::Page::selection const):
(WebCore::Page::setDefersLoading):
(WebCore::Page::setZoomedOutPageScaleFactor):
(WebCore::Page::setPageScaleFactor):
(WebCore::Page::setDeviceScaleFactor):
(WebCore::Page::windowScreenDidChange):
(WebCore::Page::setTopContentInset):
(WebCore::Page::lockAllOverlayScrollbarsToHidden):
(WebCore::Page::group):
(WebCore::Page::setVerticalScrollElasticity):
(WebCore::Page::setHorizontalScrollElasticity):
(WebCore::Page::pageCount const):
(WebCore::Page::pageCountAssumingLayoutIsUpToDate const):
(WebCore::Page::setIsInWindowInternal):
(WebCore::Page::layoutIfNeeded):
(WebCore::Page::didScheduleRenderingUpdate):
(WebCore::Page::updateRendering):
(WebCore::Page::doAfterUpdateRendering):
(WebCore::Page::finalizeRenderingUpdateForRootFrame):
(WebCore::Page::renderingUpdateCompleted):
(WebCore::Page::protectedOpportunisticTaskScheduler const):
(WebCore::Page::willStartRenderingUpdateDisplay):
(WebCore::Page::didCompleteRenderingUpdateDisplay):
(WebCore::Page::didCompleteRenderingFrame):
(WebCore::Page::prioritizeVisibleResources):
(WebCore::Page::shouldUpdateAccessibilityRegions const):
(WebCore::Page::timelineControllerMaximumAnimationFrameRateDidChange):
(WebCore::Page::preferredRenderingUpdateFramesPerSecond const):
(WebCore::Page::setIsVisuallyIdleInternal):
(WebCore::Page::handleLowPowerModeChange):
(WebCore::Page::userStyleSheetLocationChanged):
(WebCore::Page::userStyleSheet const):
(WebCore::Page::userAgentChanged):
(WebCore::Page::invalidateStylesForAllLinks):
(WebCore::Page::invalidateStylesForLink):
(WebCore::Page::setDebugger):
(WebCore::Page::setMemoryCacheClientCallsEnabled):
(WebCore::Page::resumeAnimatingImages):
(WebCore::Page::setActivityState):
(WebCore::Page::stopKeyboardScrollAnimation):
(WebCore::Page::setIsVisibleInternal):
(WebCore::Page::setHeaderHeight):
(WebCore::Page::setFooterHeight):
(WebCore::Page::pageExtendedBackgroundColor const):
(WebCore::Page::setUnderPageBackgroundColorOverride):
(WebCore::Page::addRelevantRepaintedObject):
(WebCore::Page::suspendActiveDOMObjectsAndAnimations):
(WebCore::Page::resumeActiveDOMObjectsAndAnimations):
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):
(WebCore::Page::protectedStorageNamespaceProvider const):
(WebCore::Page::protectedPluginInfoProvider const):
(WebCore::Page::setUserContentProvider):
(WebCore::Page::protectedVisitedLinkStore):
(WebCore::Page::setVisitedLinkStore):
(WebCore::Page::setSessionID):
(WebCore::Page::clearWheelEventTestMonitor):
(WebCore::Page::startMonitoringWheelEvents):
(WebCore::Page::accessibilitySettingsDidChange):
(WebCore::Page::appearanceDidChange):
(WebCore::Page::hasLocalDataForURL):
(WebCore::dispatchPrintEvent):
(WebCore::Page::dispatchBeforePrintEvent):
(WebCore::Page::dispatchAfterPrintEvent):
(WebCore::Page::startApplePayAMSUISession):
(WebCore::Page::setMediaSessionCoordinator):
(WebCore::Page::invalidateMediaSessionCoordinator):
(WebCore::Page::didFinishLoadingImageForElement):
(WebCore::Page::recomputeTextAutoSizingInAllFrames):
(WebCore::Page::revealCurrentSelection):
(WebCore::Page::injectUserStyleSheet):
(WebCore::Page::removeInjectedUserStyleSheet):
(WebCore::Page::mainFrameDidChangeToNonInitialEmptyDocument):
(WebCore::Page::updateElementsWithTextRecognitionResults):
(WebCore::Page::serviceWorkerGlobalObject):
(WebCore::Page::setupForRemoteWorker):
(WebCore::Page::forceRepaintAllFrames):
(WebCore::Page::updatePlayStateForAllAnimations):
(WebCore::Page::reloadExecutionContextsForOrigin const):
(WebCore::Page::accessibilityRootObject const):
(WebCore::Page::setAccessibilityRootObject):
* Source/WebCore/page/Page.h:
(WebCore::Page::accessibilityRootObject const): Deleted.
(WebCore::Page::setAccessibilityRootObject): Deleted.
(WebCore::Page::group): Deleted.
* Source/WebCore/page/PageGroup.h:

Canonical link: https://commits.webkit.org/274301@main

f677778

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug loading πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2   πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
  πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  gtk
βœ… πŸ§ͺ api-ios   πŸ§ͺ mac-wk2 loading πŸ§ͺ gtk-wk2
⏳ πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 loading πŸ§ͺ api-gtk
βœ… πŸ›  tv-sim
  πŸ›  watch
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim

@cdumez cdumez self-assigned this Feb 7, 2024
@cdumez cdumez added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Feb 7, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 8, 2024
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Feb 8, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 8, 2024
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Feb 8, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 8, 2024
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Feb 8, 2024
@cdumez cdumez marked this pull request as ready for review February 8, 2024 18:26
@cdumez cdumez requested review from a team and rniwa as code owners February 8, 2024 18:26
@cdumez cdumez requested review from darinadler, rniwa, geoffreygaren and brentfulgham and removed request for a team and rniwa February 8, 2024 18:26
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me.

@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 8, 2024
https://bugs.webkit.org/show_bug.cgi?id=268938

Reviewed by Brent Fulgham.

* Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.h:
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/DocumentInlines.h:
(WebCore::Document::checkedExtensionStyleSheets):
* Source/WebCore/dom/VisitedLinkState.h:
* Source/WebCore/history/BackForwardController.h:
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::checkedRenderView const):
* Source/WebCore/page/LocalFrameView.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::forEachPage):
(WebCore::networkStateChanged):
(WebCore::m_historyItemClient):
(WebCore::Page::~Page):
(WebCore::Page::checkedBackForward):
(WebCore::Page::clearPreviousItemFromAllPages):
(WebCore::Page::renderTreeSize const):
(WebCore::Page::disabledAdaptations const):
(WebCore::viewportDocumentForFrame):
(WebCore::Page::viewportArguments const):
(WebCore::Page::setOverrideViewportArguments):
(WebCore::Page::scrollingCoordinator):
(WebCore::Page::scrollingStateTreeAsText):
(WebCore::Page::synchronousScrollingReasonsAsText):
(WebCore::Page::nonFastScrollableRectsForTesting):
(WebCore::Page::touchEventRectsForEventForTesting):
(WebCore::Page::passiveTouchEventListenerRectsForTesting):
(WebCore::Page::accessibilityTreeData const):
(WebCore::Page::progressEstimateChanged const):
(WebCore::Page::progressFinished const):
(WebCore::Page::goToItem):
(WebCore::Page::updateStyleAfterChangeInEnvironment):
(WebCore::Page::updateStyleForAllPagesAfterGlobalChangeInEnvironment):
(WebCore::Page::setNeedsRecalcStyleInAllFrames):
(WebCore::Page::refreshPlugins):
(WebCore::Page::findString):
(WebCore::Page::findTextMatches):
(WebCore::Page::rangeOfString):
(WebCore::Page::findMatchesForText):
(WebCore::replaceRanges):
(WebCore::Page::replaceSelectionWithText):
(WebCore::Page::setEditableRegionEnabled):
(WebCore::Page::editableElementsInRect const):
(WebCore::Page::checkedFocusController const):
(WebCore::Page::setInteractionRegionsEnabled):
(WebCore::Page::selection const):
(WebCore::Page::setDefersLoading):
(WebCore::Page::setZoomedOutPageScaleFactor):
(WebCore::Page::setPageScaleFactor):
(WebCore::Page::setDeviceScaleFactor):
(WebCore::Page::windowScreenDidChange):
(WebCore::Page::setTopContentInset):
(WebCore::Page::lockAllOverlayScrollbarsToHidden):
(WebCore::Page::group):
(WebCore::Page::setVerticalScrollElasticity):
(WebCore::Page::setHorizontalScrollElasticity):
(WebCore::Page::pageCount const):
(WebCore::Page::pageCountAssumingLayoutIsUpToDate const):
(WebCore::Page::setIsInWindowInternal):
(WebCore::Page::layoutIfNeeded):
(WebCore::Page::didScheduleRenderingUpdate):
(WebCore::Page::updateRendering):
(WebCore::Page::doAfterUpdateRendering):
(WebCore::Page::finalizeRenderingUpdateForRootFrame):
(WebCore::Page::renderingUpdateCompleted):
(WebCore::Page::protectedOpportunisticTaskScheduler const):
(WebCore::Page::willStartRenderingUpdateDisplay):
(WebCore::Page::didCompleteRenderingUpdateDisplay):
(WebCore::Page::didCompleteRenderingFrame):
(WebCore::Page::prioritizeVisibleResources):
(WebCore::Page::shouldUpdateAccessibilityRegions const):
(WebCore::Page::timelineControllerMaximumAnimationFrameRateDidChange):
(WebCore::Page::preferredRenderingUpdateFramesPerSecond const):
(WebCore::Page::setIsVisuallyIdleInternal):
(WebCore::Page::handleLowPowerModeChange):
(WebCore::Page::userStyleSheetLocationChanged):
(WebCore::Page::userStyleSheet const):
(WebCore::Page::userAgentChanged):
(WebCore::Page::invalidateStylesForAllLinks):
(WebCore::Page::invalidateStylesForLink):
(WebCore::Page::setDebugger):
(WebCore::Page::setMemoryCacheClientCallsEnabled):
(WebCore::Page::resumeAnimatingImages):
(WebCore::Page::setActivityState):
(WebCore::Page::stopKeyboardScrollAnimation):
(WebCore::Page::setIsVisibleInternal):
(WebCore::Page::setHeaderHeight):
(WebCore::Page::setFooterHeight):
(WebCore::Page::pageExtendedBackgroundColor const):
(WebCore::Page::setUnderPageBackgroundColorOverride):
(WebCore::Page::addRelevantRepaintedObject):
(WebCore::Page::suspendActiveDOMObjectsAndAnimations):
(WebCore::Page::resumeActiveDOMObjectsAndAnimations):
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):
(WebCore::Page::protectedStorageNamespaceProvider const):
(WebCore::Page::protectedPluginInfoProvider const):
(WebCore::Page::setUserContentProvider):
(WebCore::Page::protectedVisitedLinkStore):
(WebCore::Page::setVisitedLinkStore):
(WebCore::Page::setSessionID):
(WebCore::Page::clearWheelEventTestMonitor):
(WebCore::Page::startMonitoringWheelEvents):
(WebCore::Page::accessibilitySettingsDidChange):
(WebCore::Page::appearanceDidChange):
(WebCore::Page::hasLocalDataForURL):
(WebCore::dispatchPrintEvent):
(WebCore::Page::dispatchBeforePrintEvent):
(WebCore::Page::dispatchAfterPrintEvent):
(WebCore::Page::startApplePayAMSUISession):
(WebCore::Page::setMediaSessionCoordinator):
(WebCore::Page::invalidateMediaSessionCoordinator):
(WebCore::Page::didFinishLoadingImageForElement):
(WebCore::Page::recomputeTextAutoSizingInAllFrames):
(WebCore::Page::revealCurrentSelection):
(WebCore::Page::injectUserStyleSheet):
(WebCore::Page::removeInjectedUserStyleSheet):
(WebCore::Page::mainFrameDidChangeToNonInitialEmptyDocument):
(WebCore::Page::updateElementsWithTextRecognitionResults):
(WebCore::Page::serviceWorkerGlobalObject):
(WebCore::Page::setupForRemoteWorker):
(WebCore::Page::forceRepaintAllFrames):
(WebCore::Page::updatePlayStateForAllAnimations):
(WebCore::Page::reloadExecutionContextsForOrigin const):
(WebCore::Page::accessibilityRootObject const):
(WebCore::Page::setAccessibilityRootObject):
* Source/WebCore/page/Page.h:
(WebCore::Page::accessibilityRootObject const): Deleted.
(WebCore::Page::setAccessibilityRootObject): Deleted.
(WebCore::Page::group): Deleted.
* Source/WebCore/page/PageGroup.h:

Canonical link: https://commits.webkit.org/274301@main
@webkit-commit-queue
Copy link
Collaborator

Committed 274301@main (dd3340d): https://commits.webkit.org/274301@main

Reviewed commits have been landed. Closing PR #24036 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
5 participants