-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt more smart pointers in Page.cpp #24036
Adopt more smart pointers in Page.cpp #24036
Conversation
EWS run on previous version of this PR (hash b299426) |
b299426
to
3b899ea
Compare
EWS run on previous version of this PR (hash 3b899ea) |
3b899ea
to
9927661
Compare
EWS run on previous version of this PR (hash 9927661) |
9927661
to
f677778
Compare
EWS run on current version of this PR (hash f677778) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me.
https://bugs.webkit.org/show_bug.cgi?id=268938 Reviewed by Brent Fulgham. * Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.h: * Source/WebCore/dom/Document.h: * Source/WebCore/dom/DocumentInlines.h: (WebCore::Document::checkedExtensionStyleSheets): * Source/WebCore/dom/VisitedLinkState.h: * Source/WebCore/history/BackForwardController.h: * Source/WebCore/page/LocalFrameView.cpp: (WebCore::LocalFrameView::checkedRenderView const): * Source/WebCore/page/LocalFrameView.h: * Source/WebCore/page/Page.cpp: (WebCore::Page::forEachPage): (WebCore::networkStateChanged): (WebCore::m_historyItemClient): (WebCore::Page::~Page): (WebCore::Page::checkedBackForward): (WebCore::Page::clearPreviousItemFromAllPages): (WebCore::Page::renderTreeSize const): (WebCore::Page::disabledAdaptations const): (WebCore::viewportDocumentForFrame): (WebCore::Page::viewportArguments const): (WebCore::Page::setOverrideViewportArguments): (WebCore::Page::scrollingCoordinator): (WebCore::Page::scrollingStateTreeAsText): (WebCore::Page::synchronousScrollingReasonsAsText): (WebCore::Page::nonFastScrollableRectsForTesting): (WebCore::Page::touchEventRectsForEventForTesting): (WebCore::Page::passiveTouchEventListenerRectsForTesting): (WebCore::Page::accessibilityTreeData const): (WebCore::Page::progressEstimateChanged const): (WebCore::Page::progressFinished const): (WebCore::Page::goToItem): (WebCore::Page::updateStyleAfterChangeInEnvironment): (WebCore::Page::updateStyleForAllPagesAfterGlobalChangeInEnvironment): (WebCore::Page::setNeedsRecalcStyleInAllFrames): (WebCore::Page::refreshPlugins): (WebCore::Page::findString): (WebCore::Page::findTextMatches): (WebCore::Page::rangeOfString): (WebCore::Page::findMatchesForText): (WebCore::replaceRanges): (WebCore::Page::replaceSelectionWithText): (WebCore::Page::setEditableRegionEnabled): (WebCore::Page::editableElementsInRect const): (WebCore::Page::checkedFocusController const): (WebCore::Page::setInteractionRegionsEnabled): (WebCore::Page::selection const): (WebCore::Page::setDefersLoading): (WebCore::Page::setZoomedOutPageScaleFactor): (WebCore::Page::setPageScaleFactor): (WebCore::Page::setDeviceScaleFactor): (WebCore::Page::windowScreenDidChange): (WebCore::Page::setTopContentInset): (WebCore::Page::lockAllOverlayScrollbarsToHidden): (WebCore::Page::group): (WebCore::Page::setVerticalScrollElasticity): (WebCore::Page::setHorizontalScrollElasticity): (WebCore::Page::pageCount const): (WebCore::Page::pageCountAssumingLayoutIsUpToDate const): (WebCore::Page::setIsInWindowInternal): (WebCore::Page::layoutIfNeeded): (WebCore::Page::didScheduleRenderingUpdate): (WebCore::Page::updateRendering): (WebCore::Page::doAfterUpdateRendering): (WebCore::Page::finalizeRenderingUpdateForRootFrame): (WebCore::Page::renderingUpdateCompleted): (WebCore::Page::protectedOpportunisticTaskScheduler const): (WebCore::Page::willStartRenderingUpdateDisplay): (WebCore::Page::didCompleteRenderingUpdateDisplay): (WebCore::Page::didCompleteRenderingFrame): (WebCore::Page::prioritizeVisibleResources): (WebCore::Page::shouldUpdateAccessibilityRegions const): (WebCore::Page::timelineControllerMaximumAnimationFrameRateDidChange): (WebCore::Page::preferredRenderingUpdateFramesPerSecond const): (WebCore::Page::setIsVisuallyIdleInternal): (WebCore::Page::handleLowPowerModeChange): (WebCore::Page::userStyleSheetLocationChanged): (WebCore::Page::userStyleSheet const): (WebCore::Page::userAgentChanged): (WebCore::Page::invalidateStylesForAllLinks): (WebCore::Page::invalidateStylesForLink): (WebCore::Page::setDebugger): (WebCore::Page::setMemoryCacheClientCallsEnabled): (WebCore::Page::resumeAnimatingImages): (WebCore::Page::setActivityState): (WebCore::Page::stopKeyboardScrollAnimation): (WebCore::Page::setIsVisibleInternal): (WebCore::Page::setHeaderHeight): (WebCore::Page::setFooterHeight): (WebCore::Page::pageExtendedBackgroundColor const): (WebCore::Page::setUnderPageBackgroundColorOverride): (WebCore::Page::addRelevantRepaintedObject): (WebCore::Page::suspendActiveDOMObjectsAndAnimations): (WebCore::Page::resumeActiveDOMObjectsAndAnimations): (WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged): (WebCore::Page::protectedStorageNamespaceProvider const): (WebCore::Page::protectedPluginInfoProvider const): (WebCore::Page::setUserContentProvider): (WebCore::Page::protectedVisitedLinkStore): (WebCore::Page::setVisitedLinkStore): (WebCore::Page::setSessionID): (WebCore::Page::clearWheelEventTestMonitor): (WebCore::Page::startMonitoringWheelEvents): (WebCore::Page::accessibilitySettingsDidChange): (WebCore::Page::appearanceDidChange): (WebCore::Page::hasLocalDataForURL): (WebCore::dispatchPrintEvent): (WebCore::Page::dispatchBeforePrintEvent): (WebCore::Page::dispatchAfterPrintEvent): (WebCore::Page::startApplePayAMSUISession): (WebCore::Page::setMediaSessionCoordinator): (WebCore::Page::invalidateMediaSessionCoordinator): (WebCore::Page::didFinishLoadingImageForElement): (WebCore::Page::recomputeTextAutoSizingInAllFrames): (WebCore::Page::revealCurrentSelection): (WebCore::Page::injectUserStyleSheet): (WebCore::Page::removeInjectedUserStyleSheet): (WebCore::Page::mainFrameDidChangeToNonInitialEmptyDocument): (WebCore::Page::updateElementsWithTextRecognitionResults): (WebCore::Page::serviceWorkerGlobalObject): (WebCore::Page::setupForRemoteWorker): (WebCore::Page::forceRepaintAllFrames): (WebCore::Page::updatePlayStateForAllAnimations): (WebCore::Page::reloadExecutionContextsForOrigin const): (WebCore::Page::accessibilityRootObject const): (WebCore::Page::setAccessibilityRootObject): * Source/WebCore/page/Page.h: (WebCore::Page::accessibilityRootObject const): Deleted. (WebCore::Page::setAccessibilityRootObject): Deleted. (WebCore::Page::group): Deleted. * Source/WebCore/page/PageGroup.h: Canonical link: https://commits.webkit.org/274301@main
f677778
to
dd3340d
Compare
Committed 274301@main (dd3340d): https://commits.webkit.org/274301@main Reviewed commits have been landed. Closing PR #24036 and removing active labels. |
dd3340d
f677778
π§ͺ api-macπ§ͺ ios-wk2-wptπ§ͺ mac-wk2π watch