Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace member variables in APIWebsitePolicies with WebsitePoliciesData #24048

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Replace member variables in APIWebsitePolicies with WebsitePoliciesData #24048

merged 1 commit into from
Feb 8, 2024

Conversation

charliewolfe
Copy link
Member

@charliewolfe charliewolfe commented Feb 8, 2024 •
edited by webkit-early-warning-system
Loading

4407f0d

Replace member variables in APIWebsitePolicies with WebsitePoliciesData
https://bugs.webkit.org/show_bug.cgi?id=268955
rdar://122511776

Reviewed by Alex Christensen.

* Source/WebKit/Shared/WebsitePoliciesData.h:
* Source/WebKit/Shared/WebsitePoliciesData.serialization.in:
* Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp:
(API::WebsitePolicies::copy const):
(API::WebsitePolicies::data):
* Source/WebKit/UIProcess/API/APIWebsitePolicies.h:

Canonical link: https://commits.webkit.org/274291@main

a8fae0a

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@charliewolfe charliewolfe self-assigned this Feb 8, 2024
@charliewolfe charliewolfe added the WebKit API For issues and bugs in the Web Kit public embedding APIs label Feb 8, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 8, 2024 •
edited
Loading

EWS run on previous version of this PR (hash ce5ed22)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ⏳ 🛠 ios ⏳ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 wincairo
✅ 🛠 ios-sim ⏳ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2 ⏳ 🧪 api-mac ⏳ 🧪 api-wpe
⏳ 🧪 webkitpy ⏳ 🧪 ios-wk2-wpt ⏳ 🧪 mac-wk1 ⏳ 🛠 gtk
⏳ 🛠 🧪 jsc ⏳ 🧪 api-ios ⏳ 🧪 mac-wk2 ⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 api-gtk
⏳ 🛠 tv-sim ⏳ 🧪 mac-wk2-stress
⏳ 🛠 watch
⏳ 🛠 watch-sim

@charliewolfe charliewolfe force-pushed the eng/Replace-member-variables-in-APIWebsitePolicies-with-WebsitePoliciesData branch from ce5ed22 to a8fae0a Compare February 8, 2024 03:53
@charliewolfe charliewolfe added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Feb 8, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 8, 2024 •
edited
Loading

EWS run on current version of this PR (hash a8fae0a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@charliewolfe charliewolfe added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Feb 8, 2024
@charliewolfe
Replace member variables in APIWebsitePolicies with WebsitePoliciesData
4407f0d 
https://bugs.webkit.org/show_bug.cgi?id=268955
rdar://122511776

Reviewed by Alex Christensen.

* Source/WebKit/Shared/WebsitePoliciesData.h:
* Source/WebKit/Shared/WebsitePoliciesData.serialization.in:
* Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp:
(API::WebsitePolicies::copy const):
(API::WebsitePolicies::data):
* Source/WebKit/UIProcess/API/APIWebsitePolicies.h:

Canonical link: https://commits.webkit.org/274291@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Replace-member-variables-in-APIWebsitePolicies-with-WebsitePoliciesData branch from a8fae0a to 4407f0d Compare February 8, 2024 17:16
@webkit-commit-queue webkit-commit-queue merged commit 4407f0d into WebKit:main Feb 8, 2024
@webkit-commit-queue
Copy link
Collaborator

Committed 274291@main (4407f0d): https://commits.webkit.org/274291@main

Reviewed commits have been landed. Closing PR #24048 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achristensen07 achristensen07 achristensen07 approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@charliewolfe charliewolfe

Labels
WebKit API For issues and bugs in the Web Kit public embedding APIs
Projects
None yet
Milestone
No milestone
4 participants
@charliewolfe @webkit-early-warning-system @webkit-commit-queue @achristensen07