[Skia] Import the Skia source code tree #24059
Conversation
aperezdc
added
the
Tools / Tests
|
EWS run on previous version of this PR (hash 24f50ff) |
aperezdc
force-pushed
the
aperezdc/import-skia
branch
from
24f50ff
to
37a6e2b
Compare
|
EWS run on previous version of this PR (hash 37a6e2b) |
|
The GitHub PR UI is unable to handle any comments I have on this particular patch because of the size of the Skia sources. Could we maybe just land the Skia sources and then add in the build parts in a subsequent patch? |
Let's do it that way. I am repurposing this issue to land the Skia sources, and created a new Bugzilla issue for the build system integration. |
aperezdc
changed the title
aperezdc
force-pushed
the
aperezdc/import-skia
branch
from
37a6e2b
to
3086037
Compare
|
EWS run on previous version of this PR (hash 3086037)
|
|
Done, this now includes only the Skia source and the edit to the linter rules, to avoid false style checker positives for code under |
|
Should we use |
Sure thing, there is no particular reason why we picked the |
aperezdc
force-pushed
the
aperezdc/import-skia
branch
from
3086037
to
dc1441b
Compare
|
Done, now with 25% more lowercase letters in the directory name 😄 |
|
EWS run on current version of this PR (hash dc1441b) |
|
I support adopting Skia as a replacement for Cairo in Windows. This poses no issue to Apple's builds, aside from the performance hit of adding a large number of new files. Could someone explain why this must be a full import into the tree, rather than an external dependency? |
|
I spoke with Don separately -- it seems like this is similar to ANGLE or BoringSSL where we don't have a stable external versioning system we can trust to have reliable cross-project versioning. |
🙌🏼
The aim is to provide as less disruption as possible. During a discussion last week with some of the Skia maintainers they have made it clear to us that it is not in their radar to make guarantees about API/ABI stability, nor making releases of any kind. Therefore, it does not fulfill the packaging requirements for most GNU/Linux distributions, or BSD ports, and will not be available as a system dependency. Importing the source in the WebKit tree is what makes development most convenient for WebKit developers and does not require any changes in the existing infrastructure (build bots, tooling, scripts, etc.). If we were to use a different distribution mechanism for the Skia sources, we may need changes in a number of places. Moreover, the practice of shipping such dependencies under |
aperezdc
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=268974 Reviewed by Michael Catanzaro, Brent Fulgham and Don Olmstead. Import the Skia sources at commit 55e8dd4151ce562ce2e61162bf835bef16dd5162. Follow-up changes will wire building the library and initial support in the WPE port. * Source/ThirdParty/skia: Added. * Tools/Scripts/webkitpy/style/checker.py: Ignore most of the rules for ThirdParty/skia. Canonical link: https://commits.webkit.org/274314@main
webkit-commit-queue
force-pushed
the
aperezdc/import-skia
branch
from
dc1441b
to
a69ccc8
Compare
|
Committed 274314@main (a69ccc8): https://commits.webkit.org/274314@main Reviewed commits have been landed. Closing PR #24059 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
a69ccc8
dc1441b
🧪 style🛠 ios🛠 mac🛠 wpe🛠 wincairo🧪 bindings🛠 ios-sim🛠 mac-AS-debug🧪 wpe-wk2🧪 webkitperl🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🛠 gtk🛠 🧪 jsc🧪 api-ios🧪 mac-wk2🧪 gtk-wk2🛠 🧪 jsc-arm64🛠 tv🧪 mac-AS-debug-wk2🧪 api-gtk🛠 tv-sim🧪 mac-wk2-stress🛠 jsc-armv7🛠 watch🧪 jsc-armv7-tests🛠 watch-sim