Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GTK] Only implement GtkAccessible in recent versions #24066

Conversation

GeorgesStavracas
Copy link
Contributor

@GeorgesStavracas GeorgesStavracas commented Feb 8, 2024

4aa6d21

[GTK] Only implement GtkAccessible in recent versions
https://bugs.webkit.org/show_bug.cgi?id=227528

Reviewed by Adrian Perez de Castro.

GtkAccessible is only publicly exposed as an externally implementable
interface since GTK 4.10, but Ubuntu 22.04 ships with GTK4 4.6. This
breaks the build.

Conditionally implement this interface based on the availability of
the GTK_ACCESSIBILITY_ATSPI define.

* Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseAccessibleGetFirstAccessibleChild):

Canonical link: https://commits.webkit.org/274284@main

ee5991a

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2   πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
  πŸ§ͺ ios-wk2-wpt βœ… πŸ›  gtk
βœ… πŸ§ͺ api-ios   πŸ§ͺ mac-wk2   πŸ§ͺ gtk-wk2
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv-sim
  πŸ›  watch
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim

@GeorgesStavracas GeorgesStavracas requested a review from a team as a code owner February 8, 2024 14:14
@GeorgesStavracas GeorgesStavracas self-assigned this Feb 8, 2024
@aperezdc aperezdc added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 8, 2024
https://bugs.webkit.org/show_bug.cgi?id=227528

Reviewed by Adrian Perez de Castro.

GtkAccessible is only publicly exposed as an externally implementable
interface since GTK 4.10, but Ubuntu 22.04 ships with GTK4 4.6. This
breaks the build.

Conditionally implement this interface based on the availability of
the GTK_ACCESSIBILITY_ATSPI define.

* Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseAccessibleGetFirstAccessibleChild):

Canonical link: https://commits.webkit.org/274284@main
@webkit-commit-queue
Copy link
Collaborator

Committed 274284@main (4aa6d21): https://commits.webkit.org/274284@main

Reviewed commits have been landed. Closing PR #24066 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 4aa6d21 into WebKit:main Feb 8, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 8, 2024
@GeorgesStavracas GeorgesStavracas deleted the eng/GTK-Support-a11y-with-GTK-4 branch February 8, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility For bugs related to accessibility.
Projects
None yet
4 participants