Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align ShadowRealm WPT expectations with reality #24082

Conversation

annevk
Copy link
Contributor

@annevk annevk commented Feb 8, 2024

68eb043

Align ShadowRealm WPT expectations with reality
https://bugs.webkit.org/show_bug.cgi?id=268998

Reviewed by Yusuke Suzuki.

These have been a constant source of annoyance when synchronizing with
WPT.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/compression/idlharness-shadowrealm.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/idlharness-shadowrealm.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/encoding/idlharness-shadowrealm.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/hr-time/idlharness-shadowrealm.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness-shadowrealm.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/performance-timeline/idlharness-shadowrealm.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/idlharness-shadowrealm.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/user-timing/idlharness-shadowrealm.window-expected.txt:

Canonical link: https://commits.webkit.org/274345@main

1f52d57

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac loading πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 loading πŸ›  gtk
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv-sim
βœ… πŸ›  watch
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim

@annevk annevk self-assigned this Feb 8, 2024
@annevk annevk added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Feb 8, 2024
@annevk
Copy link
Contributor Author

annevk commented Feb 8, 2024

@Constellation asking you for review as you created the status quo with 06acbb8. It's been a bit annoying as each time I'd synchronize url/ or dom/ and then use run-webkit-tests --reset-results the expectations file would change and reviewers would assume there are regressions or some such.

@annevk annevk requested a review from cdumez February 8, 2024 18:10
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@annevk annevk added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 9, 2024
https://bugs.webkit.org/show_bug.cgi?id=268998

Reviewed by Yusuke Suzuki.

These have been a constant source of annoyance when synchronizing with
WPT.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/compression/idlharness-shadowrealm.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/idlharness-shadowrealm.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/encoding/idlharness-shadowrealm.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/hr-time/idlharness-shadowrealm.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness-shadowrealm.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/performance-timeline/idlharness-shadowrealm.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/idlharness-shadowrealm.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/user-timing/idlharness-shadowrealm.window-expected.txt:

Canonical link: https://commits.webkit.org/274345@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Align-ShadowRealm-WPT-expectations-with-reality branch from 1f52d57 to 68eb043 Compare February 9, 2024 06:48
@webkit-commit-queue
Copy link
Collaborator

Committed 274345@main (68eb043): https://commits.webkit.org/274345@main

Reviewed commits have been landed. Closing PR #24082 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 68eb043 into WebKit:main Feb 9, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 9, 2024
@annevk annevk deleted the eng/Align-ShadowRealm-WPT-expectations-with-reality branch February 9, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
4 participants