Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix the WebHeapAgent build #24118

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Try to fix the WebHeapAgent build #24118

merged 1 commit into from
Feb 9, 2024

Conversation

hortont424
Copy link
Contributor

@hortont424 hortont424 commented Feb 9, 2024 •
edited by webkit-early-warning-system
Loading

@hortont424 hortont424 self-assigned this Feb 9, 2024
@hortont424 hortont424 added the Web Inspector Bugs related to the WebKit Web Inspector. label Feb 9, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 9, 2024 •
edited
Loading

EWS run on current version of this PR (hash 76ac5ec)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios   🛠 mac   🛠 wpe   🛠 wincairo
✅ 🧪 bindings   🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 gtk
  🧪 api-ios   🧪 mac-wk2   🧪 gtk-wk2
  🛠 tv   🧪 mac-AS-debug-wk2   🧪 api-gtk
  🛠 tv-sim   🧪 mac-wk2-stress
  🛠 watch
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

@hortont424 hortont424 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 9, 2024
@hortont424
Try to fix the WebHeapAgent build
7f0730e 
https://bugs.webkit.org/show_bug.cgi?id=269037

Unreviewed speculative build fix.

* Source/WebCore/inspector/agents/WebHeapAgent.cpp:

Canonical link: https://commits.webkit.org/274335@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Try-to-fix-the-WebHeapAgent-build branch from 76ac5ec to 7f0730e Compare February 9, 2024 02:01
@webkit-commit-queue
Copy link
Collaborator

Committed 274335@main (7f0730e): https://commits.webkit.org/274335@main

Reviewed commits have been landed. Closing PR #24118 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 7f0730e into WebKit:main Feb 9, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcrousso dcrousso Awaiting requested review from dcrousso dcrousso is a code owner

@patrickangle patrickangle Awaiting requested review from patrickangle patrickangle is a code owner

Assignees

@hortont424 hortont424

Labels
Web Inspector Bugs related to the WebKit Web Inspector.
Projects
None yet
Milestone
No milestone
3 participants
@hortont424 @webkit-early-warning-system @webkit-commit-queue