Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WGSL] Validate that resources do not collide #24156

Conversation

tadeuzagallo
Copy link
Member

@tadeuzagallo tadeuzagallo commented Feb 9, 2024

5623935

[WGSL] Validate that resources do not collide
https://bugs.webkit.org/show_bug.cgi?id=269078
rdar://122652489

Reviewed by Mike Wyrzykowski.

The goal was to fix shader,validation,decl,var:binding_collisions:*, but in order
to pass that test this validation needs to during during shader creation time, while
we current run it at pipeline creation time. However, moving the validation requires
a significantly larger change, which will happen later, but this seemed like a
worthwhile validation to have in the meantime.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::visitEntryPoint):
(WGSL::RewriteGlobalVariables::determineUsedGlobals):

Canonical link: https://commits.webkit.org/274459@main

7723f79

Misc iOS, tvOS & watchOS macOS Linux Windows
⏳ πŸ§ͺ style ⏳ πŸ›  ios ⏳ πŸ›  mac ⏳ πŸ›  wpe ⏳ πŸ›  wincairo
⏳ πŸ§ͺ bindings ⏳ πŸ›  ios-sim ⏳ πŸ›  mac-AS-debug ⏳ πŸ§ͺ wpe-wk2
⏳ πŸ§ͺ webkitperl ⏳ πŸ§ͺ ios-wk2 ⏳ πŸ§ͺ api-mac ⏳ πŸ§ͺ api-wpe
⏳ πŸ§ͺ webkitpy ⏳ πŸ§ͺ ios-wk2-wpt ⏳ πŸ§ͺ mac-wk1 ⏳ πŸ›  gtk
⏳ πŸ›  πŸ§ͺ jsc ⏳ πŸ§ͺ api-ios ⏳ πŸ§ͺ mac-wk2 ⏳ πŸ§ͺ gtk-wk2
⏳ πŸ›  πŸ§ͺ jsc-arm64 ⏳ πŸ›  tv ⏳ πŸ§ͺ mac-AS-debug-wk2 ⏳ πŸ§ͺ api-gtk
⏳ πŸ§ͺ services ⏳ πŸ›  tv-sim ⏳ πŸ§ͺ mac-wk2-stress ⏳ πŸ›  jsc-armv7
βœ… πŸ›  πŸ§ͺ merge ⏳ πŸ›  watch ⏳ πŸ§ͺ jsc-armv7-tests
⏳ πŸ›  watch-sim

@tadeuzagallo tadeuzagallo self-assigned this Feb 9, 2024
@tadeuzagallo tadeuzagallo added the WebGPU For bugs in WebGPU label Feb 9, 2024
@tadeuzagallo tadeuzagallo added the merge-queue Applied to send a pull request to merge-queue label Feb 12, 2024
https://bugs.webkit.org/show_bug.cgi?id=269078
rdar://122652489

Reviewed by Mike Wyrzykowski.

The goal was to fix shader,validation,decl,var:binding_collisions:*, but in order
to pass that test this validation needs to during during shader creation time, while
we current run it at pipeline creation time. However, moving the validation requires
a significantly larger change, which will happen later, but this seemed like a
worthwhile validation to have in the meantime.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::visitEntryPoint):
(WGSL::RewriteGlobalVariables::determineUsedGlobals):

Canonical link: https://commits.webkit.org/274459@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WGSL-Validate-that-resources-do-not-collide branch from 7723f79 to 5623935 Compare February 12, 2024 16:29
@webkit-commit-queue
Copy link
Collaborator

Committed 274459@main (5623935): https://commits.webkit.org/274459@main

Reviewed commits have been landed. Closing PR #24156 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 5623935 into WebKit:main Feb 12, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebGPU For bugs in WebGPU
Projects
None yet
3 participants