Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-webkit: Add a new --skia command line option #24252

Merged

Conversation

@aperezdc aperezdc self-assigned this Feb 12, 2024
@aperezdc aperezdc added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Feb 12, 2024
@aperezdc aperezdc requested review from donny-dont and a team February 12, 2024 16:00
Copy link
Contributor

@mcatanzaro mcatanzaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, though if it's temporary you might as well just use --cmakeargs='-DUSE_SKIA=ON'

@donny-dont
Copy link
Contributor

OK, though if it's temporary you might as well just use --cmakeargs='-DUSE_SKIA=ON'

It will probably get some more mileage with the PS and Windows ports

@aperezdc aperezdc added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 12, 2024
https://bugs.webkit.org/show_bug.cgi?id=269092

Reviewed by Michael Catanzaro.

* Tools/Scripts/webkitperl/FeatureList.pm: Add support for --skia.

Canonical link: https://commits.webkit.org/274473@main
@webkit-commit-queue
Copy link
Collaborator

Committed 274473@main (bf57264): https://commits.webkit.org/274473@main

Reviewed commits have been landed. Closing PR #24252 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit bf57264 into WebKit:main Feb 12, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
5 participants