Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceBuffer.h:153:11: error: unknown type name 'Settings' #24306

Conversation

@jyavenard jyavenard self-assigned this Feb 13, 2024
@jyavenard jyavenard added the Media Bugs related to the HTML 5 Media elements. label Feb 13, 2024
@jyavenard jyavenard force-pushed the eng/SourceBuffer-h15311-error-unknown-type-name-Settings branch from c73b952 to 53841fe Compare February 13, 2024 02:25
@jyavenard jyavenard added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 13, 2024
https://bugs.webkit.org/show_bug.cgi?id=269259
rdar://122843557

Unreviewed build fix.

Add Settings forward declaration.

* Source/WebCore/Modules/mediasource/SourceBuffer.h:

Canonical link: https://commits.webkit.org/274513@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/SourceBuffer-h15311-error-unknown-type-name-Settings branch from 53841fe to fa279f3 Compare February 13, 2024 02:29
@webkit-commit-queue
Copy link
Collaborator

Committed 274513@main (fa279f3): https://commits.webkit.org/274513@main

Reviewed commits have been landed. Closing PR #24306 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit fa279f3 into WebKit:main Feb 13, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 13, 2024
@jyavenard jyavenard deleted the eng/SourceBuffer-h15311-error-unknown-type-name-Settings branch February 26, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
3 participants