-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebXR] Remove texture size from createAndBindEGLImage result #24328
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
djg:eng/webxr/refactor-eglimage
Feb 15, 2024
Merged
[WebXR] Remove texture size from createAndBindEGLImage result #24328
webkit-commit-queue
merged 1 commit into
WebKit:main
from
djg:eng/webxr/refactor-eglimage
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash 47c37e2) |
djg
requested review from
kkinnunen-apple and
mwyrzykowski
and removed request for
cdumez and
JonWBedard
February 13, 2024 09:22
djg
force-pushed
the
eng/webxr/refactor-eglimage
branch
from
February 13, 2024 09:24
47c37e2
to
ba35dfb
Compare
djg
changed the title
[Web
[WebXR] Remove texture size from createAndBindEGLImage result
Feb 13, 2024
EWS run on previous version of this PR (hash ba35dfb) |
mwyrzykowski
approved these changes
Feb 13, 2024
djg
force-pushed
the
eng/webxr/refactor-eglimage
branch
from
February 14, 2024 01:48
ba35dfb
to
81b639a
Compare
EWS run on previous version of this PR (hash 81b639a) |
djg
force-pushed
the
eng/webxr/refactor-eglimage
branch
from
February 14, 2024 02:15
81b639a
to
20ccd43
Compare
EWS run on current version of this PR (hash 20ccd43) |
webkit-commit-queue
force-pushed
the
eng/webxr/refactor-eglimage
branch
from
February 15, 2024 01:14
20ccd43
to
dcf5925
Compare
https://bugs.webkit.org/show_bug.cgi?id=269280 rdar://122857763 Reviewed by Mike Wyrzykowski. Don't return the size of external image from createAndBindEGLImage. The size of the framebuffer and external images are already known by the calling code. * Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp: (WebCore::createAndBindCompositorTexture): (WebCore::createAndBindCompositorBuffer): (WebCore::WebXROpaqueFramebuffer::startFrame): * Source/WebCore/platform/graphics/GraphicsContextGL.h: * Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp: (WebCore::GraphicsContextGLANGLE::createAndBindEGLImage): * Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h: * Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.h: * Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm: (WebCore::GraphicsContextGLCocoa::createAndBindEGLImage): * Source/WebCore/platform/xr/PlatformXR.h: * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp: (WebKit::RemoteGraphicsContextGL::createAndBindEGLImage): * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h: * Source/WebKit/Shared/XR/PlatformXR.serialization.in: * Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp: (WebKit::RemoteGraphicsContextGLProxy::createAndBindEGLImage): * Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h: * Source/WebKit/WebProcess/GPU/graphics/cocoa/RemoteGraphicsContextGLProxyCocoa.mm: Canonical link: https://commits.webkit.org/274682@main
webkit-commit-queue
force-pushed
the
eng/webxr/refactor-eglimage
branch
from
February 15, 2024 01:16
dcf5925
to
cf4012b
Compare
Committed 274682@main (cf4012b): https://commits.webkit.org/274682@main Reviewed commits have been landed. Closing PR #24328 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf4012b
20ccd43