Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WGSL] Array elements must be constructible #24360

Conversation

@tadeuzagallo tadeuzagallo self-assigned this Feb 13, 2024
@tadeuzagallo tadeuzagallo added the WebGPU For bugs in WebGPU label Feb 13, 2024
@tadeuzagallo tadeuzagallo added the merge-queue Applied to send a pull request to merge-queue label Feb 14, 2024
https://bugs.webkit.org/show_bug.cgi?id=269309
rdar://122293571

Reviewed by Mike Wyrzykowski.

Check that array element type is constructible.

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):

Canonical link: https://commits.webkit.org/274617@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WGSL-Array-elements-must-be-constructible branch from ce562dc to 26862e8 Compare February 14, 2024 10:47
@webkit-commit-queue
Copy link
Collaborator

Committed 274617@main (26862e8): https://commits.webkit.org/274617@main

Reviewed commits have been landed. Closing PR #24360 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 26862e8 into WebKit:main Feb 14, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebGPU For bugs in WebGPU
Projects
None yet
4 participants