Crash under ~RenderMenuList due to CheckedPtr usage #24372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdumez
added
the
Layout and Rendering
|
EWS run on current version of this PR (hash 78fdddf)
|
alanbaradlay
approved these changes
Feb 13, 2024
cdumez
added
merge-queue
https://bugs.webkit.org/show_bug.cgi?id=269322 rdar://119790256 Reviewed by Alan Baradlay. From the crash trace, we can see that HTMLSelectElement::defaultEventHandler() holds a CheckedPtr to its RenderMenuList renderer and calls showPopup() on the renderer. This ends up running JS, which removes the select element from the DOM and in turns destroys the renderer. The usage is currently safe since nothing is using the renderer after the JS has run. However, it was tripping the CheckedPtr assertion. To address the issue, switch to using WeakPtr for now and add comments to clarify lifetime. We should consider refactoring this in a follow up though. * Source/WebCore/html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::platformHandleKeydownEvent): (WebCore::HTMLSelectElement::menuListDefaultEventHandler): (WebCore::HTMLSelectElement::showPicker): * Source/WebCore/rendering/RenderMenuList.cpp: (RenderMenuList::showPopup): Canonical link: https://commits.webkit.org/274586@main
webkit-commit-queue
force-pushed
the
269322_RenderMenuList_crash
branch
from
78fdddf
to
35318b4
Compare
|
Committed 274586@main (35318b4): https://commits.webkit.org/274586@main Reviewed commits have been landed. Closing PR #24372 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
35318b4
78fdddf
🛠 wincairo🧪 wpe-wk2🧪 api-wpe🧪 ios-wk2-wpt🧪 gtk-wk2🛠 tv🧪 mac-AS-debug-wk2🧪 api-gtk🛠 tv-sim🛠 🧪 merge🛠 watch🛠 watch-sim