Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid] Enable masonry feature flag #24414

Merged
merged 1 commit into from Feb 14, 2024

Conversation

@stwrt stwrt self-assigned this Feb 14, 2024
@stwrt stwrt added the CSS Cascading Style Sheets implementation label Feb 14, 2024
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, suggest enabling WKL, too.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 14, 2024
@stwrt stwrt added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Feb 14, 2024
https://bugs.webkit.org/show_bug.cgi?id=247074
rdar://101595681

Reviewed by Tim Nguyen and Brent Fulgham.

Enable masonry by default on platforms.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/274661@main
@webkit-commit-queue
Copy link
Collaborator

Committed 274661@main (8046191): https://commits.webkit.org/274661@main

Reviewed commits have been landed. Closing PR #24414 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 8046191 into WebKit:main Feb 14, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 14, 2024
@Loirooriol
Copy link
Contributor

Loirooriol commented Feb 22, 2024

But it doesn't seem stable enough? Like I don't think the CSSWG resolved on whether masonry should be built on top of grid or be an independent layout. w3c/csswg-drafts#9041 wants to discuss alternative paths forward. w3c/csswg-drafts#9733 may even rename "masonry" to something else.

So I don't understand enabling it by default.

@nt1m
Copy link
Member

nt1m commented Feb 22, 2024

Please don't read too much into feature flag states :)

@brentfulgham
Copy link
Contributor

There are a variety of reasons why we sometimes activate a feature in our unreleased code base that are not because we are about to ship the feature. When we plan to ship in production builds to Apple platforms we will indicate that in our release notes. Until then, monitoring our source repository is a very bad way to guess what we will actually ship.

If it makes you feel better, we could conditionalize this on Cocoa ports to avoid impacting other platforms.

@Loirooriol
Copy link
Contributor

Yes, even if you don't ship it in Safari, I don't think this should be enabled by default in WebKitGTK or such.

@brentfulgham
Copy link
Contributor

@Loirooriol Please see #24972

@stwrt stwrt deleted the eng/enable_masonry branch February 28, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Cascading Style Sheets implementation
Projects
None yet
7 participants