New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-grid] Enable masonry feature flag #24414
Conversation
EWS run on previous version of this PR (hash ebef83e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, suggest enabling WKL, too.
ebef83e
to
32311df
Compare
EWS run on current version of this PR (hash 32311df) |
https://bugs.webkit.org/show_bug.cgi?id=247074 rdar://101595681 Reviewed by Tim Nguyen and Brent Fulgham. Enable masonry by default on platforms. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/274661@main
32311df
to
8046191
Compare
Committed 274661@main (8046191): https://commits.webkit.org/274661@main Reviewed commits have been landed. Closing PR #24414 and removing active labels. |
But it doesn't seem stable enough? Like I don't think the CSSWG resolved on whether masonry should be built on top of grid or be an independent layout. w3c/csswg-drafts#9041 wants to discuss alternative paths forward. w3c/csswg-drafts#9733 may even rename "masonry" to something else. So I don't understand enabling it by default. |
Please don't read too much into feature flag states :) |
There are a variety of reasons why we sometimes activate a feature in our unreleased code base that are not because we are about to ship the feature. When we plan to ship in production builds to Apple platforms we will indicate that in our release notes. Until then, monitoring our source repository is a very bad way to guess what we will actually ship. If it makes you feel better, we could conditionalize this on Cocoa ports to avoid impacting other platforms. |
Yes, even if you don't ship it in Safari, I don't think this should be enabled by default in WebKitGTK or such. |
@Loirooriol Please see #24972 |
8046191
32311df
π§ͺ jsc-armv7-tests