Add support for the devtools.network.onNavigated Web Extension event. #24442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash 29030d4)
|
xeenon
requested review from
burg,
davidjohnson91,
jeffmapple and
kiaraarose
burg
approved these changes
Feb 14, 2024
xeenon
added
the
unsafe-merge-queue
https://webkit.org/b/246485 rdar://problem/114823326 Reviewed by BJ Burg. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::loadInspectorBackgroundPage): Connect client to inspectedPageDidNavigate. (WebKit::WebExtensionContext::inspectedPageDidNavigate): Added. * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIDevToolsNetworkCocoa.mm: (WebKit::WebExtensionContextProxy::dispatchDevToolsNetworkNavigatedEvent): * Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h: * Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.messages.in: * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDevTools.mm: (TEST(WKWebExtensionAPIDevTools, NetworkNavigatedEvent)): Added. Canonical link: https://commits.webkit.org/274649@main
webkit-commit-queue
force-pushed
the
bug/246485
branch
from
29030d4
to
886077e
Compare
|
Committed 274649@main (886077e): https://commits.webkit.org/274649@main Reviewed commits have been landed. Closing PR #24442 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
886077e
29030d4
🛠 wincairo🧪 wpe-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🧪 mac-wk2🧪 gtk-wk2🛠 tv🧪 mac-AS-debug-wk2🧪 api-gtk🛠 watch🛠 watch-sim