-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for themeName and onThemeChanged for devtools Web Extensions. #24477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeenon
requested review from
burg,
davidjohnson91,
jeffmapple and
kiaraarose
February 15, 2024 01:58
xeenon
changed the title
Add support for the
Add support for themeName and onThemeChanged for devtools Web Extensions.
Feb 15, 2024
EWS run on previous version of this PR (hash 1bb5349) |
EWS run on current version of this PR (hash 6f6377d) |
b-weinstein
approved these changes
Feb 15, 2024
xeenon
added
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Feb 15, 2024
β¦ons. https://webkit.org/b/246485 rdar://problem/114823326 Reviewed by Brian Weinstein. * Source/WebKit/Scripts/webkit/messages.py: (types_that_cannot_be_forward_declared): (headers_for_type): * Source/WebKit/Shared/InspectorExtensionTypes.h: * Source/WebKit/Shared/InspectorExtensionTypes.serialization.in: * Source/WebKit/UIProcess/API/APIInspectorExtensionClient.h: (API::InspectorExtensionClient::effectiveAppearanceDidChange): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::loadInspectorBackgroundPage): Hook up the new client function. (WebKit::WebExtensionContext::inspectorEffectiveAppearanceDidChange): Added. * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: * Source/WebKit/UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.cpp: (WebKit::WebInspectorUIExtensionControllerProxy::effectiveAppearanceDidChange): Added. * Source/WebKit/UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.h: * Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp: (WebKit::WebInspectorUIProxy::effectiveAppearanceDidChange): Added. * Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h: * Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.messages.in: * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIDevToolsPanelsCocoa.mm: (WebKit::WebExtensionAPIDevToolsPanels::themeName): Implemneted. (WebKit::WebExtensionContextProxy::dispatchDevToolsPanelsThemeChangedEvent): * Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIDevToolsPanels.h: (WebKit::WebExtensionAPIDevToolsPanels::theme const): Added. (WebKit::WebExtensionAPIDevToolsPanels::setTheme): Added. * Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h: * Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.messages.in: * Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp: (WebKit::WebInspectorUI::effectiveAppearanceDidChange): Added. * Source/WebKit/WebProcess/Inspector/WebInspectorUI.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::effectiveAppearanceDidChange): Added. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDevTools.mm: (TEST(WKWebExtensionAPIDevTools, PanelsThemeName)): Added. Canonical link: https://commits.webkit.org/274703@main
webkit-commit-queue
force-pushed
the
bug/246485
branch
from
February 15, 2024 09:04
6f6377d
to
ec5b316
Compare
Committed 274703@main (ec5b316): https://commits.webkit.org/274703@main Reviewed commits have been landed. Closing PR #24477 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ec5b316
6f6377d
π§ͺ api-gtk