Fix the internal build with recent SDKs - InspectorBackendDispatcher::getPropertyValue() is a weak external symbol #24667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprotyas
added
the
WebKit Misc.
|
EWS run on current version of this PR (hash 7b13914) |
|
I'll merge-queue out of caution. Only a few of us have hit this at-desk, so it's better to not break the existing build in rush to land this. |
…:getPropertyValue() is a weak external symbol https://bugs.webkit.org/show_bug.cgi?id=269622 rdar://123120005 Unreviewed build fix. With recent SDKs, we were getting this build error on multiple platforms: ``` ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library. ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file. ERROR: symbol __ZN9Inspector17BackendDispatcher16getPropertyValueINSt3__18optionalIbEEEET_PN3WTF8JSONImpl6ObjectERKNS6_6StringEbNS2_8functionIFS5_RNS7_5ValueEEEEPKc ERROR: symbol __ZN9Inspector17BackendDispatcher16getPropertyValueINSt3__18optionalIdEEEET_PN3WTF8JSONImpl6ObjectERKNS6_6StringEbNS2_8functionIFS5_RNS7_5ValueEEEEPKc ERROR: symbol __ZN9Inspector17BackendDispatcher16getPropertyValueINSt3__18optionalIiEEEET_PN3WTF8JSONImpl6ObjectERKNS6_6StringEbNS2_8functionIFS5_RNS7_5ValueEEEEPKc ``` This patch adresses the issue by specifying hidden visibility for said symbol. * Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h: Canonical link: https://commits.webkit.org/274901@main
webkit-commit-queue
force-pushed
the
eng/269622
branch
from
7b13914
to
790c37c
Compare
|
Committed 274901@main (790c37c): https://commits.webkit.org/274901@main Reviewed commits have been landed. Closing PR #24667 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
790c37c
7b13914
🛠 wincairo🧪 wpe-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🛠 🧪 jsc🧪 api-ios🧪 mac-wk2🧪 gtk-wk2🛠 tv🧪 mac-AS-debug-wk2🧪 api-gtk🛠 tv-sim🛠 watch🛠 watch-sim