Remove ApplicationCache code from WebKit #24669

szewai · 2024-02-17T01:10:10Z

`bcbd49c`

Remove ApplicationCache code from WebKit
https://bugs.webkit.org/show_bug.cgi?id=269629
rdar://123123740

Reviewed by Alex Christensen.

Also, clean up AppCache data left on disk when WebsiteDataStore resolves directories.

* Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::cacheForMainRequest):
(WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest):
(WebCore::ApplicationCacheGroup::selectCache):
(WebCore::ApplicationCacheGroup::didReachMaxAppCacheSize):
(WebCore::ApplicationCacheGroup::recalculateAvailableSpaceInQuota):
* Source/WebCore/page/ChromeClient.h:
(WebCore::ChromeClient::reachedMaxAppCacheSize):
(WebCore::ChromeClient::reachedApplicationCacheOriginQuota):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::Page):
* Source/WebCore/page/Page.h:
(WebCore::Page::applicationCacheStorage):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setApplicationCacheOriginQuota):
* Source/WebKit/Shared/WebProcessDataStoreParameters.h:
* Source/WebKit/Shared/WebProcessDataStoreParameters.serialization.in:
* Source/WebKit/UIProcess/API/APIUIClient.h:
(API::UIClient::exceededDatabaseQuota):
(API::UIClient::reachedApplicationCacheOriginQuota): Deleted.
* Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.cpp:
(WKContextConfigurationCopyApplicationCacheDirectory): Deleted.
(WKContextConfigurationSetApplicationCacheDirectory): Deleted.
* Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h:
* Source/WebKit/UIProcess/Cocoa/UIDelegate.h:
* Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::reachedApplicationCacheOriginQuota): Deleted.
* Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::bubblewrapSpawn):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reachedApplicationCacheOriginQuota): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::webProcessDataStoreParameters):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary):
(WebKit::WebsiteDataStore::fetchDataAndApply):
(WebKit::WebsiteDataStore::removeData):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::resolvedCacheStorageDirectory const):
(WebKit::WebsiteDataStore::applicationCacheFlatFileSubdirectoryName const): Deleted.
(WebKit::WebsiteDataStore::resolvedApplicationCacheDirectory const): Deleted.
* Source/WebKit/UIProcess/glib/WebProcessProxyGLib.cpp:
(WebKit::WebProcessProxy::platformGetLaunchOptions):
* Source/WebKit/WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h:
(API::InjectedBundle::PageUIClient::didReachApplicationCacheOriginQuota): Deleted.
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageClearApplicationCache):
(WKBundlePageClearApplicationCacheForOrigin):
(WKBundlePageSetAppCacheMaximumSize):
(WKBundlePageGetAppCacheUsageForOrigin):
(WKBundlePageCopyOriginsWithApplicationCache):
(WKBundlePageSetApplicationCacheOriginQuota): Deleted.
(WKBundlePageResetApplicationCacheOriginQuota): Deleted.
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
* Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:
* Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::didReachApplicationCacheOriginQuota): Deleted.
* Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
* Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoad):
* Source/WebKit/WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::willSendRequest):
(WebKit::WebResourceLoader::didReceiveResponse):
(WebKit::WebResourceLoader::didFailResourceLoad):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::reachedMaxAppCacheSize): Deleted.
(WebKit::WebChromeClient::reachedApplicationCacheOriginQuota): Deleted.
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_unifiedTextReplacementController):
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setWebsiteDataStoreParameters):
(WebKit::WebProcess::didClose):
* Source/WebKit/WebProcess/WebProcess.h:
(WebKit::WebProcess::applicationCacheStorage): Deleted.
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformSetWebsiteDataStoreParameters):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
(TEST):
* Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::disallowIncreaseForApplicationCacheQuota): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
(WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota): Deleted.

Canonical link: https://commits.webkit.org/275114@main

05f7af7

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-02-17T01:14:13Z

EWS run on previous version of this PR (hash 49ebbd4)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 wincairo~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	~~🛠 gtk~~
	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	~~🧪 gtk-wk2~~
	~~🛠 tv~~	⏳ 🧪 mac-AS-debug-wk2	~~🧪 api-gtk~~
	~~🛠 tv-sim~~	~~🧪 mac-wk2-stress~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-02-17T01:31:10Z

EWS run on previous version of this PR (hash a7431cc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	~~🧪 api-mac~~	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🛠 gtk
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-02-19T19:56:46Z

EWS run on previous version of this PR (hash 07e5b4f)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	~~🧪 api-mac~~	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-02-20T00:28:31Z

EWS run on previous version of this PR (hash fe33951)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
🛠 🧪 jsc	❌ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

cdumez · 2024-02-20T17:52:02Z

API test failure looks real.

achristensen07 · 2024-02-20T17:53:07Z

Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h

@@ -129,7 +129,6 @@ WK_EXPORT void WKBundlePageClearApplicationCache(WKBundlePageRef page);
 WK_EXPORT void WKBundlePageClearApplicationCacheForOrigin(WKBundlePageRef page, WKStringRef origin);
 WK_EXPORT void WKBundlePageSetAppCacheMaximumSize(WKBundlePageRef page, uint64_t size);
 WK_EXPORT uint64_t WKBundlePageGetAppCacheUsageForOrigin(WKBundlePageRef page, WKStringRef origin);
-WK_EXPORT void WKBundlePageSetApplicationCacheOriginQuota(WKBundlePageRef page, WKStringRef origin, uint64_t bytes);
 WK_EXPORT void WKBundlePageResetApplicationCacheOriginQuota(WKBundlePageRef page, WKStringRef origin);


Why not deprecate or remove this?

I remove the ones that are not in use. Some of them are still in use by WebKitTestRunner, I will modify tests and remove the rest in followup.

achristensen07 · 2024-02-20T17:53:24Z

Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h

@@ -102,7 +102,7 @@ typedef struct WKBundlePageUIClientV1 {
    WKBundlePageToolbarsAreVisibleCallback                              toolbarsAreVisible;

    // Version 1.
-    WKBundlePageReachedAppCacheOriginQuotaCallback                      didReachApplicationCacheOriginQuota;
+    void*                                                               unused3;


Let's not change the type or name of this.

achristensen07 · 2024-02-20T17:53:58Z

Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp

@@ -461,6 +458,14 @@ void WebsiteDataStore::resolveDirectoriesIfNecessary()
            FileSystem::deleteEmptyDirectory(webSQLDirectory);
        });
    }
+
+    if (auto applicationCacheDirectory = m_configuration->applicationCacheDirectory(); !applicationCacheDirectory.isEmpty()) {


Why are we adding this?

To clear the stale data left on disk

webkit-early-warning-system · 2024-02-20T21:38:01Z

EWS run on current version of this PR (hash 05f7af7)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

achristensen07

Looks like a good start.

achristensen07 · 2024-02-21T17:35:09Z

Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp

-void WKBundlePageResetApplicationCacheOriginQuota(WKBundlePageRef page, WKStringRef origin)
-{
-    WebKit::toImpl(page)->corePage()->applicationCacheStorage().storeUpdatedQuotaForOrigin(WebCore::SecurityOrigin::createFromString(WebKit::toImpl(origin)->string()).ptr(), WebKit::toImpl(page)->corePage()->applicationCacheStorage().defaultOriginQuota());
+    return 0;
 }

 WKArrayRef WKBundlePageCopyOriginsWithApplicationCache(WKBundlePageRef page)


We should deprecate and eventually remove these too.

https://bugs.webkit.org/show_bug.cgi?id=269629 rdar://123123740 Reviewed by Alex Christensen. Also, clean up AppCache data left on disk when WebsiteDataStore resolves directories. * Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::cacheForMainRequest): (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest): (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::didReachMaxAppCacheSize): (WebCore::ApplicationCacheGroup::recalculateAvailableSpaceInQuota): * Source/WebCore/page/ChromeClient.h: (WebCore::ChromeClient::reachedMaxAppCacheSize): (WebCore::ChromeClient::reachedApplicationCacheOriginQuota): * Source/WebCore/page/Page.cpp: (WebCore::Page::Page): * Source/WebCore/page/Page.h: (WebCore::Page::applicationCacheStorage): * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::resetToConsistentState): (WebCore::Internals::setApplicationCacheOriginQuota): * Source/WebKit/Shared/WebProcessDataStoreParameters.h: * Source/WebKit/Shared/WebProcessDataStoreParameters.serialization.in: * Source/WebKit/UIProcess/API/APIUIClient.h: (API::UIClient::exceededDatabaseQuota): (API::UIClient::reachedApplicationCacheOriginQuota): Deleted. * Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.cpp: (WKContextConfigurationCopyApplicationCacheDirectory): Deleted. (WKContextConfigurationSetApplicationCacheDirectory): Deleted. * Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h: * Source/WebKit/UIProcess/Cocoa/UIDelegate.h: * Source/WebKit/UIProcess/Cocoa/UIDelegate.mm: (WebKit::UIDelegate::UIClient::reachedApplicationCacheOriginQuota): Deleted. * Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp: (WebKit::bubblewrapSpawn): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::reachedApplicationCacheOriginQuota): Deleted. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::webProcessDataStoreParameters): * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary): (WebKit::WebsiteDataStore::fetchDataAndApply): (WebKit::WebsiteDataStore::removeData): * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h: (WebKit::WebsiteDataStore::resolvedCacheStorageDirectory const): (WebKit::WebsiteDataStore::applicationCacheFlatFileSubdirectoryName const): Deleted. (WebKit::WebsiteDataStore::resolvedApplicationCacheDirectory const): Deleted. * Source/WebKit/UIProcess/glib/WebProcessProxyGLib.cpp: (WebKit::WebProcessProxy::platformGetLaunchOptions): * Source/WebKit/WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h: (API::InjectedBundle::PageUIClient::didReachApplicationCacheOriginQuota): Deleted. * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageClearApplicationCache): (WKBundlePageClearApplicationCacheForOrigin): (WKBundlePageSetAppCacheMaximumSize): (WKBundlePageGetAppCacheUsageForOrigin): (WKBundlePageCopyOriginsWithApplicationCache): (WKBundlePageSetApplicationCacheOriginQuota): Deleted. (WKBundlePageResetApplicationCacheOriginQuota): Deleted. * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: * Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp: * Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: (WebKit::InjectedBundlePageUIClient::didReachApplicationCacheOriginQuota): Deleted. * Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageUIClient.h: * Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp: (WebKit::WebLoaderStrategy::scheduleLoad): * Source/WebKit/WebProcess/Network/WebResourceLoader.cpp: (WebKit::WebResourceLoader::willSendRequest): (WebKit::WebResourceLoader::didReceiveResponse): (WebKit::WebResourceLoader::didFailResourceLoad): * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::reachedMaxAppCacheSize): Deleted. (WebKit::WebChromeClient::reachedApplicationCacheOriginQuota): Deleted. * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::m_unifiedTextReplacementController): * Source/WebKit/WebProcess/WebProcess.cpp: (WebKit::WebProcess::setWebsiteDataStoreParameters): (WebKit::WebProcess::didClose): * Source/WebKit/WebProcess/WebProcess.h: (WebKit::WebProcess::applicationCacheStorage): Deleted. * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformSetWebsiteDataStoreParameters): * Tools/TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm: (TEST): * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Deleted. * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: * Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota): Deleted. * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h: (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota): Deleted. Canonical link: https://commits.webkit.org/275114@main

webkit-commit-queue · 2024-02-21T19:02:29Z

Committed 275114@main (bcbd49c): https://commits.webkit.org/275114@main

Reviewed commits have been landed. Closing PR #24669 and removing active labels.

szewai self-assigned this Feb 17, 2024

szewai added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Feb 17, 2024

szewai force-pushed the eng/Remove-ApplicationCache-code-from-WebKit branch from 49ebbd4 to a7431cc Compare February 17, 2024 01:31

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 17, 2024

szewai removed the merging-blocked Applied to prevent a change from being merged label Feb 19, 2024

szewai force-pushed the eng/Remove-ApplicationCache-code-from-WebKit branch from a7431cc to 07e5b4f Compare February 19, 2024 19:54

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 19, 2024

szewai removed the merging-blocked Applied to prevent a change from being merged label Feb 20, 2024

szewai force-pushed the eng/Remove-ApplicationCache-code-from-WebKit branch from 07e5b4f to fe33951 Compare February 20, 2024 00:27

szewai marked this pull request as ready for review February 20, 2024 17:50

szewai requested review from a team, cdumez and JonWBedard as code owners February 20, 2024 17:50

szewai requested a review from achristensen07 February 20, 2024 17:51

achristensen07 requested changes Feb 20, 2024

View reviewed changes

szewai force-pushed the eng/Remove-ApplicationCache-code-from-WebKit branch from fe33951 to 05f7af7 Compare February 20, 2024 21:35

szewai requested a review from achristensen07 February 20, 2024 21:36

achristensen07 approved these changes Feb 21, 2024

View reviewed changes

szewai added the merge-queue Applied to send a pull request to merge-queue label Feb 21, 2024

webkit-commit-queue force-pushed the eng/Remove-ApplicationCache-code-from-WebKit branch from 05f7af7 to bcbd49c Compare February 21, 2024 19:02

webkit-commit-queue merged commit bcbd49c into WebKit:main Feb 21, 2024

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove ApplicationCache code from WebKit #24669

Remove ApplicationCache code from WebKit #24669

szewai commented Feb 17, 2024 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Feb 17, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 17, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 19, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 20, 2024 •

edited

Loading

cdumez commented Feb 20, 2024

achristensen07 Feb 20, 2024

szewai Feb 20, 2024

achristensen07 Feb 20, 2024

achristensen07 Feb 20, 2024

szewai Feb 20, 2024

webkit-early-warning-system commented Feb 20, 2024 •

edited

Loading

achristensen07 left a comment

achristensen07 Feb 21, 2024

webkit-commit-queue commented Feb 21, 2024

Remove ApplicationCache code from WebKit #24669

Remove ApplicationCache code from WebKit #24669

Conversation

szewai commented Feb 17, 2024 • edited by webkit-early-warning-system Loading

bcbd49c

webkit-early-warning-system commented Feb 17, 2024 • edited Loading

webkit-early-warning-system commented Feb 17, 2024 • edited Loading

webkit-early-warning-system commented Feb 19, 2024 • edited Loading

webkit-early-warning-system commented Feb 20, 2024 • edited Loading

cdumez commented Feb 20, 2024

achristensen07 Feb 20, 2024

Choose a reason for hiding this comment

szewai Feb 20, 2024

Choose a reason for hiding this comment

achristensen07 Feb 20, 2024

Choose a reason for hiding this comment

achristensen07 Feb 20, 2024

Choose a reason for hiding this comment

szewai Feb 20, 2024

Choose a reason for hiding this comment

webkit-early-warning-system commented Feb 20, 2024 • edited Loading

achristensen07 left a comment

Choose a reason for hiding this comment

achristensen07 Feb 21, 2024

Choose a reason for hiding this comment

webkit-commit-queue commented Feb 21, 2024

szewai commented Feb 17, 2024 •

edited by webkit-early-warning-system

Loading

`bcbd49c`

webkit-early-warning-system commented Feb 17, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 17, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 19, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 20, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 20, 2024 •

edited

Loading