Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebGPU] GPU process crashes when Metal debug validation is enabled and https://webgpu.github.io/webgpu-samples/samples/particles is opened (269756) #24788

Conversation

mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented Feb 20, 2024

@mwyrzykowski mwyrzykowski self-assigned this Feb 20, 2024
@mwyrzykowski mwyrzykowski added the WebGPU For bugs in WebGPU label Feb 20, 2024
Copy link
Contributor

@djg djg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mwyrzykowski mwyrzykowski added the merge-queue Applied to send a pull request to merge-queue label Feb 20, 2024
https://webgpu.github.io/webgpu-samples/samples/particles is opened (269756)

https://bugs.webkit.org/show_bug.cgi?id=269756
<radar://123269255>

Reviewed by Dan Glastonbury.

Array lengths should refrence the webBinding and not the generated metal binding.
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::addPipelineLayouts):

Canonical link: https://commits.webkit.org/275026@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-GPU-process-crashes-when-Metal-debug-validation-is-enabled-and-httpswebgpu-github-iowebgpu-samplessamplesparticles-is-opened branch from 390f4b6 to de8e668 Compare February 20, 2024 07:44
@webkit-commit-queue
Copy link
Collaborator

Committed 275026@main (de8e668): https://commits.webkit.org/275026@main

Reviewed commits have been landed. Closing PR #24788 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit de8e668 into WebKit:main Feb 20, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebGPU For bugs in WebGPU
Projects
None yet
4 participants