Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WK_LIBFUZZER_COVERAGE should default to trace-pc-guard when Fuzzilli is enabled #24823

Merged
merged 1 commit into from
Feb 21, 2024
Merged

WK_LIBFUZZER_COVERAGE should default to trace-pc-guard when Fuzzilli is enabled #24823

merged 1 commit into from
Feb 21, 2024

Conversation

ddkilzer
Copy link
Contributor

@ddkilzer ddkilzer commented Feb 20, 2024 •
edited by webkit-early-warning-system
Loading

3bea246

WK_LIBFUZZER_COVERAGE should default to trace-pc-guard when Fuzzilli is enabled
https://bugs.webkit.org/show_bug.cgi?id=269796
<rdar://123317614>

Reviewed by Yusuke Suzuki.

* Configurations/Sanitizers.xcconfig:
(WK_SANITIZER_OTHER_LDFLAGS):
- Remove support for WK_FUZZILLI_OTHER_LDFLAGS_YES since it's no longer
  needed.
(WK_LIBFUZZER_COVERAGE):
- Default to trace-pc-guard when ENABLE_FUZZILLI=YES.
(WK_FUZZILLI_OTHER_CFLAGS_YES):
- Remove redundant -fsanitize-coverage=trace-pc-guard for Fuzzilli.
(WK_FUZZILLI_OTHER_LDFLAGS_YES): Remove.

Canonical link: https://commits.webkit.org/275102@main

e1fdc82

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@ddkilzer ddkilzer self-assigned this Feb 20, 2024
@ddkilzer ddkilzer added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Feb 20, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 20, 2024 •
edited
Loading

EWS run on current version of this PR (hash e1fdc82)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

Constellation
Constellation approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@ddkilzer ddkilzer added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 21, 2024
@ddkilzer
WK_LIBFUZZER_COVERAGE should default to trace-pc-guard when Fuzzilli …
3bea246 
…is enabled

https://bugs.webkit.org/show_bug.cgi?id=269796
<rdar://123317614>

Reviewed by Yusuke Suzuki.

* Configurations/Sanitizers.xcconfig:
(WK_SANITIZER_OTHER_LDFLAGS):
- Remove support for WK_FUZZILLI_OTHER_LDFLAGS_YES since it's no longer
  needed.
(WK_LIBFUZZER_COVERAGE):
- Default to trace-pc-guard when ENABLE_FUZZILLI=YES.
(WK_FUZZILLI_OTHER_CFLAGS_YES):
- Remove redundant -fsanitize-coverage=trace-pc-guard for Fuzzilli.
(WK_FUZZILLI_OTHER_LDFLAGS_YES): Remove.

Canonical link: https://commits.webkit.org/275102@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WK_LIBFUZZER_COVERAGE-should-default-to-trace-pc-guard-when-Fuzzilli-is-enabled branch from e1fdc82 to 3bea246 Compare February 21, 2024 16:38
@webkit-commit-queue
Copy link
Collaborator

Committed 275102@main (3bea246): https://commits.webkit.org/275102@main

Reviewed commits have been landed. Closing PR #24823 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 3bea246 into WebKit:main Feb 21, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 21, 2024
@ddkilzer ddkilzer deleted the eng/WK_LIBFUZZER_COVERAGE-should-default-to-trace-pc-guard-when-Fuzzilli-is-enabled branch February 21, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Constellation Constellation Constellation approved these changes

@emw-apple emw-apple Awaiting requested review from emw-apple emw-apple is a code owner

@MenloDorian MenloDorian Awaiting requested review from MenloDorian

Assignees

@ddkilzer ddkilzer

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
4 participants
@ddkilzer @webkit-early-warning-system @webkit-commit-queue @Constellation