[iOS] Fail camera capture if there is no media environment #24873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash c1716da)
|
webkit-ews-buildbot
added
the
merging-blocked
eric-carlson
approved these changes
Feb 21, 2024
youennf
force-pushed
the
eng/iOS-Fail-camera-capture-if-there-is-no-media-environment
branch
from
c1716da
to
fabc035
Compare
|
EWS run on previous version of this PR (hash fabc035)
|
youennf
removed
the
merging-blocked
youennf
force-pushed
the
eng/iOS-Fail-camera-capture-if-there-is-no-media-environment
branch
from
fabc035
to
4ea61cb
Compare
|
EWS run on current version of this PR (hash 4ea61cb)
|
https://bugs.webkit.org/show_bug.cgi?id=269837 rdar://121770895 Reviewed by Eric Carlson. Update UserMediaCaptureManagerProxy::startProducingData to fail capture early if there is the browser entitlement, capture is for camera and there is no media environment. We add an ASSERT to MockRealtimeVideoSource::startProducingData and logging in AVVideoCaptureSource::setupSession. * Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp: (WebCore::RealtimeMediaSourceCenter::setCurrentMediaEnvironment): * Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.h: * Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm: (WebCore::AVVideoCaptureSource::setupSession): * Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp: (WebCore::MockRealtimeVideoSource::startProducingData): * Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp: * Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp: (WebKit::UserMediaCaptureManagerProxy::startProducingData): * Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.h: (WebKit::UserMediaCaptureManagerProxy::ConnectionProxy::setCurrentMediaEnvironment): * Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/275169@main
webkit-commit-queue
force-pushed
the
eng/iOS-Fail-camera-capture-if-there-is-no-media-environment
branch
from
4ea61cb
to
857b349
Compare
|
Committed 275169@main (857b349): https://commits.webkit.org/275169@main Reviewed commits have been landed. Closing PR #24873 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
857b349
4ea61cb
🧪 wpe-wk2🧪 gtk-wk2🧪 mac-AS-debug-wk2🧪 api-gtk